From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by mx.groups.io with SMTP id smtpd.web11.8104.1621760108142793243
 for <devel@edk2.groups.io>;
 Sun, 23 May 2021 01:55:08 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=TE5oqU4p;
 spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: lersek@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1621760107;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=Q6XO3niqSD0fLqeueB0azJFvAi4HUNtJQr+2uoJpy88=;
	b=TE5oqU4pg0hbDHxOKzZMyuqKACNqD/i6uOVmlyrT26QkqimWy4rkR4dFMznlix7iZRxHgN
	Hi7HYkmO5rHRGkA1HlP1Pkk2LWVR3YOVCEtPpeemdQiPFAqNm3AVC1+cgAXhp4IyXkX+fc
	ADpEi6Awp1+8PzENyEARfj0oyck5qYc=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-282-_9TiQnyFNHOTuMgLs7hrig-1; Sun, 23 May 2021 04:55:04 -0400
X-MC-Unique: _9TiQnyFNHOTuMgLs7hrig-1
Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 55CF3801B12;
	Sun, 23 May 2021 08:55:03 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-112-8.ams2.redhat.com [10.36.112.8])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id AFF2A61F20;
	Sun, 23 May 2021 08:55:01 +0000 (UTC)
Subject: Re: [edk2-devel] [PATCH] ArmPkg/ArmGic: Fix maximum number of interrupts in GICv3
To: devel@edk2.groups.io, joey.gouly@arm.com
Cc: "ardb+tianocore@kernel.org" <ardb+tianocore@kernel.org>,
 "leif@nuviainc.com" <leif@nuviainc.com>, Sami Mujawar
 <Sami.Mujawar@arm.com>, Andreas Sandberg <Andreas.Sandberg@arm.com>,
 nd <nd@arm.com>
References: <20210309164510.19272-1-joey.gouly@arm.com>
 <DB8PR08MB5433B1BE74D3847F4CE1E44D94299@DB8PR08MB5433.eurprd08.prod.outlook.com>
From: "Laszlo Ersek" <lersek@redhat.com>
Message-ID: <15e1864b-1eb3-921b-3b10-2aba99afc9a0@redhat.com>
Date: Sun, 23 May 2021 10:55:00 +0200
MIME-Version: 1.0
In-Reply-To: <DB8PR08MB5433B1BE74D3847F4CE1E44D94299@DB8PR08MB5433.eurprd08.prod.outlook.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit

On 05/21/21 12:49, Joey Gouly wrote:
>> From: Joey Gouly <joey.gouly@arm.com>
>> Sent: 09 March 2021 16:45
>> Subject: [PATCH] ArmPkg/ArmGic: Fix maximum number of interrupts in GICv3 
>  
> Hi,
> 
> A little ping on this. Can someone take a look?
> 
> There was a similar patch here, that addressed the same issue https://edk2.groups.io/g/devel/topic/82327316#74401 so I think it would be good get this in.

This even looks like a candidate for edk2-stable202105 to me (it's small
and arguably a clear-cut bugfix).

NB the comment style should be:

  //
  // Interrupt ID 1020-1023 are reserved:
  //

IOW, we need a trailing and a leading empty comment line, plus the
semicolon at the end of the comment should likely be a colon, or maybe
just a period.

Thanks
Laszlo

> 
> Thanks,
> Joey
> 
> 
> 
>