public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Laszlo Ersek" <lersek@redhat.com>
To: devel@edk2.groups.io, afish@apple.com,
	Mike Kinney <michael.d.kinney@intel.com>
Cc: "Gao, Liming" <liming.gao@intel.com>,
	"rebecca@bsdio.com" <rebecca@bsdio.com>,
	"Jordan Justen (Intel address)" <jordan.l.justen@intel.com>,
	Gary Lin <glin@suse.com>
Subject: Re: [edk2-devel] git submodule update --init --recursive
Date: Tue, 27 Aug 2019 15:37:20 +0200	[thread overview]
Message-ID: <160176bb-f2fe-138f-2780-c3b8afd261bc@redhat.com> (raw)
In-Reply-To: <4649CCEF-8C33-44C5-8A3F-6EFA0E549DA2@apple.com>

(+Jordan and Gary)

On 08/27/19 00:29, Andrew Fish via Groups.Io wrote:
> Mike,
> 
> I hit it when I was testing an OVMF build. It looks like the OVMF instructions reference the generic getting started guide that omits the submodule update command. 

I agree that the "BUILDING OVMF" section in "OvmfPkg/README" is out of
date. I think a bugzilla ticket would be justified.

Personally, I wouldn't like to propose actual patches, for improving
this part of "OvmfPkg/README". For me, the best way for building OVMF
has always been to write my own build scripts. In our downstream edk2
repositories at Red Hat, I provide a text file with detailed commands
that basically amount to the same.

I think that, technically speaking, the same could work for the
"OvmfPkg/README" file too. But my understanding is that many in the
upstream community dislike this approach -- many people prefer
"OvmfPkg/build.sh" instead (which I never use -- it *is* a build script
alright, but it's quite different from what I use).

"OvmfPkg/README" does mention "OvmfPkg/build.sh" in the "Build Scripts"
section. So maybe "OvmfPkg/build.sh" should be patched, to verify that
the OpenSSL submodule has been initialized. That could be another BZ (or
another patch in the series for the same BZ).

Thanks
Laszlo

      reply	other threads:[~2019-08-27 13:37 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-23 20:41 git submodule update --init --recursive Andrew Fish
2019-08-23 22:23 ` [edk2-devel] " rebecca
2019-08-26  3:54   ` Liming Gao
2019-08-26 21:59     ` Andrew Fish
2019-08-26 22:11       ` Michael D Kinney
2019-08-26 22:29         ` Andrew Fish
2019-08-27 13:37           ` Laszlo Ersek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=160176bb-f2fe-138f-2780-c3b8afd261bc@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox