From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Tue, 27 Aug 2019 06:37:24 -0700 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 60918308212D; Tue, 27 Aug 2019 13:37:23 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (unknown [10.36.118.80]) by smtp.corp.redhat.com (Postfix) with ESMTP id B28515D712; Tue, 27 Aug 2019 13:37:21 +0000 (UTC) Subject: Re: [edk2-devel] git submodule update --init --recursive To: devel@edk2.groups.io, afish@apple.com, Mike Kinney Cc: "Gao, Liming" , "rebecca@bsdio.com" , "Jordan Justen (Intel address)" , Gary Lin References: <83E89A1F-25F0-40ED-BE33-6843030DFEE4@apple.com> <35027f0c-51f3-a37a-c94a-b3df084c3981@bsdio.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E4DC1E6@SHSMSX104.ccr.corp.intel.com> <0ED23C22-D224-40E0-BB57-ACA8F1ABCEA1@apple.com> <4649CCEF-8C33-44C5-8A3F-6EFA0E549DA2@apple.com> From: "Laszlo Ersek" Message-ID: <160176bb-f2fe-138f-2780-c3b8afd261bc@redhat.com> Date: Tue, 27 Aug 2019 15:37:20 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <4649CCEF-8C33-44C5-8A3F-6EFA0E549DA2@apple.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.47]); Tue, 27 Aug 2019 13:37:23 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit (+Jordan and Gary) On 08/27/19 00:29, Andrew Fish via Groups.Io wrote: > Mike, > > I hit it when I was testing an OVMF build. It looks like the OVMF instructions reference the generic getting started guide that omits the submodule update command. I agree that the "BUILDING OVMF" section in "OvmfPkg/README" is out of date. I think a bugzilla ticket would be justified. Personally, I wouldn't like to propose actual patches, for improving this part of "OvmfPkg/README". For me, the best way for building OVMF has always been to write my own build scripts. In our downstream edk2 repositories at Red Hat, I provide a text file with detailed commands that basically amount to the same. I think that, technically speaking, the same could work for the "OvmfPkg/README" file too. But my understanding is that many in the upstream community dislike this approach -- many people prefer "OvmfPkg/build.sh" instead (which I never use -- it *is* a build script alright, but it's quite different from what I use). "OvmfPkg/README" does mention "OvmfPkg/build.sh" in the "Build Scripts" section. So maybe "OvmfPkg/build.sh" should be patched, to verify that the OpenSSL submodule has been initialized. That could be another BZ (or another patch in the series for the same BZ). Thanks Laszlo