From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web10.14684.1601991743245293968 for ; Tue, 06 Oct 2020 06:42:23 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: vijayenthiran.subramaniam@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E6B75143D; Tue, 6 Oct 2020 06:42:22 -0700 (PDT) Received: from usa.arm.com (a074939-lin.blr.arm.com [10.162.16.84]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id C8F6E3F71F; Tue, 6 Oct 2020 06:42:20 -0700 (PDT) From: "Vijayenthiran Subramaniam" To: devel@edk2.groups.io, leif@nuviainc.com, Ard.Biesheuvel@arm.com, thomas.abraham@arm.com Cc: Sami.Mujawar@arm.com, Aditya.Angadi@arm.com Subject: [edk2-platforms] [PATCH v3-resend] SgiPkg/RdN1EdgeX2: Add missing reference to PcdChipCount Date: Tue, 6 Oct 2020 19:12:16 +0530 Message-Id: <1601991736-32039-1-git-send-email-vijayenthiran.subramaniam@arm.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Commit e8fe2026dd79 (=E2=80=9CPlatform/ARM/SgiPkg: Use chip count constan= t on rdn1edgex2 platform=E2=80=9D) used the PcdChipCount constant but did not = declare its use in the ACPI table module. Fix this by listing it in the list of PCDs to be looked up. Signed-off-by: Vijayenthiran Subramaniam Reviewed-by: Thomas Abraham Reviewed-by: Sami Mujawar --- Resending PATCH-v3 [1] with Reviewed-bys added. [1]: https://edk2.groups.io/g/devel/topic/77339902 Changes since v2: - Rebased to latest master and repost. Changes since v1: - Add commit id in commit message for which this patch fixes the build failure. Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf b/Pl= atform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf index 974d9db543..d44f02ab0c 100644 --- a/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf +++ b/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf @@ -45,6 +45,8 @@ gArmSgiTokenSpaceGuid.PcdDramBlock2Base gArmSgiTokenSpaceGuid.PcdDramBlock2Size =20 + gArmSgiTokenSpaceGuid.PcdChipCount + gArmTokenSpaceGuid.PcdArmArchTimerSecIntrNum gArmTokenSpaceGuid.PcdArmArchTimerIntrNum gArmTokenSpaceGuid.PcdArmArchTimerHypIntrNum --=20 2.17.1