From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190]) by mx.groups.io with SMTP id smtpd.web08.7423.1608013964023829121 for ; Mon, 14 Dec 2020 22:32:44 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: huawei.com, ip: 45.249.212.190, mailfrom: xiewenyi2@huawei.com) Received: from DGGEMS403-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4Cw7hV10grzkr4P; Tue, 15 Dec 2020 14:31:54 +0800 (CST) Received: from HGH1000039998.huawei.com (10.184.68.188) by DGGEMS403-HUB.china.huawei.com (10.3.19.203) with Microsoft SMTP Server id 14.3.498.0; Tue, 15 Dec 2020 14:32:31 +0800 From: "wenyi,xie" To: , , , CC: , Subject: [PATCH EDK2 v2 1/1] BaseTools/GenFfs: Optimazing else if statement Date: Tue, 15 Dec 2020 14:30:46 +0800 Message-ID: <1608013846-109318-2-git-send-email-xiewenyi2@huawei.com> X-Mailer: git-send-email 2.8.1 In-Reply-To: <1608013846-109318-1-git-send-email-xiewenyi2@huawei.com> References: <1608013846-109318-1-git-send-email-xiewenyi2@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.184.68.188] X-CFilter-Loop: Reflected Content-Type: text/plain When Alignment < 0x400 is false, the expression of Alignment >= 0x400 is always true. So extract the expression from the else if statement. Cc: Bob Feng Cc: Liming Gao Cc: Yuwei Chen Signed-off-by: Wenyi Xie --- BaseTools/Source/C/GenFfs/GenFfs.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/BaseTools/Source/C/GenFfs/GenFfs.c b/BaseTools/Source/C/GenFfs/GenFfs.c index fcb911f4fc34..949025c33325 100644 --- a/BaseTools/Source/C/GenFfs/GenFfs.c +++ b/BaseTools/Source/C/GenFfs/GenFfs.c @@ -821,12 +821,11 @@ Returns: if (Alignment < 0x400){ sprintf (AlignmentBuffer, "%d", Alignment); } - else if (Alignment >= 0x400) { - if (Alignment >= 0x100000) { - sprintf (AlignmentBuffer, "%dM", Alignment/0x100000); - } else { - sprintf (AlignmentBuffer, "%dK", Alignment/0x400); - } + else if (Alignment >= 0x100000) { + sprintf (AlignmentBuffer, "%dM", Alignment/0x100000); + } + else { + sprintf (AlignmentBuffer, "%dK", Alignment/0x400); } Status = StringtoAlignment (AlignmentBuffer, &(InputFileAlign[InputFileNum])); } -- 2.20.1.windows.1