* [PATCH EDK2 v2 0/1] BaseTools/EfiRom: remove redundant checking of argc
@ 2020-12-15 6:43 wenyi,xie
2020-12-15 6:43 ` [PATCH EDK2 v2 1/1] " wenyi,xie
0 siblings, 1 reply; 3+ messages in thread
From: wenyi,xie @ 2020-12-15 6:43 UTC (permalink / raw)
To: devel, bob.c.feng, gaoliming, yuwei.chen; +Cc: songdongkuang, xiewenyi2
Main Changes since v1 :
Don't Remove error handling, only change checking to if (Argc == 1).
Wenyi Xie (1):
BaseTools/EfiRom: remove redundant checking of argc
BaseTools/Source/C/EfiRom/EfiRom.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
2.20.1.windows.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH EDK2 v2 1/1] BaseTools/EfiRom: remove redundant checking of argc
2020-12-15 6:43 [PATCH EDK2 v2 0/1] BaseTools/EfiRom: remove redundant checking of argc wenyi,xie
@ 2020-12-15 6:43 ` wenyi,xie
2020-12-21 2:03 ` [edk2-devel] " Bob Feng
0 siblings, 1 reply; 3+ messages in thread
From: wenyi,xie @ 2020-12-15 6:43 UTC (permalink / raw)
To: devel, bob.c.feng, gaoliming, yuwei.chen; +Cc: songdongkuang, xiewenyi2
As the condition of while statement is argc > 0, so argc < 1 will always
be false, it's redundant.
Cc: Bob Feng <bob.c.feng@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Yuwei Chen <yuwei.chen@intel.com>
Signed-off-by: Wenyi Xie <xiewenyi2@huawei.com>
---
BaseTools/Source/C/EfiRom/EfiRom.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/BaseTools/Source/C/EfiRom/EfiRom.c b/BaseTools/Source/C/EfiRom/EfiRom.c
index a7e2839b0a84..2506f559d574 100644
--- a/BaseTools/Source/C/EfiRom/EfiRom.c
+++ b/BaseTools/Source/C/EfiRom/EfiRom.c
@@ -1014,7 +1014,7 @@ Returns:
// Device IDs specified with -i
// Make sure there's at least one more parameter
//
- if (Argc < 1) {
+ if (Argc == 1) {
Error (NULL, 0, 2000, "Invalid parameter", "Missing Device Id with %s option!", OptionName);
ReturnStatus = 1;
goto Done;
--
2.20.1.windows.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [edk2-devel] [PATCH EDK2 v2 1/1] BaseTools/EfiRom: remove redundant checking of argc
2020-12-15 6:43 ` [PATCH EDK2 v2 1/1] " wenyi,xie
@ 2020-12-21 2:03 ` Bob Feng
0 siblings, 0 replies; 3+ messages in thread
From: Bob Feng @ 2020-12-21 2:03 UTC (permalink / raw)
To: devel@edk2.groups.io, xiewenyi2@huawei.com,
gaoliming@byosoft.com.cn, Chen, Christine
Cc: songdongkuang@huawei.com
Reviewed-by: Bob Feng <bob.c.feng@intel.com>
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of wenyi,xie via groups.io
Sent: Tuesday, December 15, 2020 2:44 PM
To: devel@edk2.groups.io; Feng, Bob C <bob.c.feng@intel.com>; gaoliming@byosoft.com.cn; Chen, Christine <yuwei.chen@intel.com>
Cc: songdongkuang@huawei.com; xiewenyi2@huawei.com
Subject: [edk2-devel] [PATCH EDK2 v2 1/1] BaseTools/EfiRom: remove redundant checking of argc
As the condition of while statement is argc > 0, so argc < 1 will always be false, it's redundant.
Cc: Bob Feng <bob.c.feng@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Yuwei Chen <yuwei.chen@intel.com>
Signed-off-by: Wenyi Xie <xiewenyi2@huawei.com>
---
BaseTools/Source/C/EfiRom/EfiRom.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/BaseTools/Source/C/EfiRom/EfiRom.c b/BaseTools/Source/C/EfiRom/EfiRom.c
index a7e2839b0a84..2506f559d574 100644
--- a/BaseTools/Source/C/EfiRom/EfiRom.c
+++ b/BaseTools/Source/C/EfiRom/EfiRom.c
@@ -1014,7 +1014,7 @@ Returns:
// Device IDs specified with -i
// Make sure there's at least one more parameter
//
- if (Argc < 1) {
+ if (Argc == 1) {
Error (NULL, 0, 2000, "Invalid parameter", "Missing Device Id with %s option!", OptionName);
ReturnStatus = 1;
goto Done;
--
2.20.1.windows.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-12-21 2:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-12-15 6:43 [PATCH EDK2 v2 0/1] BaseTools/EfiRom: remove redundant checking of argc wenyi,xie
2020-12-15 6:43 ` [PATCH EDK2 v2 1/1] " wenyi,xie
2020-12-21 2:03 ` [edk2-devel] " Bob Feng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox