public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Aaron Young via groups.io" <aaron.young=oracle.com@groups.io>
To: Laszlo Ersek <lersek@redhat.com>,devel@edk2.groups.io
Subject: Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: Optimize BmExpandPartitionDevicePath
Date: Wed, 11 Oct 2023 10:36:56 -0700	[thread overview]
Message-ID: <16085.1697045816285916965@groups.io> (raw)
In-Reply-To: <9348b3d2-eafb-ef88-9b2f-d70843afb428@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 1157 bytes --]

Thanks for the comments, Laszlo.

I could look into optimizing SetBootOrderFromQemu()->Match() by using
EfiBootManagerGetNextLoadOptionDevicePath() instead of EfiBootManagerGetLoadOptionBuffer().
Makes sense to me and at first glance seems like it would work. My main concern is some
unforeseen change in behavior that manifests in a regression somehow. Would require lots
of testing beyond what I am capable of doing.
However, I'd prefer to do this as a separate task from this PR as it's not really
related, right? i.e. EfiBootManagerGetNextLoadOptionDevicePath() still ends up
calling ConnectAll. just making sure I understand.

Also, I can look into amending the PR commit to add the call chain for ConnectDevicesFromQemu
that you menioned above.

thanks again!

-Aaron


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109526): https://edk2.groups.io/g/devel/message/109526
Mute This Topic: https://groups.io/mt/101876973/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Type: text/html, Size: 1845 bytes --]

  reply	other threads:[~2023-10-11 17:36 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-10 15:06 [edk2-devel] [PATCH 1/1] MdeModulePkg: Optimize BmExpandPartitionDevicePath Aaron Young
2023-10-10 16:38 ` Laszlo Ersek
2023-10-11 17:36   ` Aaron Young via groups.io [this message]
2023-10-12 15:14     ` Laszlo Ersek
2023-10-24  2:18 ` Gao, Zhichao
2023-10-24 12:29   ` Laszlo Ersek
2023-10-24 13:15     ` Laszlo Ersek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=16085.1697045816285916965@groups.io \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox