From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 49ABF740046 for ; Wed, 11 Oct 2023 17:36:58 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=gWXyw3PrEE+i5iuPwn84z22vvq06JHWIsX+lGN5JiLk=; c=relaxed/simple; d=groups.io; h=Subject:To:From:User-Agent:MIME-Version:Date:References:In-Reply-To:Message-ID:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20140610; t=1697045817; v=1; b=Yaa2ZOVPMdNLIpCMzLRTxjTdi+7krRf0ym4X6Fd+ZXfK1ksW5gyNXULH5Tl6wz4YTZS2UxAf y+LNN3yvOxUBSYBHzKUj8YeXETkG+U2LTL7jVEuzNoP2ontOk4nE0Bl7j6adhlmay0Oacxum19r 1Ct6ohPNgE9RuHE/UNJYiENI= X-Received: by 127.0.0.2 with SMTP id csc7YY7687511xcsR1HSeQbD; Wed, 11 Oct 2023 10:36:57 -0700 Subject: Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: Optimize BmExpandPartitionDevicePath To: Laszlo Ersek ,devel@edk2.groups.io From: "Aaron Young via groups.io" X-Originating-Location: Fremont, California, US (148.87.23.4) X-Originating-Platform: Linux Firefox 102 User-Agent: GROUPS.IO Web Poster MIME-Version: 1.0 Date: Wed, 11 Oct 2023 10:36:56 -0700 References: <9348b3d2-eafb-ef88-9b2f-d70843afb428@redhat.com> In-Reply-To: <9348b3d2-eafb-ef88-9b2f-d70843afb428@redhat.com> Message-ID: <16085.1697045816285916965@groups.io> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,aaron.young@oracle.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: PcDnIVNdeJcV0yXTtAcv0DR9x7686176AA= Content-Type: multipart/alternative; boundary="W075xrTkfm7lJcMFlJss" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=Yaa2ZOVP; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io --W075xrTkfm7lJcMFlJss Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Thanks for the comments, Laszlo. I could look into optimizing SetBootOrderFromQemu()->Match() by using EfiBootManagerGetNextLoadOptionDevicePath() instead of EfiBootManagerGetLoa= dOptionBuffer(). Makes sense to me and at first glance seems like it would work. My main con= cern is some unforeseen change in behavior that manifests in a regression somehow. Would= require lots of testing beyond what I am capable of doing. However, I'd prefer to do this as a separate task from this PR as it's not = really related, right? i.e. EfiBootManagerGetNextLoadOptionDevicePath() still ends= up calling ConnectAll. just making sure I understand. Also, I can look into amending the PR commit to add the call chain for Conn= ectDevicesFromQemu that you menioned above. thanks again! -Aaron -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109526): https://edk2.groups.io/g/devel/message/109526 Mute This Topic: https://groups.io/mt/101876973/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --W075xrTkfm7lJcMFlJss Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable


 Thanks for the comments, Laszlo.=

 I could look into optimizing SetBootOr= derFromQemu()->Match() by using
 EfiBootManagerGetNextLoadOpti= onDevicePath() instead of EfiBootManagerGetLoadOptionBuffer().
 M= akes sense to me and at first glance seems like it would work. My main conc= ern is some
 unforeseen change in behavior that manifests in a re= gression somehow. Would require lots
 of testing beyond what I am= capable of doing.
 However, I'd prefer to do this as a separate = task from this PR as it's not really
 related, right? i.e. EfiBoo= tManagerGetNextLoadOptionDevicePath() still ends up
 calling Conn= ectAll. just making sure I understand.

 Also, I can look into amending the PR = commit to add the call chain for ConnectDevicesFromQemu
 that you= menioned above.

 thanks again!

 -Aaron

_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#109526) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--W075xrTkfm7lJcMFlJss--