* [PATCH EDK2 v1 0/1] SecurityPkg/FvReportPei: remove redundant sizeof
@ 2021-04-13 12:33 wenyi,xie
2021-04-13 12:33 ` [PATCH EDK2 v1 1/1] " wenyi,xie
0 siblings, 1 reply; 3+ messages in thread
From: wenyi,xie @ 2021-04-13 12:33 UTC (permalink / raw)
To: devel, jiewen.yao, jian.j.wang, lersek; +Cc: songdongkuang, xiewenyi2
Main Changes :
remove redundant sizeof.
Wenyi Xie (1):
SecurityPkg/FvReportPei: remove redundant sizeof
SecurityPkg/FvReportPei/FvReportPei.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
2.20.1.windows.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH EDK2 v1 1/1] SecurityPkg/FvReportPei: remove redundant sizeof
2021-04-13 12:33 [PATCH EDK2 v1 0/1] SecurityPkg/FvReportPei: remove redundant sizeof wenyi,xie
@ 2021-04-13 12:33 ` wenyi,xie
2021-04-13 13:16 ` Laszlo Ersek
0 siblings, 1 reply; 3+ messages in thread
From: wenyi,xie @ 2021-04-13 12:33 UTC (permalink / raw)
To: devel, jiewen.yao, jian.j.wang, lersek; +Cc: songdongkuang, xiewenyi2
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3333
In function InstallPreHashFvPpi, when calculatuing the size
of struct HASH_INFO，sizeof is used twice.
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Signed-off-by: Wenyi Xie <xiewenyi2@huawei.com>
---
SecurityPkg/FvReportPei/FvReportPei.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/SecurityPkg/FvReportPei/FvReportPei.c b/SecurityPkg/FvReportPei/FvReportPei.c
index d709760ea3ce..e82413e090c0 100644
--- a/SecurityPkg/FvReportPei/FvReportPei.c
+++ b/SecurityPkg/FvReportPei/FvReportPei.c
@@ -67,7 +67,7 @@ InstallPreHashFvPpi (
HASH_INFO *HashInfo;
PpiSize = sizeof (EDKII_PEI_FIRMWARE_VOLUME_INFO_PREHASHED_FV_PPI)
- + sizeof (sizeof (HASH_INFO))
+ + sizeof (HASH_INFO)
+ HashSize;
PreHashedFvPpi = AllocatePool (PpiSize);
--
2.20.1.windows.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH EDK2 v1 1/1] SecurityPkg/FvReportPei: remove redundant sizeof
2021-04-13 12:33 ` [PATCH EDK2 v1 1/1] " wenyi,xie
@ 2021-04-13 13:16 ` Laszlo Ersek
0 siblings, 0 replies; 3+ messages in thread
From: Laszlo Ersek @ 2021-04-13 13:16 UTC (permalink / raw)
To: Wenyi Xie, devel, jiewen.yao, jian.j.wang; +Cc: songdongkuang
On 04/13/21 14:33, Wenyi Xie wrote:
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3333
>
> In function InstallPreHashFvPpi, when calculatuing the size
(1) s/calculatuing/calculating/
(2) I suggest remarking, in the commit message, that this bug does not
lead to buffer overflow, given that "sizeof (HASH_INFO)" is 4, whereas
"sizeof (sizeof (HASH_INFO))" is 4 or 8.
> of struct HASH_INFO，sizeof is used twice.
>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Signed-off-by: Wenyi Xie <xiewenyi2@huawei.com>
> ---
> SecurityPkg/FvReportPei/FvReportPei.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/SecurityPkg/FvReportPei/FvReportPei.c b/SecurityPkg/FvReportPei/FvReportPei.c
> index d709760ea3ce..e82413e090c0 100644
> --- a/SecurityPkg/FvReportPei/FvReportPei.c
> +++ b/SecurityPkg/FvReportPei/FvReportPei.c
> @@ -67,7 +67,7 @@ InstallPreHashFvPpi (
> HASH_INFO *HashInfo;
>
> PpiSize = sizeof (EDKII_PEI_FIRMWARE_VOLUME_INFO_PREHASHED_FV_PPI)
> - + sizeof (sizeof (HASH_INFO))
> + + sizeof (HASH_INFO)
> + HashSize;
>
> PreHashedFvPpi = AllocatePool (PpiSize);
>
>From my perspective:
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-04-13 13:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-04-13 12:33 [PATCH EDK2 v1 0/1] SecurityPkg/FvReportPei: remove redundant sizeof wenyi,xie
2021-04-13 12:33 ` [PATCH EDK2 v1 1/1] " wenyi,xie
2021-04-13 13:16 ` Laszlo Ersek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox