From: "wenyi,xie" <xiewenyi2@huawei.com>
To: <devel@edk2.groups.io>, <jian.j.wang@intel.com>, <hao.a.wu@intel.com>
Cc: <songdongkuang@huawei.com>, <wanghuiqiang@huawei.com>,
<xiewenyi2@huawei.com>
Subject: [PATCH EDK2 v1 1/1] MdeModulePkg: Modify PCD default value
Date: Thu, 15 Jul 2021 20:24:55 +0800 [thread overview]
Message-ID: <1626351895-21064-2-git-send-email-xiewenyi2@huawei.com> (raw)
In-Reply-To: <1626351895-21064-1-git-send-email-xiewenyi2@huawei.com>
From: "wenyi.xie" <xiewenyi2@huawei.com>
The default value of PcdSrIovSystemPageSize is 0x1, it means
the memory BAR is 4KB alignment. When page size of OS is set
to 64KB, as the resource partitions are different between OS
and BIOS, it will cause pcie failture. And if 52 bit physical
address need to be supported, page size should also be set to
64KB alignment.
So modify the default vaule of PcdSrIovSystemPageSize to 0x10
can meet the requirement above. And even if the OS is 4KB
alignment, new value of PCD is compatible for this situation.
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Hao A Wu <hao.a.wu@intel.com>
Signed-off-by: Wenyi Xie <xiewenyi2@huawei.com>
---
MdeModulePkg/MdeModulePkg.dec | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModulePkg/MdeModulePkg.dec
index ad84421cf3..426ea1b6cc 100644
--- a/MdeModulePkg/MdeModulePkg.dec
+++ b/MdeModulePkg/MdeModulePkg.dec
@@ -1853,7 +1853,7 @@
# BIT0 set indicates 4KB alignment<BR>
# BIT1 set indicates 8KB alignment<BR>
# @Prompt SRIOV system page size.
- gEfiMdeModulePkgTokenSpaceGuid.PcdSrIovSystemPageSize|0x1|UINT32|0x10000047
+ gEfiMdeModulePkgTokenSpaceGuid.PcdSrIovSystemPageSize|0x10|UINT32|0x10000047
## SMBIOS version.
# @Prompt SMBIOS version.
--
2.20.1.windows.1
next prev parent reply other threads:[~2021-07-15 12:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-15 12:24 [PATCH EDK2 v1 0/1] MdeModulePkg: Modify PCD default value wenyi,xie
2021-07-15 12:24 ` wenyi,xie [this message]
2021-07-16 1:27 ` [edk2-devel] [PATCH EDK2 v1 1/1] " Wu, Hao A
2021-07-19 2:34 ` Ni, Ray
2021-07-19 6:02 ` wanghuiqiang
2021-07-19 6:36 ` wanghuiqiang
2021-07-23 8:15 ` wanghuiqiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1626351895-21064-2-git-send-email-xiewenyi2@huawei.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox