From: "Masami Hiramatsu" <masami.hiramatsu@linaro.org>
To: Ard Biesheuvel <ard.biesheuvel@arm.com>,
Leif Lindholm <leif@nuviainc.com>
Cc: devel@edk2.groups.io,
Kazuhiko Sakamoto <sakamoto.kazuhiko@socionext.com>
Subject: [PATCH 1/4] Silicon/SynQuacerNetsecDxe: Test the ControllerHandle is managed by this driver
Date: Wed, 13 Oct 2021 14:36:51 +0900 [thread overview]
Message-ID: <163410341134.323609.17991695355751540906.stgit@localhost> (raw)
In-Reply-To: <163410340292.323609.10978291802739074305.stgit@localhost>
From: Kazuhiko Sakamoto <sakamoto.kazuhiko@socionext.com>
Test the @ControllerHandle is not NULL and is actually managed by
this driver.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Kazuhiko Sakamoto <sakamoto.kazuhiko@socionext.com>
Signed-off-by: Masami Hiramatsu <masami.hiramatsu@linaro.org>
---
.../Drivers/Net/NetsecDxe/ComponentName.c | 13 +++++++++++++
.../Drivers/Net/NetsecDxe/DriverBinding.c | 1 -
.../SynQuacer/Drivers/Net/NetsecDxe/NetsecDxe.h | 1 +
3 files changed, 14 insertions(+), 1 deletion(-)
diff --git a/Silicon/Socionext/SynQuacer/Drivers/Net/NetsecDxe/ComponentName.c b/Silicon/Socionext/SynQuacer/Drivers/Net/NetsecDxe/ComponentName.c
index 44b3daa0af..743fa88384 100644
--- a/Silicon/Socionext/SynQuacer/Drivers/Net/NetsecDxe/ComponentName.c
+++ b/Silicon/Socionext/SynQuacer/Drivers/Net/NetsecDxe/ComponentName.c
@@ -159,6 +159,19 @@ NetsecGetControllerName (
OUT CHAR16 **ControllerName
)
{
+ EFI_STATUS Status;
+
+ if (!ControllerHandle) {
+ return EFI_INVALID_PARAMETER;
+ }
+
+ Status = EfiTestManagedDevice (ControllerHandle,
+ gNetsecDriverBinding.DriverBindingHandle,
+ &gEdkiiNonDiscoverableDeviceProtocolGuid);
+ if (EFI_ERROR (Status)) {
+ return Status;
+ }
+
if (ChildHandle != NULL) {
return EFI_UNSUPPORTED;
}
diff --git a/Silicon/Socionext/SynQuacer/Drivers/Net/NetsecDxe/DriverBinding.c b/Silicon/Socionext/SynQuacer/Drivers/Net/NetsecDxe/DriverBinding.c
index 392d1b474f..fa0c415e98 100644
--- a/Silicon/Socionext/SynQuacer/Drivers/Net/NetsecDxe/DriverBinding.c
+++ b/Silicon/Socionext/SynQuacer/Drivers/Net/NetsecDxe/DriverBinding.c
@@ -131,7 +131,6 @@ NetsecDriverBindingStop (
}
-STATIC
EFI_DRIVER_BINDING_PROTOCOL gNetsecDriverBinding = {
NetsecDriverBindingSupported,
NetsecDriverBindingStart,
diff --git a/Silicon/Socionext/SynQuacer/Drivers/Net/NetsecDxe/NetsecDxe.h b/Silicon/Socionext/SynQuacer/Drivers/Net/NetsecDxe/NetsecDxe.h
index cf2abb0ab1..9b3d19c033 100644
--- a/Silicon/Socionext/SynQuacer/Drivers/Net/NetsecDxe/NetsecDxe.h
+++ b/Silicon/Socionext/SynQuacer/Drivers/Net/NetsecDxe/NetsecDxe.h
@@ -27,6 +27,7 @@
#include "netsec_for_uefi/pfdep.h"
extern EFI_COMPONENT_NAME2_PROTOCOL gNetsecDriverComponentName2;
+extern EFI_DRIVER_BINDING_PROTOCOL gNetsecDriverBinding;
/*--------------- Simple Network Driver entry point functions ----------------*/
next prev parent reply other threads:[~2021-10-13 5:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-13 5:36 [PATCH 0/4] SynQuacer drivers test the ControllerHandle correctly Masami Hiramatsu
2021-10-13 5:36 ` Masami Hiramatsu [this message]
2021-10-13 5:36 ` [PATCH 2/4] Silicon/SynQuacerI2cDxe: Test the ControllerHandle is managed by this driver Masami Hiramatsu
2021-10-13 5:37 ` [PATCH 3/4] Silicon/AtSha204a: " Masami Hiramatsu
2021-10-13 5:37 ` [PATCH 4/4] Silicon/ChaosKeyDxe: " Masami Hiramatsu
2021-10-27 11:21 ` [PATCH 0/4] SynQuacer drivers test the ControllerHandle correctly Leif Lindholm
2021-10-27 13:55 ` [edk2-devel] " Samer El-Haj-Mahmoud
2021-10-27 15:10 ` Leif Lindholm
2021-10-28 0:53 ` Masami Hiramatsu
2021-11-01 17:16 ` Leif Lindholm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=163410341134.323609.17991695355751540906.stgit@localhost \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox