From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f177.google.com (mail-pg1-f177.google.com [209.85.215.177]) by mx.groups.io with SMTP id smtpd.web12.9306.1638519162252287790 for ; Fri, 03 Dec 2021 00:12:42 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=krRusxuj; spf=pass (domain: linaro.org, ip: 209.85.215.177, mailfrom: masami.hiramatsu@linaro.org) Received: by mail-pg1-f177.google.com with SMTP id r138so2276243pgr.13 for ; Fri, 03 Dec 2021 00:12:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=lckDZkeMYgafbLZ1FyQyhHBtnlSVOKPOXlsb3m4ikP4=; b=krRusxujk8LIBhhM1aDvoW03UQMxQjxZKFeUbkOkjg4zeF2FIi6vGmUumGsgf/0uhR myWqCmpvhj1FQbinXxtAh1ckmkFv/rZwAIRGvkOs/XKcplM0kuDHKKv62YH5X68c6tYj H8Ks3WGUNPjD0Ym0JH/Usc6Y53eu617TYLutq3LzHBB+kiJ32uFOugRTCM2Xfh/HlmXJ ouCv5y53u8R8m6vKV9nLFqxz2oGpf20RYRO2McIROaqfoDv+YaJJh5R/wjJ0NdmZdJ/F gkAKevXDsFxh8TOx7PJ+SztaalLfdOg4vKE07OrjgbwDflizMNg6tWilOgrN/PQq7Cx6 geSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=lckDZkeMYgafbLZ1FyQyhHBtnlSVOKPOXlsb3m4ikP4=; b=AOS+gUhE0aegC0TZ7NX8schwwhGjQOQvqmh9qzUNO9R1Gi58gdYrxuIjoyzVtxvsiu TRbD25Pi4KGIOZDEUq3eVRURB0V+Ua8Safy6ijP5EMK0XqcEbTdlS8o32NqE3JhAYTii qjpPfC9yODvact72rJ6kD48Q2Zz69Q2hnLhW31oEBfwfUoW8mAcr0E1/b/QAAGYYEjy5 4L1g5fBiprVhnFL7zKKPs8RybZWZI+7j00gUs5jS+7ufpmrdDj4ffxU+VdSKdHmUt5Wv gGUWJkmB6WI7xT0llBGZJyAC8yB9etYcTVodWUggffCckAQjpwLtJQlhB/yU7Ki4LQ2C 6jVQ== X-Gm-Message-State: AOAM530TQrGpDGzVPU+tKtrmMbbSYKnjKyygjuKH93RMbqJBABUP430f 0R3y93BzZLPsN8Xd7KifEPvHqg== X-Google-Smtp-Source: ABdhPJyYhNJMTjOQ02V5i7TMXYKuTKYaFrrnvcCkaqRmdoJVFkRS2Y1kqt6+VwuoJFtqe/kwbUwGbA== X-Received: by 2002:a63:654:: with SMTP id 81mr3403484pgg.218.1638519161735; Fri, 03 Dec 2021 00:12:41 -0800 (PST) Return-Path: Received: from localhost.localdomain (122x208x150x49.ap122.ftth.ucom.ne.jp. [122.208.150.49]) by smtp.gmail.com with ESMTPSA id f185sm2202481pfg.39.2021.12.03.00.12.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Dec 2021 00:12:41 -0800 (PST) From: "Masami Hiramatsu" To: Ard Biesheuvel , Leif Lindholm Cc: devel@edk2.groups.io, Kazuhiko Sakamoto , Masahisa Kojima Subject: [PATCH v2 3/5] [edk2-platforms] Silicon/Socionext/SynQuacer: Fix to read watchdog parameters with correct width Date: Fri, 3 Dec 2021 17:12:39 +0900 Message-Id: <163851915888.1636051.2034037309423270728.stgit@localhost> X-Mailer: git-send-email 2.25.1 In-Reply-To: <163851913341.1636051.3357297397950801289.stgit@localhost> References: <163851913341.1636051.3357297397950801289.stgit@localhost> User-Agent: StGit/0.19 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Since the RefreshFramePhysicalAddress and WatchdogControlFramePhysicalAddress fields are defined as UINT64 in EFI_ACPI_6_0_GTDT_SBSA_GENERIC_WATCHDOG_STRUCTURE data structure, and both of gArmTokenSpaceGuid.PcdGenericWatchdogRefreshBase and gArmTokenSpaceGuid.PcdGenericWatchdogControlBase are defined as UINT64, FixedPcdGet64() should be used for reading and setting those parameters. Signed-off-by: Masami Hiramatsu --- Silicon/Socionext/SynQuacer/AcpiTables/Gtdt.aslc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Silicon/Socionext/SynQuacer/AcpiTables/Gtdt.aslc b/Silicon/Socionext/SynQuacer/AcpiTables/Gtdt.aslc index e7ab88b0a8..b045a49efa 100644 --- a/Silicon/Socionext/SynQuacer/AcpiTables/Gtdt.aslc +++ b/Silicon/Socionext/SynQuacer/AcpiTables/Gtdt.aslc @@ -74,8 +74,8 @@ EFI_ACPI_6_0_GENERIC_TIMER_DESCRIPTION_TABLES Gtdt = { // UINT32 GTxCommonFlags }, EFI_ACPI_6_0_SBSA_GENERIC_WATCHDOG_STRUCTURE_INIT ( - FixedPcdGet32 (PcdGenericWatchdogRefreshBase), - FixedPcdGet32 (PcdGenericWatchdogControlBase), + FixedPcdGet64 (PcdGenericWatchdogRefreshBase), + FixedPcdGet64 (PcdGenericWatchdogControlBase), FixedPcdGet32 (PcdGenericWatchdogEl2IntrNum), 0), };