From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) by mx.groups.io with SMTP id smtpd.web12.4023.1639119059067424524 for ; Thu, 09 Dec 2021 22:50:59 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=mWTrgpwC; spf=pass (domain: linaro.org, ip: 209.85.216.50, mailfrom: masami.hiramatsu@linaro.org) Received: by mail-pj1-f50.google.com with SMTP id y14-20020a17090a2b4e00b001a5824f4918so8730813pjc.4 for ; Thu, 09 Dec 2021 22:50:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=lckDZkeMYgafbLZ1FyQyhHBtnlSVOKPOXlsb3m4ikP4=; b=mWTrgpwCiGdhx1tXqi1exOG0td+qsOMfy77EmWCNWWAs40meIWgMYHpWROwHYnUDSP t031EcF4VkpSnJjgBwVKziJDYh0IbCnahfjOZh8jXP1LCP8UGzQ/I2bztJBzQcDcJvg5 Kuvcq9siF5RbijgFfPwtFb1jB/os0KIk1SrJk0R4zMD9fSilDG+tj/50eHQGMgtJ2ISI 7SSfoL4pqv12y6LGghBoDc6j8IdYFq/czjEWvmluHRQzNQtkA+vpQ286YkvQjVlBensI dEkYixSdQ/cPMZM6frwwJl3XnWUKlzlaQbWVbF/kq1qHf5aaZP80EkPvzt+BBxt80/7L J5Mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=lckDZkeMYgafbLZ1FyQyhHBtnlSVOKPOXlsb3m4ikP4=; b=2W6B466UOk6qBZJIudlbqD6bVJLtc5WFOfnixQ7TY6ZJ5wHTlF7zuIiP6QkzPnXsv7 9meQ6cUw/f/tAp/IlqNNNMo1JZgAiHC37Fed1s8aDq++VmOyxASRIHkwOM7kCgg5X8re IbipurIMfd1PZcnA7IQ+JjJx1S7gfHPJU1HzA06rp2DaX1lcL5I9R0mfqq4w2HZHfU4/ 7CC1l8vO4cAjS1TrwiJk2ptlcRZ1fOB5XcA5IZXSJQBSSPZ3f27ysKtsg4gXnRMY7aOm nMjcs3/4sGdO4Bab07VpwYpci8MuReLN1ySvnp9Fe7BZpWgBDKTuYQ0fzBt8FzvobkkU y8AA== X-Gm-Message-State: AOAM533JBf1e8Qo0cNdjBjzqDOA4l365awZywrbR8HQaDuz2a7Btm2P1 CZO94qmFTIHziM/DX4WygplrPQ== X-Google-Smtp-Source: ABdhPJwJlmY8aXfWzTG8kbLVUpYQ90dfIbgr79JoVGdHbGVW7hGhNA5ZkFlvpdsaps23HR8nxVn8lA== X-Received: by 2002:a17:90b:1e4e:: with SMTP id pi14mr21512743pjb.161.1639119058575; Thu, 09 Dec 2021 22:50:58 -0800 (PST) Return-Path: Received: from localhost.localdomain (122x208x150x49.ap122.ftth.ucom.ne.jp. [122.208.150.49]) by smtp.gmail.com with ESMTPSA id 38sm1487813pgl.73.2021.12.09.22.50.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Dec 2021 22:50:58 -0800 (PST) From: "Masami Hiramatsu" To: Ard Biesheuvel , Leif Lindholm Cc: devel@edk2.groups.io, Kazuhiko Sakamoto , Masahisa Kojima Subject: [PATCH v3 3/6] [edk2-platforms] Silicon/Socionext/SynQuacer: Fix to read watchdog parameters with correct width Date: Fri, 10 Dec 2021 15:50:55 +0900 Message-Id: <163911905553.561661.2074085895260559105.stgit@localhost> X-Mailer: git-send-email 2.25.1 In-Reply-To: <163911902995.561661.9429300579159746333.stgit@localhost> References: <163911902995.561661.9429300579159746333.stgit@localhost> User-Agent: StGit/0.19 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Since the RefreshFramePhysicalAddress and WatchdogControlFramePhysicalAddress fields are defined as UINT64 in EFI_ACPI_6_0_GTDT_SBSA_GENERIC_WATCHDOG_STRUCTURE data structure, and both of gArmTokenSpaceGuid.PcdGenericWatchdogRefreshBase and gArmTokenSpaceGuid.PcdGenericWatchdogControlBase are defined as UINT64, FixedPcdGet64() should be used for reading and setting those parameters. Signed-off-by: Masami Hiramatsu --- Silicon/Socionext/SynQuacer/AcpiTables/Gtdt.aslc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Silicon/Socionext/SynQuacer/AcpiTables/Gtdt.aslc b/Silicon/Socionext/SynQuacer/AcpiTables/Gtdt.aslc index e7ab88b0a8..b045a49efa 100644 --- a/Silicon/Socionext/SynQuacer/AcpiTables/Gtdt.aslc +++ b/Silicon/Socionext/SynQuacer/AcpiTables/Gtdt.aslc @@ -74,8 +74,8 @@ EFI_ACPI_6_0_GENERIC_TIMER_DESCRIPTION_TABLES Gtdt = { // UINT32 GTxCommonFlags }, EFI_ACPI_6_0_SBSA_GENERIC_WATCHDOG_STRUCTURE_INIT ( - FixedPcdGet32 (PcdGenericWatchdogRefreshBase), - FixedPcdGet32 (PcdGenericWatchdogControlBase), + FixedPcdGet64 (PcdGenericWatchdogRefreshBase), + FixedPcdGet64 (PcdGenericWatchdogControlBase), FixedPcdGet32 (PcdGenericWatchdogEl2IntrNum), 0), };