From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail-qk1-f174.google.com (mail-qk1-f174.google.com [209.85.222.174])
 by mx.groups.io with SMTP id smtpd.web12.2029.1615510997064384622
 for <devel@edk2.groups.io>;
 Thu, 11 Mar 2021 17:03:17 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@linaro.org header.s=google header.b=siThlxzt;
 spf=pass (domain: linaro.org, ip: 209.85.222.174, mailfrom: shashi.mallela@linaro.org)
Received: by mail-qk1-f174.google.com with SMTP id a9so22721771qkn.13
        for <devel@edk2.groups.io>; Thu, 11 Mar 2021 17:03:16 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=message-id:subject:from:to:cc:date:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=cX3O1rVwRracXxPAOVyt4lf3xTs64UFpwXbM9fRNjbk=;
        b=siThlxztZVrzY1w/6irPKj3IPGCGS7htRUtjQaIz6SdRm6GZk+MLFWjZDzPv76YTeB
         Z8fRrDB7IE4EtsNYJ8WYk9gckSOA6I26scgNiwV8Fu4WHoDFbF9xZcKBSpOHj3CcvBFo
         POi8qjXBolDv7IQx18An5wBpKCvQF5MUpg5+esrS6CfGYzAEi3PVZH8dYzTej415I3zy
         1WuLv+ep6eVL5cPmDeWYtlM2ba83uAUttzuDi5DjMtfWalsCAbaTz6NiRgtohn5VO9Sm
         YGbhoJDOZh/5yQTSK5S01ixiZW0vp04moHb2yloVmPk2PM5uEYRqynqdkR2ikd3WZjN9
         JBvQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=cX3O1rVwRracXxPAOVyt4lf3xTs64UFpwXbM9fRNjbk=;
        b=PARxwdxpGkp1Vxrr7gTE32Mu8wmFWdd7aah0rtV0oRZFw2HbEqJoHyEcimVyKEVPlc
         8XaXLcn5m7dHD7ibO5Sr5ucpQPuwBTdvU6lBTsYq2E3PNQGLOeFHW9HZXPCsxKkkL7VG
         gCkCy8iPrM+AqxtlrzYZgd8xriTXDixGUXSJ7WfLGyeXyEpAe6D8NDyANBCN9eDyWUsg
         pMgqL1oDQdXz2YM/dC4FtqjwFvQAHsZ2qIHvBtrbkOvdYqDhQ0Z29jj5pzk024uMRDXd
         S0N2RBHMHn2Zc0FypHo0Ia1D17T3Mo9MBL2LjOPm9eYCOcrA0d0Y+wgXOcf3ESlZzgqn
         i/Kw==
X-Gm-Message-State: AOAM531z/j4UqaNNXtEG5Zub6qogxSSx12+ao1/5XqCJleVJ8nQzHCsj
	5zTgiu900PbYBFCDSju4EBhumw==
X-Google-Smtp-Source: ABdhPJzml+YnYOMmc1c2tPCmRQhUlXaSgPynAS4V19VWZa+7Z9986vwVxSU4wKOVZzR/QEoac2pbjQ==
X-Received: by 2002:a37:a281:: with SMTP id l123mr10601017qke.218.1615510996212;
        Thu, 11 Mar 2021 17:03:16 -0800 (PST)
Return-Path: <shashi.mallela@linaro.org>
Received: from localhost.localdomain (bras-base-stsvon1503w-grc-23-174-92-28-187.dsl.bell.ca. [174.92.28.187])
        by smtp.gmail.com with ESMTPSA id g7sm2968371qti.20.2021.03.11.17.03.15
        (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
        Thu, 11 Mar 2021 17:03:15 -0800 (PST)
Message-ID: <163c596982de9418a3a759ae238d13c5579aad95.camel@linaro.org>
Subject: Re: [PATCH v1] ArmPkg/ArmPkg.dec: New pcd defined for GICv3 ITS
From: "Shashi Mallela" <shashi.mallela@linaro.org>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: Leif Lindholm <leif@nuviainc.com>, Ard Biesheuvel
 <ardb+tianocore@kernel.org>, Ray Ni <ray.ni@intel.com>, devel@edk2.groups.io
Date: Thu, 11 Mar 2021 20:03:15 -0500
In-Reply-To: <CAMj1kXGN_EEQHEy5B1PU-A8rGMojXU3vgvjJfcA00A+8d4fAOg@mail.gmail.com>
References: <20210311202020.29125-1-shashi.mallela@linaro.org>
	 <CAMj1kXGN_EEQHEy5B1PU-A8rGMojXU3vgvjJfcA00A+8d4fAOg@mail.gmail.com>
X-Mailer: Evolution 3.28.5 (3.28.5-14.el8) 
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit

Hi Ard,

Thanks for your comments.
Please ignore this edk2 patch as i have now localised the new pcd
creation and reference within SbsaQemu of edk2-platform.
The edk2-platform patchset has been updated accordingly.

Shashi

On Thu, 2021-03-11 at 22:12 +0100, Ard Biesheuvel wrote:
> Hello Shashi,
> 
> On Thu, 11 Mar 2021 at 21:20, Shashi Mallela <
> shashi.mallela@linaro.org> wrote:
> > To enable detection of GICv3 Interrupt Translation Service
> > capability
> > in the ACPI MADT,a new pcd setting has been created in edk2.This
> > pcd
> > setting would be referenced by edk2-platform code to advertise the
> > ITS
> > physical base address within GIC ITS structure of MADT.
> > 
> 
> This does not explain why the PCD in question should be defined in
> ArmPkg. UEFI itself does not use interrupts other than the timer one
> in the first place, so ITS, LPI, MSI etc are also irrelevant to it.
> 
> I think it would be better to find a home for this PCD in edk2-
> platforms itself.
> 
> 
> > Cc: Leif Lindholm <leif@nuviainc.com>
> > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> > Signed-off-by: Shashi Mallela <shashi.mallela@linaro.org>
> > ---
> >  ArmPkg/ArmPkg.dec | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/ArmPkg/ArmPkg.dec b/ArmPkg/ArmPkg.dec
> > index a8a22c649f..c22b7d0c42 100644
> > --- a/ArmPkg/ArmPkg.dec
> > +++ b/ArmPkg/ArmPkg.dec
> > @@ -266,6 +266,7 @@
> >    # Base address for the GIC Redistributor region that contains
> > the boot CPU
> >    gArmTokenSpaceGuid.PcdGicRedistributorsBase|0|UINT64|0x0000000E
> >    gArmTokenSpaceGuid.PcdGicInterruptInterfaceBase|0|UINT64|0x00000
> > 00D
> > +  gArmTokenSpaceGuid.PcdGicItsBase|0|UINT64|0x0000000F
> >    gArmTokenSpaceGuid.PcdGicSgiIntId|0|UINT32|0x00000025
> > 
> >    #
> > --
> > 2.27.0
> >