Hi Ard,<br /><br />On Thu, May 18, 2023 at 08:17 AM, Ard Biesheuvel wrote:<br />
<blockquote>Given the wider discussion we had the other day about tightening<br />memory protections, I think it is important that we get this fixed but<br />I don't think there is any urgency to it. I sent some patches a couple<br />of months ago to map DxeCore code and data with tightened permissions<br />as well, and I think we can revisit this in that context the next time<br />around.<br /><br />So for now, just passing the stack size as you suggested above is<br />sufficient IMO.</blockquote>
[SAMI] Thanks, I will submit a v2 series with the changes. <br /><br />I also observed that a similar change would be needed for ArmPlatformPkg/PrePi at<br /><a href="https://github.com/tianocore/edk2/blob/master/ArmPlatformPkg/PrePi/PrePi.c#L164" target="_blank" rel="noopener">https://github.com/tianocore/edk2/blob/master/ArmPlatformPkg/PrePi/PrePi.c#L164</a><br />As of now we do not enable PcdCpuStackGuard in <br />edk2-platforms\Platform\ARM\VExpressPkg\ArmVExpress.dsc.inc<br />But if this is done the same stack overflow issue is seen on the FVP model.<br /><br />Considering that, should I send out a patch for ArmPlatformPkg/PrePi as well? <br /><br />Also, I think it be good to enable the stack guard check in<br />edk2-platforms\Platform\ARM\VExpressPkg\ArmVExpress.dsc.inc.<br />Please let me know your thoughts about this.<br /><br />[/SAMI]<br /><br />Regards,<br /><br />Sami Mujawar