From mboxrd@z Thu Jan 1 00:00:00 1970 Subject: Re: [edk2-devel] [PATCH v1 5/6] ArmVirtPkg: Kvmtool: Increase primary core stack size To: Ard Biesheuvel ,devel@edk2.groups.io From: "Sami Mujawar" X-Originating-Location: Cambridge, England, GB (217.140.106.53) X-Originating-Platform: Windows Firefox 113 User-Agent: GROUPS.IO Web Poster MIME-Version: 1.0 Date: Thu, 18 May 2023 08:43:21 -0700 References: In-Reply-To: Message-ID: <16418.1684424601377431919@groups.io> Content-Type: multipart/alternative; boundary="0LPcohTYAxZe9uzD1m1B" --0LPcohTYAxZe9uzD1m1B Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi Ard, On Thu, May 18, 2023 at 08:17 AM, Ard Biesheuvel wrote: >=20 > Given the wider discussion we had the other day about tightening > memory protections, I think it is important that we get this fixed but > I don't think there is any urgency to it. I sent some patches a couple > of months ago to map DxeCore code and data with tightened permissions > as well, and I think we can revisit this in that context the next time > around. >=20 > So for now, just passing the stack size as you suggested above is > sufficient IMO. [SAMI] Thanks, I will submit a v2 series with the changes. I also observed that a similar change would be needed for ArmPlatformPkg/Pr= ePi at https://github.com/tianocore/edk2/blob/master/ArmPlatformPkg/PrePi/PrePi.c#= L164 As of now we do not enable PcdCpuStackGuard in edk2-platforms\Platform\ARM\VExpressPkg\ArmVExpress.dsc.inc But if this is done the same stack overflow issue is seen on the FVP model. Considering that, should I send out a patch for ArmPlatformPkg/PrePi as wel= l? Also, I think it be good to enable the stack guard check in edk2-platforms\Platform\ARM\VExpressPkg\ArmVExpress.dsc.inc. Please let me know your thoughts about this. [/SAMI] Regards, Sami Mujawar --0LPcohTYAxZe9uzD1m1B Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi Ard,

On Thu, May 18, 2023 at 08:17 AM, Ard Biesheuvel wrote:<= br />
Given the wider discussion we had the other day about tightenin= g
memory protections, I think it is important that we get this fixed b= ut
I don't think there is any urgency to it. I sent some patches a cou= ple
of months ago to map DxeCore code and data with tightened permissi= ons
as well, and I think we can revisit this in that context the next = time
around.

So for now, just passing the stack size as you= suggested above is
sufficient IMO.
[SAMI] Thanks, I will submit a v2 series with the changes.

I al= so observed that a similar change would be needed for ArmPlatformPkg/PrePi = at
https://github.= com/tianocore/edk2/blob/master/ArmPlatformPkg/PrePi/PrePi.c#L164
A= s of now we do not enable PcdCpuStackGuard in
edk2-platforms\Platform= \ARM\VExpressPkg\ArmVExpress.dsc.inc
But if this is done the same stac= k overflow issue is seen on the FVP model.

Considering that, sho= uld I send out a patch for ArmPlatformPkg/PrePi as well?

Also, = I think it be good to enable the stack guard check in
edk2-platforms\P= latform\ARM\VExpressPkg\ArmVExpress.dsc.inc.
Please let me know your t= houghts about this.

[/SAMI]

Regards,

Sami = Mujawar --0LPcohTYAxZe9uzD1m1B--