From mboxrd@z Thu Jan 1 00:00:00 1970 Subject: Re: [edk2-devel] [edk2-platforms][PATCH v1 2/4] CometlakeOpenBoardPkg/Acpi: BoardAcpiDxe also installs all PcdAcpiTableStorageFile To: Chaganty, Rangasai V ,devel@edk2.groups.io From: "Benjamin Doron" X-Originating-Location: Thornhill, Ontario, CA (24.52.200.135) X-Originating-Platform: Linux Firefox 90 User-Agent: GROUPS.IO Web Poster MIME-Version: 1.0 Date: Wed, 04 Aug 2021 14:51:03 -0700 References: In-Reply-To: Message-ID: <16445.1628113863694031707@groups.io> Content-Type: multipart/alternative; boundary="q1uc9mdSU61OhQixRcmy" --q1uc9mdSU61OhQixRcmy Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi Sai, There may be a requirement to install board-specific ACPI tables. For exam= ple, to support an embedded controller in laptops, or other controllers in = servers and desktops. In a conversation with Nate about a board port in KabylakeOpenBoardPkg, I = said that the options for such boards would be to include AcpiPlatformDxe, = or, since BoardAcpiDxe seems to be a superset of AcpiPlatformDxe functional= ity, add it here by calling PublishAcpiTablesFromFv() again with this GUID. Perhaps an RFC first would have been best. I don't mind dropping this patc= hset, but can we wait for comments first? Best regards, Benjamin --q1uc9mdSU61OhQixRcmy Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi Sai,
There may be a requirement to install board-specific ACPI tabl= es. For example, to support an embedded controller in laptops, or other con= trollers in servers and desktops.

In a conversation with Nate ab= out a board port in KabylakeOpenBoardPkg, I said that the options for such = boards would be to include AcpiPlatformDxe, or, since BoardAcpiDxe seems to= be a superset of AcpiPlatformDxe functionality, add it here by calling Pub= lishAcpiTablesFromFv() again with this GUID.

Perhaps an RFC firs= t would have been best. I don't mind dropping this patchset, but can we wai= t for comments first?

Best regards,
Benjamin --q1uc9mdSU61OhQixRcmy--