From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.81]) by mx.groups.io with SMTP id smtpd.web12.9353.1581423391106102977 for ; Tue, 11 Feb 2020 04:16:31 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=hgMxuh63; spf=pass (domain: redhat.com, ip: 207.211.31.81, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1581423390; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2pJ30rrWuMY2tt+EWm3bWJXkYa+0mWmKIJGQwfJyCZg=; b=hgMxuh63WSmwbZ79B0VKJzWdjy4GOU7wuqsQzPp/JfbnJDsgc0wdvzdk9GSrNYWBd0Tj6y Gk5aRsDynsmIG3MTeP6QrhF4D4e9nOcV8Z4iK4AqiDbr/BjLZfzRnFP5TW5ijw6p+rKdLV W7PBPXlxRJGhgUZKmGqZjLJj+97kzqQ= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-203-DOrwxFDkOjOKFIFwHEG7Yw-1; Tue, 11 Feb 2020 07:16:23 -0500 Received: by mail-wr1-f69.google.com with SMTP id v17so6718605wrm.17 for ; Tue, 11 Feb 2020 04:16:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=T5fmY4KZwR6hvV6au1TjR1S+s6XshvgF+RDnFSkV8I8=; b=Kiie8cH8EdaIhB4JWkj2/870RZr87CCb9d2tRlLY7uT3Io9RlWBlv+l5ONxGvauldK ftg+zdIyq5pJNeYl4aYBl/YvAlVEefG5iNAvFNClbfnKTVLJ0HTwh8f8/vEwakbs35Qz boXQM6Gbt8S8YHlYc8INpTO2U40tf8fLFoezqwjZAzpsb6RfnZEZMnGATbE5R+PhTxrL 5E1rZLMGXzl4QxdUHM8gIy9++zdpzopRzdqR3WGyhIjF3fD7stOMrmEGdtKNDXJFpM6G Ijhgp6XISf5XkC4OxLkSoQUcY9N/dgMJ83r0cT1B5DEVChBCFKixXQoDATXbqf8/F8oS 5Pwg== X-Gm-Message-State: APjAAAVEX8/gpCgxTWLRGnh55MLtHV2gr+Ol8LiuGVQbinbezzVxH6V6 eaR+GJxAvRmWCUyO0ZS3Q/RBZoQNl5D974iN1bzyg76uga/lKAjlPm3UaAhaLB8/OOzey14XcMD DApicdyzoo848rQ== X-Received: by 2002:a1c:4c0c:: with SMTP id z12mr5324567wmf.63.1581423381478; Tue, 11 Feb 2020 04:16:21 -0800 (PST) X-Google-Smtp-Source: APXvYqzjG9M01OriFD+ukOFLtDETphy4dMO5pp/tZX54gsVfJEj0LFW6imhr0aeGVr1p7HH9T+obPw== X-Received: by 2002:a1c:4c0c:: with SMTP id z12mr5324482wmf.63.1581423380293; Tue, 11 Feb 2020 04:16:20 -0800 (PST) Return-Path: Received: from [192.168.1.35] (78.red-88-21-202.staticip.rima-tde.net. [88.21.202.78]) by smtp.gmail.com with ESMTPSA id q1sm5106409wrw.5.2020.02.11.04.16.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 Feb 2020 04:16:19 -0800 (PST) Subject: Re: [edk2-devel] [PATCH v2 0/2] ShellPkg: Document the use of EFI_INVALID_PARAMETER by two functions From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= To: "Gao, Zhichao" , "devel@edk2.groups.io" Cc: "Ni, Ray" References: <20191219140932.25428-1-philmd@redhat.com> <3CE959C139B4C44DBEA1810E3AA6F9000B8BF8A5@SHSMSX101.ccr.corp.intel.com> <692bf71f-dd33-d8db-914c-2867845434ac@redhat.com> <3CE959C139B4C44DBEA1810E3AA6F9000B8BF8E2@SHSMSX101.ccr.corp.intel.com> <2c83fb1c-3080-bd31-6408-fb29cb51de75@redhat.com> Message-ID: <16518204-d1b1-34c4-7cb6-0b74e9eb35bb@redhat.com> Date: Tue, 11 Feb 2020 13:16:18 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: X-MC-Unique: DOrwxFDkOjOKFIFwHEG7Yw-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 2/5/20 12:04 AM, Philippe Mathieu-Daud=C3=A9 wrote: > On 1/31/20 6:31 AM, Gao, Zhichao wrote: >> Hi, >> >> I have tried with the commit. It pass the check. >=20 > Good news, thanks for checking :) >=20 > Is there anything else I should do to get this series applied? I see these patches were merged as ddb7050c6843 and 7f9e354a01d7 (my=20 name mojibaked unfortunately). Thank to the anonymous maintainer who=20 merged it! > Thanks, >=20 > Phil. >=20 >>> -----Original Message----- >>> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >>> Philippe Mathieu-Daud=C3=A9 >>> Sent: Tuesday, January 21, 2020 7:24 PM >>> To: Gao, Zhichao ; devel@edk2.groups.io >>> Cc: Ni, Ray >>> Subject: Re: [edk2-devel] [PATCH v2 0/2] ShellPkg: Document the use of >>> EFI_INVALID_PARAMETER by two functions >>> >>> Hi Zhichao, >>> >>> On 1/7/20 8:37 AM, Gao, Zhichao wrote: >>>>> -----Original Message----- >>>>> From: Philippe Mathieu-Daud=C3=A9 [mailto:philmd@redhat.com] >>>>> Sent: Tuesday, January 7, 2020 3:10 PM >>>>> To: Gao, Zhichao ; devel@edk2.groups.io >>>>> Cc: Ni, Ray >>>>> Subject: Re: [PATCH v2 0/2] ShellPkg: Document the use of >>>>> EFI_INVALID_PARAMETER by two functions >>>>> >>>>> On 1/7/20 8:01 AM, Gao, Zhichao wrote: >>>>>>> -----Original Message----- >>>>>>> From: Philippe Mathieu-Daude >>>>>>> Sent: Thursday, December 19, 2019 10:10 PM >>>>>>> To: devel@edk2.groups.io >>>>>>> Cc: Ni, Ray ; Gao, Zhichao >>>>>>> ; Philippe Mathieu-Daude >>>>>>> Subject: [PATCH v2 0/2] ShellPkg: Document the use of >>>>>>> EFI_INVALID_PARAMETER by two functions >>>>>>> >>>>>>> Complete the list of values the functios ParseCommandLineToArgs() >>>>>>> and >>>>>>> UpdateArgcArgv() can return. >>>>>>> >>>>>>> The documentation was found to be incomplete while reviewing=20 >>>>>>> BZ#2395: >>>>>>> https://edk2.groups.io/g/devel/message/51512 >>>>>>> >>>>>>> v2: >>>>>>> - Shortened patch #1 subject to fit 72 chars >>>>>> >>>>>> The subject should be less than 72 chars (do not include 72 chars). >>>>> >>>>> What is the rationale for this restriction? Some tool limitation? >>>> >>>> Yes. There is a patch check tool in BaseTools\Scripts\=20 >>>> PatchCheck.py. And the >>> patch #1 can't pass the check. >>> >>> Since the patch "BaseTools/PatchCheck.py: Ignore CR and LF characters = in >>> subject length" got merged as commit 2649a735b24, can you retry to=20 >>> merge this >>> patch? >>> >>> Thanks, >>> >>> Phil. >>> >>> >>>=20 >>