From mboxrd@z Thu Jan 1 00:00:00 1970 Subject: Re: [edk2-devel] [edk2-rfc] [edk2-platforms] Add Features directory To: Kubacki, Michael A ,devel@edk2.groups.io From: "Ni, Ray" X-Originating-Location: Beijing, CN (192.55.46.46) X-Originating-Platform: Windows Chrome 78 User-Agent: GROUPS.IO Web Poster MIME-Version: 1.0 Date: Thu, 21 Nov 2019 00:05:07 -0800 References: In-Reply-To: Message-ID: <16528.1574323507806442601@groups.io> Content-Type: multipart/alternative; boundary="PG8PxZ6QCxf0dAFUgD1a" --PG8PxZ6QCxf0dAFUgD1a Content-Type: text/plain; charset="utf-8"; markup=markdown Content-Transfer-Encoding: quoted-printable Basically I think the "/Features" directory is a good idea. It separates th= e common features from the concrete platforms. Minor comment: Given today here are "Drivers", "Platform" and "Silicon" un= der the root of edk2-platforms repo, do you think that it's better to use "= /Feature" to align existing names? I also wanted to change "Drivers" to "Driver" (https://edk2.groups.io/g/de= vel/message/47203?p=3D,,,20,0,0,0::Created,,OptionRomPkg,20,2,0,33080721) --PG8PxZ6QCxf0dAFUgD1a Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable

Basically I think the "/Features" directory is a good idea. It= separates the common features from the concrete platforms. Minor comment: Given today here are "Drivers", "Platform&qu= ot; and "Silicon" under the root of edk2-platforms repo, do you t= hink that it's better to use "/Feature" to align existing names?<= /p>

I also wanted to change "Drivers" to "Driver" (https://edk2.groups.io/g= /devel/message/47203?p=3D,,,20,0,0,0::Created,,OptionRomPkg,20,2,0,33080721= )

--PG8PxZ6QCxf0dAFUgD1a--