From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (NAM11-BN8-obe.outbound.protection.outlook.com [40.107.236.41]) by mx.groups.io with SMTP id smtpd.web08.13024.1659875139187756148 for ; Sun, 07 Aug 2022 05:25:40 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@ami.com header.s=selector1 header.b=Mx1TxrKg; spf=pass (domain: ami.com, ip: 40.107.236.41, mailfrom: igork@ami.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DS1WQ9/UO7+DHYM8uf6WYmp3/YXA5qDsRD8hBGc8+5b6IeN62PU2mWSXI5iS04qLrlaZB9CylQqI9lx553xuDujXnuNgymOaceHwrCTdj4R3ABOLVOjxiadRrGD0n6WQxGJj4RMXwtgM2cte3pdIgFljn2ccDlWlkUaX9Fm04UtRfwkPOQ0fgrQQ2wSDdIWxtevH/QPqheENeoLHoa83N241+ae8yuSvndi848LflQUbULvUtVDt3/zdYUTlhgKf2tOzPrCk/PIHsekaHVtQ01pazLZIWr+gM2Peii8W/2Nmvvqer3ydOM4LZDuMyqme5S7lEOcWSw3e+HcWuPHxjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QOaI0IMmsEpPAdR657YJbMRhTWnuXmI8ttWILR3g57E=; b=WXJYi0XT7rJ3ljOfhekDvW6LMWiPfAfRBfBsZtwfS6y36AVoCHuZZg2oS0Qo+8Ouw1D/mKg5qHFseJhs+CHfso5oeX6xWemBaK/ISnR68l2jnXb3KONKQHiHS0zeiEEv6WVRSXWDTXuTpfYtoQpjBs6MbnLJA+yn6FaRLiIAMzhq+Z/TRNq1ZFkDQUNbi0lngnVDzuVDIRCkQZZP2N5Nc1sIVuChv5B+5vgtnXWeT4mvD6sCuI3p/JlwrSkiv9Dwg3tqp+LPX17SFwe6/SwPLrvpR6lSH/+jGk9gvMB/SLW5zz8rRdPemp++e0t0WXBPjG3dhcz28WC/3Ny05Q1NmQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=ami.com; dmarc=pass action=none header.from=ami.com; dkim=pass header.d=ami.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ami.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QOaI0IMmsEpPAdR657YJbMRhTWnuXmI8ttWILR3g57E=; b=Mx1TxrKgM7AOsDyWr51eg/l0x71+dX0fEXNSFBylUCuvq32X/5OX8zwYAo4N3mwF6bG6VcBTOGYjpa08V9+/xlaYF3FLNYOQYjN2IWgDR2ZvYYsBuqZJQ6x/DLiz9vBpIuE0Dc6t85UYHbKZvKJaCaLScZzZE4RlT4fyzJcxKgE= Received: from BLAPR10MB5185.namprd10.prod.outlook.com (2603:10b6:208:328::16) by BN6PR10MB1908.namprd10.prod.outlook.com (2603:10b6:404:106::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5504.14; Sun, 7 Aug 2022 12:25:36 +0000 Received: from BLAPR10MB5185.namprd10.prod.outlook.com ([fe80::9da7:b02b:d292:d57c]) by BLAPR10MB5185.namprd10.prod.outlook.com ([fe80::9da7:b02b:d292:d57c%7]) with mapi id 15.20.5504.019; Sun, 7 Aug 2022 12:25:36 +0000 From: "Igor Kulchytskyy" To: "devel@edk2.groups.io" CC: "Abner.Chang@amd.com" , "nickle.wang@hpe.com" , Igor Kulchytskyy Subject: [PATCH] RedfishPkg: RedfishDiscoverDxe: USB Redfish host interface is not supported Thread-Topic: [PATCH] RedfishPkg: RedfishDiscoverDxe: USB Redfish host interface is not supported Thread-Index: AQHYqljLKVm7X4buzUSN71MsFikpzA== Date: Sun, 7 Aug 2022 12:25:36 +0000 Message-ID: <1659875125-9504-1-git-send-email-igork@ami.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=ami.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: fd73ad02-dedd-4222-2f9e-08da786fee5c x-ms-traffictypediagnostic: BN6PR10MB1908:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: uhUUOaodsVx92Pgb+GQdLu55jhJDJ2JwCBjeVOrEhhwsAGs4FZEdM4lxGr1U5KAK+W96487R7/D/X9+jY+2/pz4j6I4bl/nD7K3W807gRQ6KikyB/X4nF8WK4uIW7Egcvqs5zsC0RDINV9JCE6SeYcVJLlvqh0ndm+kWAKJtLJ2xv0CIIBEq5bDJBB4izS6LmCLWaSb7WdnyoO26XH2AvSK4LCgSkyuQAeJ8ez4JfUeudFz5XqJNeo7PXwMLuiz9edGRud1b6qcZORtayELQZl4WUrPbnx49zU8adSJqd9mlC5nukocQqSg4UglaLDlWxPwfGMGIVgj7TSQlp5qZ7nLB/25ti9MtSHgzWHBb3exlHim95kNgGVKwbFNjqoukb8nQzZcsmI8vH0k25IoMStoR3q0OIsLIidtP0TpDbD+2eyZMGBGVt6Q/g1EYRN02BUE3cz5odXZGdz1Mh10P60ECRQcufnYdHSq3edmaH4tOiQC6JpGSu8uOp4t1/U3/hPPmOOfs/A6ye3EJHiuksboorLAIu2bZ5sfILapUkbi+PFxr7bAiUlWVlBu9fm1FWxrR5p6S7myInuwu5w+xiZXSL0sxqaSMYbIJSdl/pOKxOj2Q8fU48+MQH2vdQjUcMhauA/rCZAwLr4s0aT7jlHFA5gCO61310EFhb8Bg2+4kcaGPHcLQcAnkk/GMHSqY8S7uXaC4POZ9TWyrmaXVeUtcNSRWpXg/6AL/dgkzmX2ihVeBiiS4iZ0Ly+YnMcW1ZEzLlXEry70w3qxyMpbZ3/IA+m7o5TuGLHE73gOai0UgRb5ynW/IVCMSKPtCJFFc x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5185.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(136003)(39830400003)(366004)(376002)(396003)(346002)(6512007)(86362001)(41300700001)(6506007)(26005)(122000001)(38070700005)(38100700002)(83380400001)(2616005)(186003)(8936002)(5660300002)(2906002)(66556008)(76116006)(66946007)(66476007)(66446008)(64756008)(4326008)(8676002)(91956017)(316002)(478600001)(36756003)(6916009)(54906003)(6486002)(40140700001)(71200400001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?UqRRi7PssLuYx2JD9R+FDPHB4VfKMCzd5QptUWMuEpp0dotkuGYugEKBWt?= =?iso-8859-1?Q?D9PSfk3rw8De/en1M8rHh+6NzCwC5lq10606qvZTC6ukCCsItytWpO673x?= =?iso-8859-1?Q?f1VGqVgUIjANOlX+qTBmD/loF8Teb+ATmLH6GMcS5k6qbanPRlB1L8+WO5?= =?iso-8859-1?Q?W1gHZuRp/yfj0JBw/d6I/b56ohO6kUyLDVu5AWRlTHzP2H9797OhlJOyYN?= =?iso-8859-1?Q?bhL++x8AHEjNW1CzWB7E9wo0CA9ehdZSxx0nrA/Nravufc9Ekc7IC6mFjE?= =?iso-8859-1?Q?T93NZjvcpIffmhEQ4NylM5bEQleCbCwwqXMI6f4FQLWLw6XuG7qEsHjc8I?= =?iso-8859-1?Q?fu5LIvbF+14KThGkUh24PTNdILl7+1ErVSDyhWmbgGjx42oh5wtJBinI/k?= =?iso-8859-1?Q?+aL0cHIokaUsUSMkSDM7CrfroLsQp/y1Jd+Jjpx0ZV7U9gKZ4bNvTv36dM?= =?iso-8859-1?Q?h7WKcwYyj+gnOEjEw85Hvnbi2pQn8Qpi+J2q8mwyn2bzYSs5fHwmCpJeZ8?= =?iso-8859-1?Q?eNi94qDfczgQt+gyW9+nGHnqr2aKOW/3Tu6+YHF0p/alTGvkLwoBPQ+xh4?= =?iso-8859-1?Q?qdzP3y/w6QA/Ilg4rruj6kUKNOpRGPOgk4/+vbfqB2WqXXKebPRtd9ORNB?= =?iso-8859-1?Q?f5gyzTH5rrttEeyPTO+cBR3r7ca81QMFvG1ZB3fWFuOXrgWQ8pRnz4s+av?= =?iso-8859-1?Q?LT9nza0iVULgI7TNHhWd/XGdovn2JpL6regmdMxe/8B9vvMsI3hbSBbwXH?= =?iso-8859-1?Q?pyzeaCdv2M/Suf+Byyovf/08UV1NQgSRiMuaoPLOO7VOliNVFLZ2r7SLzo?= =?iso-8859-1?Q?3HTfAYYHFC/84LBrLt3rhFO3fuLCQINwf9ozN15awJlsSU3KG77jJS0lLS?= =?iso-8859-1?Q?/T1GGa/qFaipLqFkZODVFVO2WHp2rqg386AUQQU/1G1VipURWRFofHSUWA?= =?iso-8859-1?Q?HDxkTHgkEHDW/67ngg1rIhVKTvSgKtXLK+uVYuAayQ06BCVn8Ib3IZ68jl?= =?iso-8859-1?Q?/pLOXnZ0ZpztV/nEltG7TS0LkLU5HtRDbmUVe1YeQ75P5yt6qSsvBzqIsv?= =?iso-8859-1?Q?V50e4UsDlSbbPTKSnjDaHeV37pfrrR0t4/k6M1ViRqPIKb5E1mDtOZbJPJ?= =?iso-8859-1?Q?MmBC5jKdmmXKwGrcwSQbq6+3a/W1eBEOSYybETz/GN8vlQ5+Gzo18DnfIN?= =?iso-8859-1?Q?wc3tLY1mGo6xzG38osBB5TLvXFVXOaEikEyqfSGkO6cOF/MvzHONth840c?= =?iso-8859-1?Q?kvUIq3+5EatIk7ph8R/XZtDJ9iXkE4ZodrVpVJlReXWH6crCPHk0IfqBW3?= =?iso-8859-1?Q?ijBzA4NfOMZ54uRByNP1FI3ZS6OhFfz5Edr9Mh4LExQx88GpfP5cBTuUvC?= =?iso-8859-1?Q?BzxpJuDFcCUF3GPhTJPnNAPea7TFW5anxOqhLAJs48yUYaebPGq1dzuN9w?= =?iso-8859-1?Q?VNO7ZhWtVeJL7Qbe3Ug0f1PW5PjLk4dWi1zQegCaueqKs9b4JZpE95bc0O?= =?iso-8859-1?Q?cWv2Qx2fguWpZcJKw8kWsT/noQSI0evFaGlQUFGmrOIAvBy0fLnDVGshEW?= =?iso-8859-1?Q?bbAqbh7VoZmeJDppWJ69VU62PoXzpm57FDIWoP63AaGxkdzIfc6M3hFlz0?= =?iso-8859-1?Q?ppC4K5fvRjjeWieeO5FkudAYyAJzi67phv?= MIME-Version: 1.0 X-OriginatorOrg: ami.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5185.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fd73ad02-dedd-4222-2f9e-08da786fee5c X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Aug 2022 12:25:36.1912 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 27e97857-e15f-486c-b58e-86c2b3040f93 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: oXCurXEEg8bkmFWmqOBO2z+M/rglwocn3pNbvHyloGSF1Gv7q0DGdwK+Ia8ZU4i/ X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR10MB1908 Content-Language: en-US Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Host Interface details are discribed by the SMBIOS Type 42 table. The table is published by the RedfishHostInterfaceDxe driver. That driver supports PCI-E and USB host interface types. The table is consumed by the RedfishGetHostInterfaceProtocolData function i= n the RedfishDiscoverDxe driver. That function only supports PCI-E interface. Cc: Abner Chang Cc: Nickle Wang Signed-off-by: Igor Kulchytskyy --- RedfishPkg/RedfishDiscoverDxe/RedfishSmbiosHostInterface.c | 11 ++++++++--= - 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/RedfishPkg/RedfishDiscoverDxe/RedfishSmbiosHostInterface.c b/R= edfishPkg/RedfishDiscoverDxe/RedfishSmbiosHostInterface.c index d79750b..a3b977f 100644 --- a/RedfishPkg/RedfishDiscoverDxe/RedfishSmbiosHostInterface.c +++ b/RedfishPkg/RedfishDiscoverDxe/RedfishSmbiosHostInterface.c @@ -65,10 +65,15 @@ RedfishGetHostInterfaceProtocolData ( RecordTmp =3D (UINT8 *)Record + Offset; // - // Check Device Type, only PCI/PCIe Network Interface v2 is suppor= ted now. + // Check Device Type, PCI/PCIe and USB Network Interface v2 is sup= ported. // - if (*RecordTmp =3D=3D REDFISH_HOST_INTERFACE_DEVICE_TYPE_PCI_PCIE_= V2) { - ASSERT (SpecificDataLen =3D=3D sizeof (PCI_OR_PCIE_INTERFACE_DEV= ICE_DESCRIPTOR_V2) + 1); + if ((*RecordTmp =3D=3D REDFISH_HOST_INTERFACE_DEVICE_TYPE_PCI_PCIE= _V2) || (*RecordTmp =3D=3D REDFISH_HOST_INTERFACE_DEVICE_TYPE_USB_V2)) { + if (*RecordTmp =3D=3D REDFISH_HOST_INTERFACE_DEVICE_TYPE_PCI_PCI= E_V2){ + ASSERT (SpecificDataLen =3D=3D sizeof (PCI_OR_PCIE_INTERFACE= _DEVICE_DESCRIPTOR_V2) + 1); + } + if (*RecordTmp =3D=3D REDFISH_HOST_INTERFACE_DEVICE_TYPE_USB_V2)= { + ASSERT (SpecificDataLen > sizeof (REDFISH_HOST_INTERFACE_DEV= ICE_TYPE_USB_V2) + 1); + } *DeviceDescriptor =3D (REDFISH_INTERFACE_DATA *)RecordTmp; Offset =3D Offset + SpecificDataLen; RecordTmp =3D (UINT8 *)Record + Offset; -- 2.6.1.windows.1 -The information contained in this message may be confidential and propriet= ary to American Megatrends (AMI). This communication is intended to be read= only by the individual or entity to whom it is addressed or by their desig= nee. If the reader of this message is not the intended recipient, you are o= n notice that any distribution of this message, in any form, is strictly pr= ohibited. Please promptly notify the sender by reply e-mail or by telephone= at 770-246-8600, and then delete or destroy all copies of the transmission= .