From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 20F3E21CA3593 for ; Thu, 22 Jun 2017 05:21:54 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7AD347F412; Thu, 22 Jun 2017 12:23:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 7AD347F412 Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=lersek@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 7AD347F412 Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-27.phx2.redhat.com [10.3.116.27]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3B1BA5C3FA; Thu, 22 Jun 2017 12:23:14 +0000 (UTC) To: Fu Siyuan , edk2-devel@lists.01.org Cc: Ye Ting , Wu Jiaxin , Gerd Hoffmann References: <20170620012307.9976-1-siyuan.fu@intel.com> From: Laszlo Ersek Message-ID: <16605b84-4fbe-2954-110a-a367c2fedb29@redhat.com> Date: Thu, 22 Jun 2017 14:23:13 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 In-Reply-To: <20170620012307.9976-1-siyuan.fu@intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Thu, 22 Jun 2017 12:23:18 +0000 (UTC) Subject: Re: [Patch V3] NetworkPkg/HttpBootDxe: Add HTTP Boot Callback protocol support. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Jun 2017 12:21:54 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Hi, On 06/20/17 03:23, Fu Siyuan wrote: > V3 update: > Fix X64 build error. > > V2 update: > Correct the file size print for IA32. > > This patch updates the HTTP Boot driver to install a default HTTP Callback protocol > if the platform doesn't provide one. This callback implementation will print the > boot file download progress in percentage format. This patch breaks the GCC build, because: > diff --git a/NetworkPkg/HttpBootDxe/HttpBootImpl.c b/NetworkPkg/HttpBootDxe/HttpBootImpl.c > index cf6de80..56f5bab 100644 > --- a/NetworkPkg/HttpBootDxe/HttpBootImpl.c > +++ b/NetworkPkg/HttpBootDxe/HttpBootImpl.c > +**/ > +EFI_STATUS > +HttpBootCallback ( > + IN EFI_HTTP_BOOT_CALLBACK_PROTOCOL *This, > + IN EFI_HTTP_BOOT_CALLBACK_DATA_TYPE DataType, > + IN BOOLEAN Received, > + IN UINT32 DataLength, > + IN VOID *Data OPTIONAL > + ) the EFIAPI calling convention wasn't specified here, but > +/// > +/// HTTP Boot Callback Protocol instance > +/// > +GLOBAL_REMOVE_IF_UNREFERENCED > +EFI_HTTP_BOOT_CALLBACK_PROTOCOL gHttpBootDxeHttpBootCallback = { > + HttpBootCallback > +}; it is required here, for the EFI_HTTP_BOOT_CALLBACK function pointer type. (Reported by Gerd's Jenkins CI.) Thanks, Laszlo