Re: Patch List for 201908 stable tag

Re: Patch List for 201908 stable tag

[Liming Gao]

[-- Attachment #1: Type: text/plain, Size: 1511 bytes --]


From: Gao, Liming [mailto:liming.gao@intel.com]
Sent: Friday, August 16, 2019 3:59 PM
To: Laszlo Ersek (lersek@redhat.com) <lersek@redhat.com>; leif.lindholm@linaro.org; Kinney, Michael D <michael.d.kinney@intel.com>; afish@apple.com; Cetola, Stephano <stephano.cetola@intel.com>
Cc: edk2-devel@lists.01.org
Subject: Patch List for 201908 stable tag

Hi Stewards and all:
  I collect current patch lists in devel mail list. Those patch contributors request to add them for 201908 stable tag. Because the time is very close to Soft Feature Freeze, I want to collect your feedback for below patches.

Feature List (those all have pass code review):
https://edk2.groups.io/g/devel/message/45734 [PATCH v6 0/5] Build cache enhancement
https://edk2.groups.io/g/devel/message/45707 [PATCH] UefiCpuPkg: Adding a new TSC library by using CPUID(0x15) TSC leaf
https://edk2.groups.io/g/devel/message/45503 [PATCH v2 1/1] MdePkg: Add STATIC_ASSERT macro

Bug List:
https://edk2.groups.io/g/devel/message/45794  [PATCH 1/1] CryptoPkg: Fix coding style
https://edk2.groups.io/g/devel/message/45791 [PATCH v2 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Replace shift logical left
https://edk2.groups.io/g/devel/message/45793 [Patch 1/1] BaseTools: Fixed issue of incorrect Module Unique Name
https://edk2.groups.io/g/devel/message/45773 [Patch v4 0/6] Add "test then write" mechanism
https://edk2.groups.io/g/devel/message/45317 [Patch] MdeModulePkg DxeCore: Fix for missing MAT update

Thanks
Liming

[-- Attachment #2: Type: text/html, Size: 4899 bytes --]

Re: Patch List for 201908 stable tag

[Laszlo Ersek]

On 08/16/19 10:00, Gao, Liming wrote:
> 
> From: Gao, Liming [mailto:liming.gao@intel.com]
> Sent: Friday, August 16, 2019 3:59 PM
> To: Laszlo Ersek (lersek@redhat.com) <lersek@redhat.com>; leif.lindholm@linaro.org; Kinney, Michael D <michael.d.kinney@intel.com>; afish@apple.com; Cetola, Stephano <stephano.cetola@intel.com>
> Cc: edk2-devel@lists.01.org
> Subject: Patch List for 201908 stable tag
> 
> Hi Stewards and all:
>   I collect current patch lists in devel mail list. Those patch contributors request to add them for 201908 stable tag. Because the time is very close to Soft Feature Freeze, I want to collect your feedback for below patches.
> 
> Feature List (those all have pass code review):
> https://edk2.groups.io/g/devel/message/45734 [PATCH v6 0/5] Build cache enhancement

Seems to be well documented (both in commit messages and in the BZ), and
the series was approved by a BaseTools maintainer [1] before the soft
feature freeze [2].

[1] https://edk2.groups.io/g/devel/message/45783
[2] https://edk2.groups.io/g/devel/message/45806

The series can be pushed during the soft feature freeze, according to
the current SFF definition.

Some requests regarding the bugzilla:

- Comment 0 in the bugzilla says "redesign the platform hash algorithm".
I feel that would be better reflected if we changed the Product field to
TianoCore Feature Requests.

- Please capture the v1..v6 cover letters, with mailing list archive
links, in the bugzilla.

> https://edk2.groups.io/g/devel/message/45707 [PATCH] UefiCpuPkg: Adding a new TSC library by using CPUID(0x15) TSC leaf

Accepted by a UefiCpuPkg maintainer [3] before the SFF [2].

[3] https://edk2.groups.io/g/devel/message/45787

Can be pushed during the soft feature freeze, according to the current
SFF definition.

According to my comments sent earlier today for this series, the
documentation and the bugzilla status are extremely lacking. I'm OK with
pushing the series, but those aspects should be fixed in the bugzilla.
Please see <https://edk2.groups.io/g/devel/message/45826>.

In addition, it appears multiple versions of the patch have been sent,
without using "vN" identifiers in the subject prefix. Please collect all
versions of the patch series from the mailing list archive, in
chronological order, and link them all into the bugzilla ticket.

> https://edk2.groups.io/g/devel/message/45503 [PATCH v2 1/1] MdePkg: Add STATIC_ASSERT macro

I commented on this today, as well:
<https://edk2.groups.io/g/devel/message/45827>

I disagree with the maintainer approval for this patch, from a reviewer
perspective. I think the submission isn't complete enough / mature
enough at this stage. The first version of the patch was posted on 12
Aug <https://edk2.groups.io/g/devel/message/45451>, as far as I can see.
Why are we in a mortal hurry to add a central macro without any call
sites in edk2 proper?

Anyway I'm not going to NACK the patch. If Mike is fine with the patch
as-is, I'll live with that, with my disagreement noted.

> Bug List:
> https://edk2.groups.io/g/devel/message/45794  [PATCH 1/1] CryptoPkg: Fix coding style

Purely from the subject line, looks like a bugfix, so no conflict with
the *soft* feature freeze.

> https://edk2.groups.io/g/devel/message/45791 [PATCH v2 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Replace shift logical left

Clearly a bugfix, so ditto.

> https://edk2.groups.io/g/devel/message/45793 [Patch 1/1] BaseTools: Fixed issue of incorrect Module Unique Name

Ditto.

> https://edk2.groups.io/g/devel/message/45773 [Patch v4 0/6] Add "test then write" mechanism

Sigh, this is a messy question.

To my eyes, this introduces a feature. The cover letter says "add ...
mechanism". Even though it is used to fix a bug, it still introduces a
new facility, in my opinion. So here I disagree with
<https://edk2.groups.io/g/devel/message/45590>.

For UefiCpuPkg, Ray and Eric are Maintainers, and I'm a reviewer. The
submitter is Eric, and Ray is away. Eric asked me to review
<https://edk2.groups.io/g/devel/message/45489>.

I reviewed v2. Then v3 was posted (not sure in response to what, as I
can't see any comments under v2 that requested the v3 changes). V3
received a bunch of comments, so v4 was posted quickly afterwards.

The posting of v4 was still in time for the SFF, but I only arrived at
it after the SFF. (And Ray is still away.) Technically speaking, in my
book, this series has missed the stable tag. But that's not the
submitter's fault, arguably.

On this, I am undecided. I will defer to the other stewards. If they are
fine with the series going in, I'm OK too.

> https://edk2.groups.io/g/devel/message/45317 [Patch] MdeModulePkg DxeCore: Fix for missing MAT update

This is a bugfix and therefore there is no conflict with the soft
feature freeze. Jian provided a maintainer R-b, and I asked for a
comment style cleanup and some documentation (commit message)
improvements. In addition, perhaps we should conditionalize the logic on
the gEfiMemoryTypeInformationGuid GUID HOB. (The discussion between
Liming and myself on where the HOB can come from is irrelevant in that
regard -- wherever the HOB comes from, it is suitable for checking in
the DXE core, I think.)

I think it's fine to submit a v2 and merge it during the soft feature
freeze (again, bugfix, so no conflict). I may not be around to review
v2, so don't wait for my feedback.

Thanks
Laszlo

Re: Patch List for 201908 stable tag

[Michael D Kinney]

> -----Original Message-----
> From: Laszlo Ersek [mailto:lersek@redhat.com]
> Sent: Friday, August 16, 2019 11:38 AM
> To: Gao, Liming <liming.gao@intel.com>;
> leif.lindholm@linaro.org; Kinney, Michael D
> <michael.d.kinney@intel.com>; afish@apple.com; Cetola,
> Stephano <stephano.cetola@intel.com>
> Cc: devel@edk2.groups.io; Shi, Steven
> <steven.shi@intel.com>; Kuo, Donald
> <donald.kuo@intel.com>; Vitaly Cheptsov
> <vit9696@protonmail.com>; Dong, Eric
> <eric.dong@intel.com>
> Subject: Re: Patch List for 201908 stable tag
> 
> On 08/16/19 10:00, Gao, Liming wrote:
> >
> > From: Gao, Liming [mailto:liming.gao@intel.com]
> > Sent: Friday, August 16, 2019 3:59 PM
> > To: Laszlo Ersek (lersek@redhat.com)
> <lersek@redhat.com>;
> > leif.lindholm@linaro.org; Kinney, Michael D
> > <michael.d.kinney@intel.com>; afish@apple.com; Cetola,
> Stephano
> > <stephano.cetola@intel.com>
> > Cc: edk2-devel@lists.01.org
> > Subject: Patch List for 201908 stable tag
> >
> > Hi Stewards and all:
> >   I collect current patch lists in devel mail list.
> Those patch contributors request to add them for 201908
> stable tag. Because the time is very close to Soft
> Feature Freeze, I want to collect your feedback for
> below patches.
> >
> > Feature List (those all have pass code review):
> > https://edk2.groups.io/g/devel/message/45734 [PATCH v6
> 0/5] Build
> > cache enhancement
> 
> Seems to be well documented (both in commit messages and
> in the BZ), and the series was approved by a BaseTools
> maintainer [1] before the soft feature freeze [2].
> 
> [1] https://edk2.groups.io/g/devel/message/45783
> [2] https://edk2.groups.io/g/devel/message/45806
> 
> The series can be pushed during the soft feature freeze,
> according to the current SFF definition.
> 
> Some requests regarding the bugzilla:
> 
> - Comment 0 in the bugzilla says "redesign the platform
> hash algorithm".
> I feel that would be better reflected if we changed the
> Product field to TianoCore Feature Requests.
> 
> - Please capture the v1..v6 cover letters, with mailing
> list archive links, in the bugzilla.
> 
> > https://edk2.groups.io/g/devel/message/45707 [PATCH]
> UefiCpuPkg:
> > Adding a new TSC library by using CPUID(0x15) TSC leaf
> 
> Accepted by a UefiCpuPkg maintainer [3] before the SFF
> [2].
> 
> [3] https://edk2.groups.io/g/devel/message/45787
> 
> Can be pushed during the soft feature freeze, according
> to the current SFF definition.
> 
> According to my comments sent earlier today for this
> series, the documentation and the bugzilla status are
> extremely lacking. I'm OK with pushing the series, but
> those aspects should be fixed in the bugzilla.
> Please see
> <https://edk2.groups.io/g/devel/message/45826>.
> 
> In addition, it appears multiple versions of the patch
> have been sent, without using "vN" identifiers in the
> subject prefix. Please collect all versions of the patch
> series from the mailing list archive, in chronological
> order, and link them all into the bugzilla ticket.
> 
> > https://edk2.groups.io/g/devel/message/45503 [PATCH v2
> 1/1] MdePkg:
> > Add STATIC_ASSERT macro
> 
> I commented on this today, as well:
> <https://edk2.groups.io/g/devel/message/45827>
> 
> I disagree with the maintainer approval for this patch,
> from a reviewer perspective. I think the submission
> isn't complete enough / mature enough at this stage. The
> first version of the patch was posted on 12 Aug
> <https://edk2.groups.io/g/devel/message/45451>, as far
> as I can see.
> Why are we in a mortal hurry to add a central macro
> without any call sites in edk2 proper?
> 
> Anyway I'm not going to NACK the patch. If Mike is fine
> with the patch as-is, I'll live with that, with my
> disagreement noted.

I see there is another version sent out on Friday that includes
the usage.  We do need to make sure all the compiler we use
are compatible with this macro.  The one that may be a challenge
is EBC.

I think this is a valuable new feature, but I have not see 
The critical reason why this has to go in for the 201908
stable tag.  I would rather see it as one of the first 
item after the stable tag so it can get lots of flight 
time.

> 
> > Bug List:
> > https://edk2.groups.io/g/devel/message/45794  [PATCH
> 1/1] CryptoPkg:
> > Fix coding style
> 
> Purely from the subject line, looks like a bugfix, so no
> conflict with the *soft* feature freeze.

I agree.  Bug fix for 201908 stable tag.

> 
> > https://edk2.groups.io/g/devel/message/45791 [PATCH v2
> 1/1]
> > ShellPkg/UefiShellAcpiViewCommandLib: Replace shift
> logical left
> 
> Clearly a bugfix, so ditto.

I agree.  Bug fix for 201908 stable tag.

> 
> > https://edk2.groups.io/g/devel/message/45793 [Patch
> 1/1] BaseTools:
> > Fixed issue of incorrect Module Unique Name
> 
> Ditto.

I agree.  Bug fix for 201908 stable tag.

> 
> > https://edk2.groups.io/g/devel/message/45773 [Patch v4
> 0/6] Add "test
> > then write" mechanism
> 
> Sigh, this is a messy question.
> 
> To my eyes, this introduces a feature. The cover letter
> says "add ...
> mechanism". Even though it is used to fix a bug, it
> still introduces a new facility, in my opinion. So here
> I disagree with
> <https://edk2.groups.io/g/devel/message/45590>.
> 
> For UefiCpuPkg, Ray and Eric are Maintainers, and I'm a
> reviewer. The submitter is Eric, and Ray is away. Eric
> asked me to review
> <https://edk2.groups.io/g/devel/message/45489>.
> 
> I reviewed v2. Then v3 was posted (not sure in response
> to what, as I can't see any comments under v2 that
> requested the v3 changes). V3 received a bunch of
> comments, so v4 was posted quickly afterwards.
> 
> The posting of v4 was still in time for the SFF, but I
> only arrived at it after the SFF. (And Ray is still
> away.) Technically speaking, in my book, this series has
> missed the stable tag. But that's not the submitter's
> fault, arguably.
> 
> On this, I am undecided. I will defer to the other
> stewards. If they are fine with the series going in, I'm
> OK too.

Ray is back online has have provided his review.
I am fine with this going in.  I want to see this bug fixed.
In the 201908 stable tag.

> 
> > https://edk2.groups.io/g/devel/message/45317 [Patch]
> MdeModulePkg
> > DxeCore: Fix for missing MAT update
> 
> This is a bugfix and therefore there is no conflict with
> the soft feature freeze. Jian provided a maintainer R-b,
> and I asked for a comment style cleanup and some
> documentation (commit message) improvements. In
> addition, perhaps we should conditionalize the logic on
> the gEfiMemoryTypeInformationGuid GUID HOB. (The
> discussion between Liming and myself on where the HOB
> can come from is irrelevant in that regard -- wherever
> the HOB comes from, it is suitable for checking in the
> DXE core, I think.)
> 
> I think it's fine to submit a v2 and merge it during the
> soft feature freeze (again, bugfix, so no conflict). I
> may not be around to review v2, so don't wait for my
> feedback.

I agree that this is a bug fix and should be included in
the 201908 stable tag.

> 
> Thanks
> Laszlo

Re: Patch List for 201908 stable tag

[Michael D Kinney]

[-- Attachment #1: Type: text/plain, Size: 2599 bytes --]

Liming,

I would like to include the following bug fixes to EmulatorPkg in the stable tag:

https://edk2.groups.io/g/devel/message/45953  [edk2-devel] [Patch V5 00/11] EmulatorPkg: Fix VS20xx IA32 boot and simplify build config

The first set of patches were sent for review on 8/1.  Most of the EmulatorPkg combinations cannot build or boot without these fixes.  I am waiting for final reviews from the maintainers Ray and Jordan and approval from stewards before pushing this series.

Thanks,

Mike

From: Gao, Liming
Sent: Friday, August 16, 2019 1:01 AM
To: Gao, Liming <liming.gao@intel.com>; Laszlo Ersek (lersek@redhat.com) <lersek@redhat.com>; leif.lindholm@linaro.org; Kinney, Michael D <michael.d.kinney@intel.com>; afish@apple.com; Cetola, Stephano <stephano.cetola@intel.com>
Cc: devel@edk2.groups.io
Subject: RE: Patch List for 201908 stable tag


From: Gao, Liming [mailto:liming.gao@intel.com]
Sent: Friday, August 16, 2019 3:59 PM
To: Laszlo Ersek (lersek@redhat.com<mailto:lersek@redhat.com>) <lersek@redhat.com<mailto:lersek@redhat.com>>; leif.lindholm@linaro.org<mailto:leif.lindholm@linaro.org>; Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>; afish@apple.com<mailto:afish@apple.com>; Cetola, Stephano <stephano.cetola@intel.com<mailto:stephano.cetola@intel.com>>
Cc: edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org>
Subject: Patch List for 201908 stable tag

Hi Stewards and all:
  I collect current patch lists in devel mail list. Those patch contributors request to add them for 201908 stable tag. Because the time is very close to Soft Feature Freeze, I want to collect your feedback for below patches.

Feature List (those all have pass code review):
https://edk2.groups.io/g/devel/message/45734 [PATCH v6 0/5] Build cache enhancement
https://edk2.groups.io/g/devel/message/45707 [PATCH] UefiCpuPkg: Adding a new TSC library by using CPUID(0x15) TSC leaf
https://edk2.groups.io/g/devel/message/45503 [PATCH v2 1/1] MdePkg: Add STATIC_ASSERT macro

Bug List:
https://edk2.groups.io/g/devel/message/45794  [PATCH 1/1] CryptoPkg: Fix coding style
https://edk2.groups.io/g/devel/message/45791 [PATCH v2 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Replace shift logical left
https://edk2.groups.io/g/devel/message/45793 [Patch 1/1] BaseTools: Fixed issue of incorrect Module Unique Name
https://edk2.groups.io/g/devel/message/45773 [Patch v4 0/6] Add "test then write" mechanism
https://edk2.groups.io/g/devel/message/45317 [Patch] MdeModulePkg DxeCore: Fix for missing MAT update

Thanks
Liming

[-- Attachment #2: Type: text/html, Size: 44097 bytes --]

Re: [edk2-devel] Patch List for 201908 stable tag

[Ni, Ray]

[-- Attachment #1: Type: text/plain, Size: 251 bytes --]

Liming,
Below patch already got the reviewed-by tag before the freezing point. Can I push it now?

https://edk2.groups.io/g/devel/topic/32737146 UefiCpuPkg/PiSmmCpuDxeSmm: don't free page table pages that are required to handle current page fault

[-- Attachment #2: Type: text/html, Size: 341 bytes --]

Re: [edk2-devel] Patch List for 201908 stable tag

[Liming Gao]

[-- Attachment #1: Type: text/plain, Size: 576 bytes --]

Ray:
  It follows current soft feature freeze process. I am OK to fix it for this stable tag.

Thanks
Liming
From: Ni, Ray [mailto:ray.ni@intel.com]
Sent: Tuesday, August 20, 2019 2:05 AM
To: Gao; Gao, Liming <liming.gao@intel.com>; devel@edk2.groups.io
Subject: Re: [edk2-devel] Patch List for 201908 stable tag


Liming, Below patch already got the reviewed-by tag before the freezing point. Can I push it now?

https://edk2.groups.io/g/devel/topic/32737146 UefiCpuPkg/PiSmmCpuDxeSmm: don't free page table pages that are required to handle current page fault

[-- Attachment #2: Type: text/html, Size: 3969 bytes --]

Re: [edk2-devel] Patch List for 201908 stable tag

[Ni, Ray]

[-- Attachment #1: Type: text/plain, Size: 885 bytes --]

Liming,
Thanks for the confirmation. It has been pushed.

Thanks,
Ray

From: Gao, Liming
Sent: Monday, August 19, 2019 5:48 PM
To: Ni, Ray <ray.ni@intel.com>; devel@edk2.groups.io
Subject: RE: [edk2-devel] Patch List for 201908 stable tag

Ray:
  It follows current soft feature freeze process. I am OK to fix it for this stable tag.

Thanks
Liming
From: Ni, Ray [mailto:ray.ni@intel.com]
Sent: Tuesday, August 20, 2019 2:05 AM
To: Gao; Gao, Liming <liming.gao@intel.com<mailto:liming.gao@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>
Subject: Re: [edk2-devel] Patch List for 201908 stable tag


Liming, Below patch already got the reviewed-by tag before the freezing point. Can I push it now?

https://edk2.groups.io/g/devel/topic/32737146 UefiCpuPkg/PiSmmCpuDxeSmm: don't free page table pages that are required to handle current page fault

[-- Attachment #2: Type: text/html, Size: 5496 bytes --]

Re: [edk2-devel] Patch List for 201908 stable tag

[Ni, Ray]

[-- Attachment #1: Type: text/plain, Size: 2610 bytes --]

All stewards,
Though it was already listed by Liming, I would like explicitly ask for including below changes in the coming stable tag:
https://edk2.groups.io/g/devel/message/45773 [Patch v4 0/6] Add "test then write" mechanism

The whole patches had gone through 4 rounds of review process while I was away.
I had a deep look at the whole changes and all look very good. (except a minor copyright year issue in the 6/6 patch.)


Thanks,
Ray

From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Liming Gao
Sent: Friday, August 16, 2019 1:01 AM
To: Gao, Liming <liming.gao@intel.com>; Laszlo Ersek (lersek@redhat.com) <lersek@redhat.com>; leif.lindholm@linaro.org; Kinney, Michael D <michael.d.kinney@intel.com>; afish@apple.com; Cetola, Stephano <stephano.cetola@intel.com>
Cc: devel@edk2.groups.io
Subject: Re: [edk2-devel] Patch List for 201908 stable tag


From: Gao, Liming [mailto:liming.gao@intel.com]
Sent: Friday, August 16, 2019 3:59 PM
To: Laszlo Ersek (lersek@redhat.com<mailto:lersek@redhat.com>) <lersek@redhat.com<mailto:lersek@redhat.com>>; leif.lindholm@linaro.org<mailto:leif.lindholm@linaro.org>; Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>; afish@apple.com<mailto:afish@apple.com>; Cetola, Stephano <stephano.cetola@intel.com<mailto:stephano.cetola@intel.com>>
Cc: edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org>
Subject: Patch List for 201908 stable tag

Hi Stewards and all:
  I collect current patch lists in devel mail list. Those patch contributors request to add them for 201908 stable tag. Because the time is very close to Soft Feature Freeze, I want to collect your feedback for below patches.

Feature List (those all have pass code review):
https://edk2.groups.io/g/devel/message/45734 [PATCH v6 0/5] Build cache enhancement
https://edk2.groups.io/g/devel/message/45707 [PATCH] UefiCpuPkg: Adding a new TSC library by using CPUID(0x15) TSC leaf
https://edk2.groups.io/g/devel/message/45503 [PATCH v2 1/1] MdePkg: Add STATIC_ASSERT macro

Bug List:
https://edk2.groups.io/g/devel/message/45794  [PATCH 1/1] CryptoPkg: Fix coding style
https://edk2.groups.io/g/devel/message/45791 [PATCH v2 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Replace shift logical left
https://edk2.groups.io/g/devel/message/45793 [Patch 1/1] BaseTools: Fixed issue of incorrect Module Unique Name
https://edk2.groups.io/g/devel/message/45773 [Patch v4 0/6] Add "test then write" mechanism
https://edk2.groups.io/g/devel/message/45317 [Patch] MdeModulePkg DxeCore: Fix for missing MAT update

Thanks
Liming


[-- Attachment #2: Type: text/html, Size: 7633 bytes --]

Re: [edk2-devel] Patch List for 201908 stable tag

[Michael D Kinney]

[-- Attachment #1: Type: text/plain, Size: 3326 bytes --]

Ray,

With your review, my vote is yes.

Mike

From: Ni, Ray
Sent: Monday, August 19, 2019 4:06 PM
To: devel@edk2.groups.io; Gao, Liming <liming.gao@intel.com>; Laszlo Ersek (lersek@redhat.com) <lersek@redhat.com>; leif.lindholm@linaro.org; Kinney, Michael D <michael.d.kinney@intel.com>; afish@apple.com; Cetola, Stephano <stephano.cetola@intel.com>
Subject: RE: [edk2-devel] Patch List for 201908 stable tag

All stewards,
Though it was already listed by Liming, I would like explicitly ask for including below changes in the coming stable tag:
https://edk2.groups.io/g/devel/message/45773 [Patch v4 0/6] Add "test then write" mechanism

The whole patches had gone through 4 rounds of review process while I was away.
I had a deep look at the whole changes and all look very good. (except a minor copyright year issue in the 6/6 patch.)


Thanks,
Ray

From: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> On Behalf Of Liming Gao
Sent: Friday, August 16, 2019 1:01 AM
To: Gao, Liming <liming.gao@intel.com<mailto:liming.gao@intel.com>>; Laszlo Ersek (lersek@redhat.com<mailto:lersek@redhat.com>) <lersek@redhat.com<mailto:lersek@redhat.com>>; leif.lindholm@linaro.org<mailto:leif.lindholm@linaro.org>; Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>; afish@apple.com<mailto:afish@apple.com>; Cetola, Stephano <stephano.cetola@intel.com<mailto:stephano.cetola@intel.com>>
Cc: devel@edk2.groups.io<mailto:devel@edk2.groups.io>
Subject: Re: [edk2-devel] Patch List for 201908 stable tag


From: Gao, Liming [mailto:liming.gao@intel.com]
Sent: Friday, August 16, 2019 3:59 PM
To: Laszlo Ersek (lersek@redhat.com<mailto:lersek@redhat.com>) <lersek@redhat.com<mailto:lersek@redhat.com>>; leif.lindholm@linaro.org<mailto:leif.lindholm@linaro.org>; Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>; afish@apple.com<mailto:afish@apple.com>; Cetola, Stephano <stephano.cetola@intel.com<mailto:stephano.cetola@intel.com>>
Cc: edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org>
Subject: Patch List for 201908 stable tag

Hi Stewards and all:
  I collect current patch lists in devel mail list. Those patch contributors request to add them for 201908 stable tag. Because the time is very close to Soft Feature Freeze, I want to collect your feedback for below patches.

Feature List (those all have pass code review):
https://edk2.groups.io/g/devel/message/45734 [PATCH v6 0/5] Build cache enhancement
https://edk2.groups.io/g/devel/message/45707 [PATCH] UefiCpuPkg: Adding a new TSC library by using CPUID(0x15) TSC leaf
https://edk2.groups.io/g/devel/message/45503 [PATCH v2 1/1] MdePkg: Add STATIC_ASSERT macro

Bug List:
https://edk2.groups.io/g/devel/message/45794  [PATCH 1/1] CryptoPkg: Fix coding style
https://edk2.groups.io/g/devel/message/45791 [PATCH v2 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Replace shift logical left
https://edk2.groups.io/g/devel/message/45793 [Patch 1/1] BaseTools: Fixed issue of incorrect Module Unique Name
https://edk2.groups.io/g/devel/message/45773 [Patch v4 0/6] Add "test then write" mechanism
https://edk2.groups.io/g/devel/message/45317 [Patch] MdeModulePkg DxeCore: Fix for missing MAT update

Thanks
Liming


[-- Attachment #2: Type: text/html, Size: 45972 bytes --]

Re: [edk2-devel] Patch List for 201908 stable tag

[Ni, Ray]

[-- Attachment #1: Type: text/plain, Size: 4074 bytes --]

Leif, Andrew,
Better if a "yes" could be from one of you so that makes 3 "yes" of 4.

Thanks,
Ray

From: Kinney, Michael D
Sent: Monday, August 19, 2019 4:30 PM
To: Ni, Ray <ray.ni@intel.com>; devel@edk2.groups.io; Gao, Liming <liming.gao@intel.com>; Laszlo Ersek (lersek@redhat.com) <lersek@redhat.com>; leif.lindholm@linaro.org; afish@apple.com; Cetola, Stephano <stephano.cetola@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>
Subject: RE: [edk2-devel] Patch List for 201908 stable tag

Ray,

With your review, my vote is yes.

Mike

From: Ni, Ray
Sent: Monday, August 19, 2019 4:06 PM
To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Gao, Liming <liming.gao@intel.com<mailto:liming.gao@intel.com>>; Laszlo Ersek (lersek@redhat.com<mailto:lersek@redhat.com>) <lersek@redhat.com<mailto:lersek@redhat.com>>; leif.lindholm@linaro.org<mailto:leif.lindholm@linaro.org>; Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>; afish@apple.com<mailto:afish@apple.com>; Cetola, Stephano <stephano.cetola@intel.com<mailto:stephano.cetola@intel.com>>
Subject: RE: [edk2-devel] Patch List for 201908 stable tag

All stewards,
Though it was already listed by Liming, I would like explicitly ask for including below changes in the coming stable tag:
https://edk2.groups.io/g/devel/message/45773 [Patch v4 0/6] Add "test then write" mechanism

The whole patches had gone through 4 rounds of review process while I was away.
I had a deep look at the whole changes and all look very good. (except a minor copyright year issue in the 6/6 patch.)


Thanks,
Ray

From: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> On Behalf Of Liming Gao
Sent: Friday, August 16, 2019 1:01 AM
To: Gao, Liming <liming.gao@intel.com<mailto:liming.gao@intel.com>>; Laszlo Ersek (lersek@redhat.com<mailto:lersek@redhat.com>) <lersek@redhat.com<mailto:lersek@redhat.com>>; leif.lindholm@linaro.org<mailto:leif.lindholm@linaro.org>; Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>; afish@apple.com<mailto:afish@apple.com>; Cetola, Stephano <stephano.cetola@intel.com<mailto:stephano.cetola@intel.com>>
Cc: devel@edk2.groups.io<mailto:devel@edk2.groups.io>
Subject: Re: [edk2-devel] Patch List for 201908 stable tag


From: Gao, Liming [mailto:liming.gao@intel.com]
Sent: Friday, August 16, 2019 3:59 PM
To: Laszlo Ersek (lersek@redhat.com<mailto:lersek@redhat.com>) <lersek@redhat.com<mailto:lersek@redhat.com>>; leif.lindholm@linaro.org<mailto:leif.lindholm@linaro.org>; Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>; afish@apple.com<mailto:afish@apple.com>; Cetola, Stephano <stephano.cetola@intel.com<mailto:stephano.cetola@intel.com>>
Cc: edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org>
Subject: Patch List for 201908 stable tag

Hi Stewards and all:
  I collect current patch lists in devel mail list. Those patch contributors request to add them for 201908 stable tag. Because the time is very close to Soft Feature Freeze, I want to collect your feedback for below patches.

Feature List (those all have pass code review):
https://edk2.groups.io/g/devel/message/45734 [PATCH v6 0/5] Build cache enhancement
https://edk2.groups.io/g/devel/message/45707 [PATCH] UefiCpuPkg: Adding a new TSC library by using CPUID(0x15) TSC leaf
https://edk2.groups.io/g/devel/message/45503 [PATCH v2 1/1] MdePkg: Add STATIC_ASSERT macro

Bug List:
https://edk2.groups.io/g/devel/message/45794  [PATCH 1/1] CryptoPkg: Fix coding style
https://edk2.groups.io/g/devel/message/45791 [PATCH v2 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Replace shift logical left
https://edk2.groups.io/g/devel/message/45793 [Patch 1/1] BaseTools: Fixed issue of incorrect Module Unique Name
https://edk2.groups.io/g/devel/message/45773 [Patch v4 0/6] Add "test then write" mechanism
https://edk2.groups.io/g/devel/message/45317 [Patch] MdeModulePkg DxeCore: Fix for missing MAT update

Thanks
Liming


[-- Attachment #2: Type: text/html, Size: 10948 bytes --]

Re: [edk2-devel] Patch List for 201908 stable tag

[Andrew Fish]

[-- Attachment #1: Type: text/plain, Size: 167 bytes --]

My vote is Yes.

Thanks,

Andrew Fish

> On Aug 20, 2019, at 10:02 AM, Ni, Ray <ray.ni@intel.com> wrote:
> 
> Ray,
>  
> With your review, my vote is yes.
>  
> Mike


[-- Attachment #2: Type: text/html, Size: 2933 bytes --]

Re: [edk2-devel] Patch List for 201908 stable tag

[Ni, Ray]

[-- Attachment #1: Type: text/plain, Size: 696 bytes --]

Andrew, Mike,
Thank you. The "test and write" patches have been pushed.

Thanks,
Ray

From: afish@apple.com <afish@apple.com>
Sent: Tuesday, August 20, 2019 10:53 AM
To: Ni, Ray <ray.ni@intel.com>
Cc: Kinney, Michael D <michael.d.kinney@intel.com>; devel@edk2.groups.io; Gao, Liming <liming.gao@intel.com>; Laszlo Ersek (lersek@redhat.com) <lersek@redhat.com>; leif.lindholm@linaro.org; Cetola, Stephano <stephano.cetola@intel.com>
Subject: Re: [edk2-devel] Patch List for 201908 stable tag

My vote is Yes.

Thanks,

Andrew Fish


On Aug 20, 2019, at 10:02 AM, Ni, Ray <ray.ni@intel.com<mailto:ray.ni@intel.com>> wrote:

Ray,

With your review, my vote is yes.

Mike


[-- Attachment #2: Type: text/html, Size: 4285 bytes --]