From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com)
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by groups.io with SMTP; Wed, 03 Jul 2019 03:08:58 -0700
Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mx1.redhat.com (Postfix) with ESMTPS id 2561C308424C;
	Wed,  3 Jul 2019 10:08:50 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-169.phx2.redhat.com [10.3.116.169])
	by smtp.corp.redhat.com (Postfix) with ESMTP id D51A27AB68;
	Wed,  3 Jul 2019 10:08:46 +0000 (UTC)
Subject: Re: [edk2-devel] [PATCH 3/3] UefiCpuPkg/PiSmmCpu: Enable 5 level paging when CPU supports
From: "Laszlo Ersek" <lersek@redhat.com>
To: devel@edk2.groups.io, ray.ni@intel.com
Cc: "Dong, Eric" <eric.dong@intel.com>
Reply-To: devel@edk2.groups.io, lersek@redhat.com
References: <20190628064700.549472-1-ray.ni@intel.com>
 <20190628064700.549472-4-ray.ni@intel.com>
 <bb9878cc-862e-857d-0292-342285ab06c3@redhat.com>
 <734D49CCEBEEF84792F5B80ED585239D5C211134@SHSMSX104.ccr.corp.intel.com>
 <1a147a74-9986-1287-5334-5876eebe7682@redhat.com>
 <3c51b8a8-7517-6377-51c8-9e33c0c2af2d@redhat.com>
Message-ID: <1663d2c7-6761-400c-c662-d533ee7c1a09@redhat.com>
Date: Wed, 3 Jul 2019 12:08:45 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <3c51b8a8-7517-6377-51c8-9e33c0c2af2d@redhat.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.40]); Wed, 03 Jul 2019 10:08:50 +0000 (UTC)
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

Hi Ray,

On 07/02/19 17:20, Laszlo Ersek wrote:
> On 07/02/19 17:18, Laszlo Ersek wrote:
>> On 07/02/19 16:44, Ni, Ray wrote:
>>> Laszlo,
>>> I agree with your changes.
>>> Will include your changes in V2.
>>
>> Thanks, Ray -- currently waiting for suitable hardware (with 5-level
>> paging support) to become available internally @RH for my testing.

I hoped to provision a suitable server (with 5lvl paging) internally @RH
for testing -- not just regression-testing -- your series, *quickly*.
Unfortunately, my attempt at that has failed. So I can't provide that
kind of test result now, and I don't want to block your work
indefinitely. Please proceed with this series as necessary.

(Do pick up my R-t-b from below please, after you incorporate the
PatchInstructionX86() change.)

Thanks!
Laszlo


>> On host hardware that does not support 5-level paging, there seem to be
>> no adverse effects.
>>
>> Regression-tested-by: Laszlo Ersek <lersek@redhat.com>
> 
> Forgot to mention that this applies with the PatchInstructionX86()
> update in place.
> 
> Thanks
> Laszlo
> 
> 
>