public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Zenith432 <zenith432@users.sourceforge.net>
To: <edk2-devel@lists.01.org>
Cc: <michael.d.kinney@intel.com>,  <liming.gao@intel.com>
Subject: [PATCH] MdePkg: correct and clarify documentation of VA_LIST in Base.h
Date: Sun, 10 Dec 2017 09:32:26 +0000 (UTC)	[thread overview]
Message-ID: <1667068483.2112668.1512898346914@mail.yahoo.com> (raw)
In-Reply-To: 1667068483.2112668.1512898346914.ref@mail.yahoo.com

This is to resolve bug 457.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Zenith432 <zenith432 at users.sourceforge.net>
---
 MdePkg/Include/Base.h | 24 ++++++++++++++++++++----
 1 file changed, 20 insertions(+), 4 deletions(-)

diff --git a/MdePkg/Include/Base.h b/MdePkg/Include/Base.h
index 02140a5a..19f36872 100644
--- a/MdePkg/Include/Base.h
+++ b/MdePkg/Include/Base.h
@@ -560,13 +560,14 @@ struct _LIST_ENTRY {
 //  VA_LIST  - typedef for argument list.
 //  VA_START (VA_LIST Marker, argument before the ...) - Init Marker for use.
 //  VA_END (VA_LIST Marker) - Clear Marker
-//  VA_ARG (VA_LIST Marker, var arg size) - Use Marker to get an argument from
-//    the ... list. You must know the size and pass it in this macro.
+//  VA_ARG (VA_LIST Marker, var arg type) - Use Marker to get an argument from
+//    the ... list. You must know the type and pass it in this macro.
 //  VA_COPY (VA_LIST Dest, VA_LIST Start) - Initialize Dest as a copy of Start.
 //
-//  example:
+//  Example:
 //
 //  UINTN
+//  EFIAPI
 //  ExampleVarArg (
 //    IN UINTN  NumberOfArgs,
 //    ...
@@ -582,7 +583,7 @@ struct _LIST_ENTRY {
 //    VA_START (Marker, NumberOfArgs);
 //    for (Index = 0, Result = 0; Index < NumberOfArgs; Index++) {
 //      //
-//      // The ... list is a series of UINTN values, so average them up.
+//      // The ... list is a series of UINTN values, so sum them up.
 //      //
 //      Result += VA_ARG (Marker, UINTN);
 //    }
@@ -591,6 +592,21 @@ struct _LIST_ENTRY {
 //    return Result
 //  }
 //
+//  Notes:
+//
+//  This set of macros is intended to support variadic functions that
+//  use the EFIAPI calling convention.  Variadic functions that use a
+//  native calling convention should use stdarg.h.
+//  In particular:
+//  -- VA_START may only be used in a variadic EFIAPI function.
+//  -- va_start may only be used in a variadic native function.
+//  -- VA_START, VA_END, VA_ARG and VA_COPY may only be used on a VA_LIST.
+//  -- va_start, va_end, va_arg and va_copy may only be used on a va_list.
+//  -- Both VA_LIST or va_list may be passed as arguments to functions
+//     of either EFIAPI or native calling conventions.
+//  -- VA_END, VA_ARG, VA_COPY, va_end, va_arg, and va_copy may be used
+//     in functions of either calling conventions.
+//
 
 /**
   Return the size of argument that has been aligned to sizeof (UINTN).
-- 
2.14.3


       reply	other threads:[~2017-12-10  9:27 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1667068483.2112668.1512898346914.ref@mail.yahoo.com>
2017-12-10  9:32 ` Zenith432 [this message]
2017-12-10 13:53   ` [PATCH] MdePkg: correct and clarify documentation of VA_LIST in Base.h Gao, Liming
2017-12-10 15:43     ` Zenith432
2017-12-11 14:35       ` Gao, Liming
2017-12-11 14:57         ` Zenith432
2017-12-12  1:32           ` Gao, Liming
2017-12-12  8:36             ` Laszlo Ersek
2017-12-12  9:16   ` Laszlo Ersek
2017-12-12 10:24     ` Zenith432
2017-12-12 10:39       ` Laszlo Ersek
2017-12-12 15:01         ` Gao, Liming
2017-12-12 17:42           ` Laszlo Ersek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1667068483.2112668.1512898346914@mail.yahoo.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox