public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Prabin CA" <prabin.ca@arm.com>
To: Prabin CA <prabin.ca@arm.com>,devel@edk2.groups.io
Subject: Re: [edk2-devel] [edk2-platforms][PATCH v4 8/8] Platform/Sgi: Add CPPC support for RD-Fremont platform
Date: Mon, 11 Mar 2024 06:16:14 -0700	[thread overview]
Message-ID: <16720.1710162973978029263@groups.io> (raw)
In-Reply-To: <20240301163231.2889922-9-prabin.ca@arm.com>

[-- Attachment #1: Type: text/plain, Size: 1857 bytes --]

Hi Levi,
Thank you for taking the time to review these patches and providing corrections.

For RD platforms, We don't have any performance limited register. During CPPC testing with Linux as the OS, we've observed that Linux utilizes only the performance set level channel and does not utilize the performance limit set channels. Even when we attempt to set the performance limit from Linux sysfs, the kernel handles this internally without forwarding any limit set requests to the platform firmware. Consequently, as these registers are optional, we are not using these channels. Looking ahead to potential future implementations, it's anticipated that the performance limited register will come into play. That's why we've included the performance limited register. if you have any suggestions, please do share.

The decision to use the fast channel address was influenced by potentially misleading information found in the FFH specification v1.2, under chapter 'B.2.2 Performance Controls', where the performance limited register address was indicated as the next address after the 'Desired Performance Register'. We've now updated the _CPC object with a value address of 0 for the performance limited register (we will make the similar changes for older platforms as well and post as a new series). Please do let us know if you have any suggestions on using any specific register for the performance limited register. Your input would be greatly appreciated.

Thanks,
Prabin CA


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116623): https://edk2.groups.io/g/devel/message/116623
Mute This Topic: https://groups.io/mt/104668523/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Type: text/html, Size: 2392 bytes --]

  parent reply	other threads:[~2024-03-11 13:16 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-01 16:32 [edk2-devel] [edk2-platforms][PATCH v4 0/8] Platform/Sgi: Add support for RD-Fremont platform Prabin CA
2024-03-01 16:32 ` [edk2-devel] [edk2-platforms][PATCH v4 1/8] Platform/Sgi: Update the datatype of PcdSmmuBase from u32 to u64 Prabin CA
2024-03-08 13:05   ` levi.yun
2024-03-01 16:32 ` [edk2-devel] [edk2-platforms][PATCH v4 2/8] Platform/Sgi: Refactor system memory base and size definitions Prabin CA
2024-03-08 13:05   ` levi.yun
2024-03-01 16:32 ` [edk2-devel] [edk2-platforms][PATCH v4 3/8] Platform/Sgi: Introduce a flag to enable PCIe support for RD Platforms Prabin CA
2024-03-08 13:05   ` levi.yun
2024-03-01 16:32 ` [edk2-devel] [edk2-platforms][PATCH v4 4/8] Platform/Sgi: Add ACPI tables for RD-Fremont platform Prabin CA
2024-03-08 13:04   ` levi.yun
2024-03-11 13:15     ` Prabin CA
2024-03-01 16:32 ` [edk2-devel] [edk2-platforms][PATCH v4 5/8] Platform/Sgi: Add initial support " Prabin CA
2024-03-08 13:05   ` levi.yun
2024-03-01 16:32 ` [edk2-devel] [edk2-platforms][PATCH v4 6/8] Platform/Sgi: Extend SMBIOS support for RD-Fremont Prabin CA
2024-03-08 13:05   ` levi.yun
2024-03-01 16:32 ` [edk2-devel] [edk2-platforms][PATCH v4 7/8] Platform/Sgi: Low Power Idle States " Prabin CA
2024-03-08 13:05   ` levi.yun
2024-03-01 16:32 ` [edk2-devel] [edk2-platforms][PATCH v4 8/8] Platform/Sgi: Add CPPC support for RD-Fremont platform Prabin CA
2024-03-08 13:16   ` levi.yun
2024-03-11 13:16   ` Prabin CA [this message]
2024-03-04 10:59 ` [edk2-devel] [edk2-platforms][PATCH v4 0/8] Platform/Sgi: Add " Thomas Abraham

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=16720.1710162973978029263@groups.io \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox