From: "Sami Mujawar" <sami.mujawar@arm.com>
To: PierreGondois <pierre.gondois@arm.com>,devel@edk2.groups.io
Subject: Re: [edk2-devel] [PATCH v5 8/9] SecurityPkg/RngDxe: Use GetRngGuid() when probing RngLib
Date: Sun, 06 Aug 2023 22:16:49 -0700 [thread overview]
Message-ID: <16750.1691385409155473599@groups.io> (raw)
In-Reply-To: <20230718115156.1224842-9-pierre.gondois@arm.com>
[-- Attachment #1: Type: text/plain, Size: 783 bytes --]
Hi Pierre,
Thank you for this patch.
On Tue, Jul 18, 2023 at 04:52 AM, PierreGondois wrote:
>
> + gEfiRngAlgorithmArmRndr ## SOMETIMES_PRODUCES ## GUID =
> # Unique ID of the algorithm for RNG
Can you check if the line above should be part of this patch, please?
Otherwise, this patch looks good to me.
In either case,
Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107609): https://edk2.groups.io/g/devel/message/107609
Mute This Topic: https://groups.io/mt/100213737/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
[-- Attachment #2: Type: text/html, Size: 1273 bytes --]
next prev parent reply other threads:[~2023-08-07 5:16 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-18 11:51 [edk2-devel] [PATCH v5 0/9] SecurityPkg/MdePkg: Update RngLib GUID identification PierreGondois
2023-07-18 11:51 ` [edk2-devel] [PATCH v5 1/9] MdeModulePkg: Duplicate BaseRngLibTimerLib to MdeModulePkg PierreGondois
2023-08-07 5:09 ` Sami Mujawar
2023-07-18 11:51 ` [edk2-devel] [PATCH v5 2/9] MdePkg: Add deprecated warning to BaseRngLibTimer PierreGondois
2023-08-07 5:12 ` Sami Mujawar
2023-07-18 11:51 ` [edk2-devel] [PATCH v5 3/9] SecurityPkg/SecurityPkg.dec: Move PcdCpuRngSupportedAlgorithm to MdePkg PierreGondois
2023-07-18 11:51 ` [edk2-devel] [PATCH v5 4/9] MdePkg/DxeRngLib: Request raw algorithm instead of default PierreGondois
2023-07-18 11:51 ` [edk2-devel] [PATCH v5 5/9] MdePkg/Rng: Add GUID to describe Arm Rndr Rng algorithms PierreGondois
2023-07-18 11:51 ` [edk2-devel] [PATCH v5 6/9] MdeModulePkg/Rng: Add GUID to describe unsafe " PierreGondois
2023-08-07 5:13 ` Sami Mujawar
2023-07-18 11:51 ` [edk2-devel] [PATCH v5 7/9] MdePkg/Rng: Add GetRngGuid() to RngLib PierreGondois
2023-07-18 11:51 ` [edk2-devel] [PATCH v5 8/9] SecurityPkg/RngDxe: Use GetRngGuid() when probing RngLib PierreGondois
2023-08-07 5:16 ` Sami Mujawar [this message]
2023-08-10 13:19 ` PierreGondois
2023-08-10 18:37 ` Sami Mujawar
2023-07-18 11:51 ` [edk2-devel] [PATCH v5 9/9] SecurityPkg/RngDxe: Simplify Rng algorithm selection for Arm PierreGondois
2023-07-19 5:15 ` 回复: [edk2-devel] [PATCH v5 0/9] SecurityPkg/MdePkg: Update RngLib GUID identification gaoliming via groups.io
2023-07-20 18:03 ` Kun Qin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16750.1691385409155473599@groups.io \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox