From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id E7DAA780091 for ; Mon, 7 Aug 2023 05:16:50 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=iPmfeJ5ZUa+dq9sNqwlVoIoH1zzKgkKZGTDbJF1gd90=; c=relaxed/simple; d=groups.io; h=Subject:To:From:User-Agent:MIME-Version:Date:References:In-Reply-To:Message-ID:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20140610; t=1691385409; v=1; b=rTC9i1FgpOgzAQSB4WO735BZouQHY8bhc4XcDj3JD1llC9Tm9+QR8zlMZmvjhHPo9SOpu1J2 vR3tlMAx/bXoT6bT+bob+VTkjacZKAVeSaD043vwtp+d7/sg1dG3TdqPx5rioP/AFcHN7QNWqDO SPmejQ38qeYUbYK2Ft5T4GLE= X-Received: by 127.0.0.2 with SMTP id sz21YY7687511xPz7qXuqRfc; Sun, 06 Aug 2023 22:16:49 -0700 Subject: Re: [edk2-devel] [PATCH v5 8/9] SecurityPkg/RngDxe: Use GetRngGuid() when probing RngLib To: PierreGondois ,devel@edk2.groups.io From: "Sami Mujawar" X-Originating-Location: Bengaluru, Karnataka, IN (223.233.87.165) X-Originating-Platform: Mac Firefox 115 User-Agent: GROUPS.IO Web Poster MIME-Version: 1.0 Date: Sun, 06 Aug 2023 22:16:49 -0700 References: <20230718115156.1224842-9-pierre.gondois@arm.com> In-Reply-To: <20230718115156.1224842-9-pierre.gondois@arm.com> Message-ID: <16750.1691385409155473599@groups.io> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sami.mujawar@arm.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: ar7QMdL0QtLBjnU6RxGJ9Lx4x7686176AA= Content-Type: multipart/alternative; boundary="QulXSBahDOz1DV5BUkEP" X-Spam-Flag: yes X-Spam-Level: ************ X-GND-Spam-Score: 190 X-GND-Status: SPAM Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=rTC9i1Fg; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=arm.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io --QulXSBahDOz1DV5BUkEP Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi Pierre, Thank you for this patch. On Tue, Jul 18, 2023 at 04:52 AM, PierreGondois wrote: >=20 > + gEfiRngAlgorithmArmRndr ## SOMETIMES_PRODUCES ## GUID =3D > # Unique ID of the algorithm for RNG Can you check if the line above should be part of this patch, please? Otherwise, this patch looks good to me. In either case, Reviewed-by: Sami Mujawar Regards, Sami Mujawar -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107609): https://edk2.groups.io/g/devel/message/107609 Mute This Topic: https://groups.io/mt/100213737/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --QulXSBahDOz1DV5BUkEP Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi Pierre,

Thank you for this patch.

On Tue, Jul 18, = 2023 at 04:52 AM, PierreGondois wrote:
+ gEfiRngAlgorithmArmRndr ## SOMETIMES_PRODUCES ## GUID =3D
# Unique ID of the algorithm for RNG
Can you check if the line above should be part of this patch, please?
= Otherwise, this patch looks good to me.

In either case,
Re= viewed-by: Sami Mujawar <sami.mujawar@arm.com>

Regards,
Sami Mujawar
_._,_._,_

Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#107609) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--QulXSBahDOz1DV5BUkEP--