Hi Jeff,

Apologies for the delay in feedback.
Please see my response inline.

On Mon, Jul 10, 2023 at 03:26 PM, Jeff Brasen wrote:

> 
> +
> + // AmlCodeGenReturn() deletes DataNode if error.
> + Status = AmlCodeGenReturn (
> + (AML_NODE_HEADER *)DataNode,
> + ParentNode,
> + &ObjectNode
> + );
> + ASSERT_EFI_ERROR (Status);

I think the Status should be checked and error needs to be handled to free AmlNameString and IntNode. Can you check, please?

> 
> +
> + Status = AmlVarListAddTail (
> + (AML_NODE_HANDLE)ObjectNode,
> + (AML_NODE_HANDLE)IntNode
> + );
> + if (EFI_ERROR (Status)) {
> + ASSERT (0);
> + goto exit_handler;

I think IntNode would need to be freed as well. Can you check, please?

> 
> + }
> +

Your sign-off is also missing. Otherwise this patch looks good to me.

With the error handling addressed,
Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>

Regards,

Sami Mujawar


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107629): https://edk2.groups.io/g/devel/message/107629
Mute This Topic: https://groups.io/mt/100068077/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-