From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=66.187.233.73; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 6524421122E54 for ; Thu, 6 Sep 2018 09:53:21 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 999114025063; Thu, 6 Sep 2018 16:53:20 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-62.rdu2.redhat.com [10.10.120.62]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6B4B7100F42A; Thu, 6 Sep 2018 16:53:19 +0000 (UTC) To: Ard Biesheuvel , edk2-devel@lists.01.org Cc: Liming Gao , Jiewen Yao , Star Zeng , Michael D Kinney , Chao Zhang References: <20180906134523.2036-1-ard.biesheuvel@linaro.org> <20180906134523.2036-5-ard.biesheuvel@linaro.org> From: Laszlo Ersek Message-ID: <1687b7c4-4bce-d184-8e23-d156d3a4a9df@redhat.com> Date: Thu, 6 Sep 2018 18:53:18 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180906134523.2036-5-ard.biesheuvel@linaro.org> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Thu, 06 Sep 2018 16:53:20 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Thu, 06 Sep 2018 16:53:20 +0000 (UTC) for IP:'10.11.54.3' DOMAIN:'int-mx03.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'lersek@redhat.com' RCPT:'' Subject: Re: [PATCH 4/4] EdkCompatibilityPkg: remove PE/COFF header workaround for ELILO on IPF X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Sep 2018 16:53:21 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 09/06/18 15:45, Ard Biesheuvel wrote: > Now that Itanium support has been dropped, we can remove the various > occurrences of the ELILO on Itanium PE/COFF header workaround. > > Link: https://bugzilla.tianocore.org/show_bug.cgi?id=816 > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel > --- > EdkCompatibilityPkg/Foundation/Library/EdkIIGlueLib/Library/BasePeCoffLib/BasePeCoff.c | 60 +++----------------- > 1 file changed, 8 insertions(+), 52 deletions(-) Should we care about EdkCompatibilityPkg at all? Because: * IPF removal seems not to have occurred to EdkCompatibilityPkg: $ git grep -w IPF -- 'EdkCompatibilityPkg/*inf' [bunch of hits] * In , you wrote: > [...] there is a big difference between IPF drivers that are never > referenced by modern platforms, and workarounds in generic code that > are present in every modern build for every platform, and are only > intended for a specific build of ELILO. > The former is essentially dead code. The latter gets executed many > times on every boot of every modern UEFI platform in existence. Under that distinction, I would classify EdkCompatibilityPkg as the first category, i.e., essentially dead code. (I'm pointing this out in the hope that it'll save me the review of this patch! :) ) Thanks! Laszlo