Re: [Patch v2 02/11] ArmVirtPkg: Remove All UGA Support

["Sami Mujawar" <sami.mujawar@arm.com>]

Hi Guomin,

Thank you for this patch.

Please find my response inline marked [SAMI].

Regards,

Sami Mujawar

On 15/07/2022 02:50 am, Guomin Jiang wrote:
> From: GuoMinJ <newexplorerj@gmail.com>
>
> REF: https//bugzilla.tianocore.org/show_bug.cgi?id=2368
>
> Remove PcdConOutGopSupport, it is unnecessary any more.
> Remove All UGA Support in ArmVirtPkg
>
> Signed-off-by: Guomin Jiang <guomin.jiang@intel.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> ---
>   ArmVirtPkg/ArmVirtQemu.dsc       | 7 +------
>   ArmVirtPkg/ArmVirtQemuKernel.dsc | 7 +------
>   2 files changed, 2 insertions(+), 12 deletions(-)
>
> diff --git a/ArmVirtPkg/ArmVirtQemu.dsc b/ArmVirtPkg/ArmVirtQemu.dsc
> index 9369a88858fd..dc87050f3f3a 100644
> --- a/ArmVirtPkg/ArmVirtQemu.dsc
> +++ b/ArmVirtPkg/ArmVirtQemu.dsc
> @@ -1,7 +1,7 @@
>   #
>   #  Copyright (c) 2011-2015, ARM Limited. All rights reserved.
>   #  Copyright (c) 2014, Linaro Limited. All rights reserved.
> -#  Copyright (c) 2015 - 2020, Intel Corporation. All rights reserved.
> +#  Copyright (c) 2015 - 2022, Intel Corporation. All rights reserved.
>   #
>   #  SPDX-License-Identifier: BSD-2-Clause-Patent
>   #
> @@ -125,11 +125,6 @@
>     gUefiOvmfPkgTokenSpaceGuid.PcdQemuBootOrderPciTranslation|TRUE
>     gUefiOvmfPkgTokenSpaceGuid.PcdQemuBootOrderMmioTranslation|TRUE
>   
> -  ## If TRUE, Graphics Output Protocol will be installed on virtual handle created by ConsplitterDxe.
> -  #  It could be set FALSE to save size.
> -  gEfiMdeModulePkgTokenSpaceGuid.PcdConOutGopSupport|TRUE

[SAMI] I am assuming PcdConOutGopSupport is going to be removed. Can you 
confiirm, please?

I am not sure I am looking at the right pull request. But the patch at 
https://github.com/tianocore/edk2/pull/290/commits/49838844df66826c5d09a2dad075dfe0d37ee709#diff-6bdd1bc5bd7bacf61a4499e556ae002cbc49fc24c19e424fdf544d91e163bbb8 
does not seem to drop it.

Also the subject line for the commit is same as for the patch at 
https://edk2.groups.io/g/devel/message/91390 in this series.

[/SAMI]

> -  gEfiMdeModulePkgTokenSpaceGuid.PcdConOutUgaSupport|FALSE
> -
>     gEfiMdeModulePkgTokenSpaceGuid.PcdTurnOffUsbLegacySupport|TRUE
>   
>     gArmVirtTokenSpaceGuid.PcdTpm2SupportEnabled|$(TPM2_ENABLE)
> diff --git a/ArmVirtPkg/ArmVirtQemuKernel.dsc b/ArmVirtPkg/ArmVirtQemuKernel.dsc
> index 7f7d15d6eee3..0d13d8edb407 100644
> --- a/ArmVirtPkg/ArmVirtQemuKernel.dsc
> +++ b/ArmVirtPkg/ArmVirtQemuKernel.dsc
> @@ -1,7 +1,7 @@
>   #
>   #  Copyright (c) 2011-2015, ARM Limited. All rights reserved.
>   #  Copyright (c) 2014, Linaro Limited. All rights reserved.
> -#  Copyright (c) 2015 - 2020, Intel Corporation. All rights reserved.
> +#  Copyright (c) 2015 - 2022, Intel Corporation. All rights reserved.
>   #
>   #  SPDX-License-Identifier: BSD-2-Clause-Patent
>   #
> @@ -107,11 +107,6 @@
>     gUefiOvmfPkgTokenSpaceGuid.PcdQemuBootOrderPciTranslation|TRUE
>     gUefiOvmfPkgTokenSpaceGuid.PcdQemuBootOrderMmioTranslation|TRUE
>   
> -  ## If TRUE, Graphics Output Protocol will be installed on virtual handle created by ConsplitterDxe.
> -  #  It could be set FALSE to save size.
> -  gEfiMdeModulePkgTokenSpaceGuid.PcdConOutGopSupport|TRUE
> -  gEfiMdeModulePkgTokenSpaceGuid.PcdConOutUgaSupport|FALSE
> -
>     gEfiMdeModulePkgTokenSpaceGuid.PcdTurnOffUsbLegacySupport|TRUE
>   
>   [PcdsFixedAtBuild.common]