public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Laszlo Ersek" <lersek@redhat.com>
To: devel@edk2.groups.io, michael.d.kinney@intel.com
Cc: Sean Brogan <sean.brogan@microsoft.com>
Subject: Re: [edk2-devel] github PRs keep breaking for me
Date: Tue, 9 Jun 2020 23:37:23 +0200	[thread overview]
Message-ID: <16a59bdb-b24f-b658-d5bf-1711336230ea@redhat.com> (raw)
In-Reply-To: <E92EE9817A31E24EB0585FDF735412F5B9ECCA67@ORSMSX113.amr.corp.intel.com>

Hi,

On 03/12/20 22:57, Michael D Kinney wrote:

> The hub command is very flexible.  What commands did you try?

github again failed to accept the "push" label when I tried to set it.

Unlike last time, the push label *is* offered to me in the small widget
to the right. When I click the label, it even gets a check mark.
However, the label isn't actually applied to the PR. No comment saying
"lersek set the 'push' label now" is generated, and the push label is
not displayed to the right, once the small search widget is closed.

I tried both the WebUI:

  https://github.com/tianocore/edk2/pull/672

and then the "hub" utility (with "--labels push"):

  https://github.com/tianocore/edk2/pull/673

In either case, the "push" label didn't take.

Frustrating.

> I want to root cause this issue.  I suspect it is more related
> to Mergify than GitHub or Azure Pipelines.  There is a state 
> machine that is watching statuses and the sequence of actions
> you are using must be going into a state I did not test.
> Are you able to provide the sequences of steps that got the
> PR into a bad state and the approximate time between steps?

I'm quite certain this is not related to mergify, as mergify's role
would be in the end, when all the checks pass. Mergify correctly
interprets the absence of the "push" label. The problem is that github
does not add the label, in spite of my actions.

Thanks
Laszlo


  parent reply	other threads:[~2020-06-09 21:37 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-12 21:06 github PRs keep breaking for me Laszlo Ersek
2020-03-12 21:57 ` [edk2-devel] " Michael D Kinney
2020-03-13 17:27   ` Laszlo Ersek
2020-03-13 18:21     ` Rebecca Cran
2020-06-09 21:37   ` Laszlo Ersek [this message]
2020-06-09 21:51     ` Laszlo Ersek
2020-06-09 21:55       ` Laszlo Ersek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=16a59bdb-b24f-b658-d5bf-1711336230ea@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox