From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.81]) by mx.groups.io with SMTP id smtpd.web12.1094.1591738650850819666 for ; Tue, 09 Jun 2020 14:37:31 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=K+FByP41; spf=pass (domain: redhat.com, ip: 207.211.31.81, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1591738650; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GJZinANSiYlKvx/3hpiiHZypiXAyZS89uOnh/GRznYs=; b=K+FByP41ywXf7ay/TbxrlNS/h9ZQBBo2gRTSafYPWj3TuGxctGg/TKlEJglRov8ZDdG3M/ dTz1MnX3W/onPl6B8xSqO8SsIDkgidf2U9Ysf3mk65kinzsq9nijD1tunO8fR+GxAMr1qO kg5/wa1hbSi5selia80uo26gNf5Sumk= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-219-zeNuTixfNSKxYaEyJ3Qcgw-1; Tue, 09 Jun 2020 17:37:26 -0400 X-MC-Unique: zeNuTixfNSKxYaEyJ3Qcgw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id AA353835B43; Tue, 9 Jun 2020 21:37:25 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-112-194.ams2.redhat.com [10.36.112.194]) by smtp.corp.redhat.com (Postfix) with ESMTP id CCB4F5C1BD; Tue, 9 Jun 2020 21:37:24 +0000 (UTC) Subject: Re: [edk2-devel] github PRs keep breaking for me To: devel@edk2.groups.io, michael.d.kinney@intel.com Cc: Sean Brogan References: From: "Laszlo Ersek" Message-ID: <16a59bdb-b24f-b658-d5bf-1711336230ea@redhat.com> Date: Tue, 9 Jun 2020 23:37:23 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Hi, On 03/12/20 22:57, Michael D Kinney wrote: > The hub command is very flexible. What commands did you try? github again failed to accept the "push" label when I tried to set it. Unlike last time, the push label *is* offered to me in the small widget to the right. When I click the label, it even gets a check mark. However, the label isn't actually applied to the PR. No comment saying "lersek set the 'push' label now" is generated, and the push label is not displayed to the right, once the small search widget is closed. I tried both the WebUI: https://github.com/tianocore/edk2/pull/672 and then the "hub" utility (with "--labels push"): https://github.com/tianocore/edk2/pull/673 In either case, the "push" label didn't take. Frustrating. > I want to root cause this issue. I suspect it is more related > to Mergify than GitHub or Azure Pipelines. There is a state > machine that is watching statuses and the sequence of actions > you are using must be going into a state I did not test. > Are you able to provide the sequences of steps that got the > PR into a bad state and the approximate time between steps? I'm quite certain this is not related to mergify, as mergify's role would be in the end, when all the checks pass. Mergify correctly interprets the absence of the "push" label. The problem is that github does not add the label, in spite of my actions. Thanks Laszlo