From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com [209.85.218.50])
 by mx.groups.io with SMTP id smtpd.web12.20697.1594920636809551562
 for <devel@edk2.groups.io>;
 Thu, 16 Jul 2020 10:30:37 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@broadcom.com header.s=google header.b=dSWYObjX;
 spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: broadcom.com, ip: 209.85.218.50, mailfrom: vladimir.olovyannikov@broadcom.com)
Received: by mail-ej1-f50.google.com with SMTP id ga4so7429036ejb.11
        for <devel@edk2.groups.io>; Thu, 16 Jul 2020 10:30:36 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=broadcom.com; s=google;
        h=from:references:in-reply-to:mime-version:thread-index:date
         :message-id:subject:to:cc;
        bh=7srwnjyNQyWp9pEpBSp3uV1vqgnj8HtdePpPTBN3kyM=;
        b=dSWYObjXzrl90lw0fyTgSuZh/PtyDcoQ3IXABi7BJ+ZhmtgsLgPALSZdBh7qg2Z0lV
         Q9drEx9uj5fh0F625lDCF5XFSBRs9Defa2Mq45Aa7n94RVUKPaGhhImMM1P8shBNST/B
         ZgWTK8X9GGd+d6sq5f9a2grv/JqNpBy+47kIg=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:from:references:in-reply-to:mime-version
         :thread-index:date:message-id:subject:to:cc;
        bh=7srwnjyNQyWp9pEpBSp3uV1vqgnj8HtdePpPTBN3kyM=;
        b=TiKqn6QzUEmr4RMVyHKfGVinREV0VrqvawJEWCaQOHmGNne5wBu7xz46Qq2xTyiYdo
         2lFn8HpNZEUz+MRjrwQXSDxxEjq+yQO/9cvvEbd9kKg0tvPFzoSuAzodsSBqrR4p7mNV
         54l+nV1RzCsaIisYwHd3agtZtjhFYbb6aAXyv3pTeUsZpyFAwGkhsETCdeHTRiv2CYTk
         sxXTF4Hv7r8LXoBMu5vzfjAtygfY7dWThd4afWAX87ooM671t+xS2SOtAdFX7X4dboLr
         HsbFDU4/6J7QQN2dGC2bMzzJL52EipZV51aVZdsBWL8qi3QKcNT1KRM0oC1HLVRoeBxL
         /fwA==
X-Gm-Message-State: AOAM53369+WTuQ5QptL4clvj4NGdaI2fLCxqU+T1//A5iH7abKa35jmM
	tSW8U513TiXStveJkgRWJkBdDuID5Ioj7YIw7VZMc3UPr1E=
X-Google-Smtp-Source: ABdhPJzUSURe6mVRLwDl7ahrkhTCZpWdkWuNKdvslYIzOhdryhYn8fJm5uYT/WlAr8C15BeArpl+VArKQ5f6NdOqE0s=
X-Received: by 2002:a2e:8798:: with SMTP id n24mr2415120lji.372.1594919272327;
 Thu, 16 Jul 2020 10:07:52 -0700 (PDT)
From: "Vladimir Olovyannikov" <vladimir.olovyannikov@broadcom.com>
References: <20200713183137.9825-1-vladimir.olovyannikov@broadcom.com>
 <17bab469-76af-0ffc-b99c-962f4eb20010@redhat.com> <fae81c05-4e0f-915a-90aa-15631ecb150d@redhat.com>
 <ec5885cf44a35e4af2206e8bf5d8b9cb@mail.gmail.com> <b288887e-35ea-8707-51e0-d861abf0fafa@redhat.com>
In-Reply-To: <b288887e-35ea-8707-51e0-d861abf0fafa@redhat.com>
MIME-Version: 1.0
X-Mailer: Microsoft Outlook 16.0
Thread-Index: AQHWOTapeOQNV4NQfAeaKbZPaHyXkQF6CKeRAhRV4gEBSZV8tQJCru4lqNHfRjA=
Date: Thu, 16 Jul 2020 10:07:50 -0700
Message-ID: <16cac674361c182f48954e7a0706aef3@mail.gmail.com>
Subject: Re: [edk2-devel] [PATCH v3 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand
To: Laszlo Ersek <lersek@redhat.com>, devel@edk2.groups.io
Cc: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>, Zhichao Gao <zhichao.gao@intel.com>, 
	Maciej Rabeda <maciej.rabeda@linux.intel.com>, Jiaxin Wu <jiaxin.wu@intel.com>, 
	Siyuan Fu <siyuan.fu@intel.com>, Ray Ni <ray.ni@intel.com>, 
	Liming Gao <liming.gao@intel.com>, Nd <nd@arm.com>
Content-Type: text/plain; charset="UTF-8"

> -----Original Message-----
> From: Laszlo Ersek <lersek@redhat.com>
> Sent: Thursday, July 16, 2020 5:20 AM
> To: Vladimir Olovyannikov <vladimir.olovyannikov@broadcom.com>;
> devel@edk2.groups.io
> Cc: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>; Zhichao
> Gao <zhichao.gao@intel.com>; Maciej Rabeda
> <maciej.rabeda@linux.intel.com>; Jiaxin Wu <jiaxin.wu@intel.com>; Siyuan
> Fu <siyuan.fu@intel.com>; Ray Ni <ray.ni@intel.com>; Liming Gao
> <liming.gao@intel.com>; Nd <nd@arm.com>
> Subject: Re: [edk2-devel] [PATCH v3 1/1] ShellPkg/DynamicCommand: add
> HttpDynamicCommand
>
> On 07/15/20 19:09, Vladimir Olovyannikov wrote:
> > Hi Laszlo,
> >
> > Thank you for supporting this.
> > I can add required support.
>
> Thanks!
>
> > But shouldn't we wait until the patch is reviewed and approved first?
> > I don't know the proper procedure. Please advise.
>
> If a v4 of your patch becomes necessary, based on the ShellPkg
> maintainers'
> review, then my suggestion would be to send v4 as a patch series, not as a
> single patch. The v4 1/3 patch would be the current patch (with updates as
> requested by the ShellPkg reviewers). The v4 2/3 patch would extend
> ArmVirtPkg to include the new dynamic command. The v4
> 3/3 patch would do the same for OvmfPkg.
>
> If a v4 of your patch turns out to be unnecessary (i.e., in case the
> ShellPkg
> maintainers merge your v3 patch as-is), then sending a separate 2-part
> series
> (1/2: ArmVirtPkg, 2/2: OvmfPkg) would be straightforward, in my opinion.
>
> Thank you for considering my request (and for implementing the feature in
> the first place, of course)!
>
> Laszlo
Thank you Laszlo,
Sure, this makes sense. I will send a patchset for ArmVirtPkg and OvmfPkg as
you suggested.

Vladimir