From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web10.11261.1603789545647862912 for ; Tue, 27 Oct 2020 02:05:46 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: ard.biesheuvel@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2C30130E; Tue, 27 Oct 2020 02:05:35 -0700 (PDT) Received: from [192.168.1.81] (unknown [10.37.8.95]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4B3183F66E; Tue, 27 Oct 2020 02:05:33 -0700 (PDT) Subject: =?UTF-8?B?UmU6IOWbnuWkjTog5Zue5aSNOiDlm57lpI06IFtlZGsyLWRldmVsXSBbUEFUQ0ggMS8zXSBNZGVNb2R1bGVQa2cvQWNwaVRhYmxlRHhlOiB1c2UgcG9vbCBhbGxvY2F0aW9ucyB3aGVuIHBvc3NpYmxl?= To: gaoliming , 'Laszlo Ersek' , devel@edk2.groups.io Cc: 'Dandan Bi' , 'Jian J Wang' , 'Hao A Wu' , 'Sami Mujawar' , 'Leif Lindholm' References: <20201016154923.21260-1-ard.biesheuvel@arm.com> <20201016154923.21260-2-ard.biesheuvel@arm.com> <009401d6a817$53da54e0$fb8efea0$@byosoft.com.cn> <003401d6ab38$411f31d0$c35d9570$@byosoft.com.cn> <756ec3e7-a1df-8251-f284-07b7aa45ef7f@arm.com> <004001d6ac3d$80117aa0$80346fe0$@byosoft.com.cn> From: "Ard Biesheuvel" Message-ID: <16e3e13d-63a2-ee41-37a2-89b332f2520e@arm.com> Date: Tue, 27 Oct 2020 10:05:30 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <004001d6ac3d$80117aa0$80346fe0$@byosoft.com.cn> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 10/27/20 9:45 AM, gaoliming wrote: > Ard: > After removes BIT1 from gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiExposedTableVersions for OVMFX64, the memory ACPI_Recl will be reduced with this patch set. > > I also review the code logic. I don't find other issue. I see Laszlo gives one comment on CurrentTableList. It is from AllocatePool(). If so, CurrentTableList->PoolAllocation value should be set to FALSE. > Thank you Liming. I will respin the series with Laszlo's comments addressed.