Re: [Patch v2 03/11] ArmPkg: Remove All UGA Support

["Sami Mujawar" <sami.mujawar@arm.com>]

Hi Guomin,

Thank you for this patch.

This change looks good to me.

Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>

Regards,

Sami Mujawar

On 15/07/2022 02:50 am, Guomin Jiang wrote:
> From: GuoMinJ <newexplorerj@gmail.com>
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2368
>
> Remove All UGA Support in ArmPkg.
>
> Signed-off-by: Guomin Jiang <guomin.jiang@intel.com>
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> ---
>   ArmPkg/Library/PlatformBootManagerLib/PlatformBm.h           | 4 ++--
>   .../PlatformBootManagerLib/PlatformBootManagerLib.inf        | 5 +----
>   2 files changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.h b/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.h
> index a40a2ff5cb4f..a2ec4c4ad6c7 100644
> --- a/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.h
> +++ b/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.h
> @@ -2,7 +2,7 @@
>     Head file for BDS Platform specific code
>   
>     Copyright (C) 2015-2016, Red Hat, Inc.
> -  Copyright (c) 2004 - 2008, Intel Corporation. All rights reserved.<BR>
> +  Copyright (c) 2004 - 2022, Intel Corporation. All rights reserved.<BR>
>     Copyright (c) 2016, Linaro Ltd. All rights reserved.<BR>
>   
>     SPDX-License-Identifier: BSD-2-Clause-Patent
> @@ -43,7 +43,7 @@ EnableQuietBoot (
>     Simple Text Out screens will now be synced up with all non video output
>     devices
>   
> -  @retval EFI_SUCCESS     UGA devices are back in text mode and synced up.
> +  @retval EFI_SUCCESS     Graphic devices are back in text mode and synced up.
>   **/
>   EFI_STATUS
>   DisableQuietBoot (
> diff --git a/ArmPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf b/ArmPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf
> index 86751b45f82b..63d1d83ab0ef 100644
> --- a/ArmPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf
> +++ b/ArmPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf
> @@ -3,7 +3,7 @@
>   #
>   #  Copyright (C) 2015-2016, Red Hat, Inc.
>   #  Copyright (c) 2014, ARM Ltd. All rights reserved.<BR>
> -#  Copyright (c) 2007 - 2014, Intel Corporation. All rights reserved.<BR>
> +#  Copyright (c) 2007 - 2022, Intel Corporation. All rights reserved.<BR>
>   #  Copyright (c) 2016, Linaro Ltd. All rights reserved.<BR>
>   #
>   #  SPDX-License-Identifier: BSD-2-Clause-Patent
> @@ -51,9 +51,6 @@
>     UefiLib
>     UefiRuntimeServicesTableLib
>   
> -[FeaturePcd]
> -  gEfiMdePkgTokenSpaceGuid.PcdUgaConsumeSupport
> -
>   [FixedPcd]
>     gEfiMdeModulePkgTokenSpaceGuid.PcdEmuVariableNvModeEnable
>     gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString