Re: [PATCH edk2-platforms v2 03/11] Platform/ARM: SGI: Update for IORT revision macro renaming

["Thomas Abraham" <thomas.abraham@arm.com>]

Hi Sami,

On 06/07/2022 16:15, Sami Mujawar wrote:
> Hi Thomas,
> 
> Please find my response inline marked [SAMI].
> 
> Regards,
> 
> Sami Mujawar
> 
> On 06/07/2022 03:18 pm, Thomas Abraham wrote:
>>
>>
>> On 06/07/2022 11:39, Sami Mujawar wrote:
>>> The IORT Specification E.d updates the IORT table revision to 5. To
>>> reflect this change the IORT header file has been updated to rename
>>> the EFI_ACPI_IO_REMAPPING_TABLE_REVISION macro which was at Rev 0 to
>>> EFI_ACPI_IO_REMAPPING_TABLE_REV0.
>>>
>>> Therefore, update the usage of EFI_ACPI_IO_REMAPPING_TABLE_REVISION
>>> macro in the IORT table for SGI platforms to
>>> EFI_ACPI_IO_REMAPPING_TABLE_REV0.
>>>
>>> Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
>>> ---
>>>   Platform/ARM/SgiPkg/AcpiTables/Iort.aslc | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/Platform/ARM/SgiPkg/AcpiTables/Iort.aslc 
>>> b/Platform/ARM/SgiPkg/AcpiTables/Iort.aslc
>>> index 
>>> fcc28a71c82eb0c78c96d60c9d9eb1554adb41a3..415403e8e8e5946d3a2319d83b76d6182a8a1e74 
>>> 100644
>>> --- a/Platform/ARM/SgiPkg/AcpiTables/Iort.aslc
>>> +++ b/Platform/ARM/SgiPkg/AcpiTables/Iort.aslc
>>> @@ -50,7 +50,7 @@ ARM_EFI_ACPI_6_0_IO_REMAPPING_TABLE Iort =
>>>        (
>>>          EFI_ACPI_6_2_IO_REMAPPING_TABLE_SIGNATURE,
>>>          ARM_EFI_ACPI_6_0_IO_REMAPPING_TABLE,
>>> -       EFI_ACPI_IO_REMAPPING_TABLE_REVISION
>>> +       EFI_ACPI_IO_REMAPPING_TABLE_REV0
>>
>> nit: Should this have been EFI_ACPI_IO_REMAPPING_TABLE_REVISION_0 to 
>> better align with all the other table revision macros?
> 
> [SAMI] I checked the edk2 code base and apparenlty the protocol 
> versioning follows the scheme you mention above. As for ACPI tables the 
> revision is derived from the _ACPI_x_y_ prefix in the macro name. e.g. 
> EFI_ACPI_6_4_GENERIC_TIMER_DESCRIPTION_TABLE_REVISION.
> 
> However, I have no objection to your suggestion with the only change 
> that I would then prefer to make it 
> EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00.
> 
> Kindly let me know if this is acceptable and I will respin this patch 
> series along with the edk2 series.
> 
> [/SAMI]

Yes, that would also be okay.

Thanks.

> 
>>
>>>        ),
>>>        3,  // NumNodes
>>>        sizeof (EFI_ACPI_6_0_IO_REMAPPING_TABLE),  // NodeOffset
>>
>>
>> Reviewed-by: Thomas Abraham <thomas.abraham@arm.com>
>>
>> Thanks.