* Re: [Patch] NetworkPkg: Fix GCC build issue.
2017-06-23 0:59 [Patch] NetworkPkg: Fix GCC build issue Fu Siyuan
@ 2017-06-23 1:02 ` Wu, Jiaxin
2017-06-23 2:03 ` Ye, Ting
2017-06-23 15:55 ` Laszlo Ersek
2 siblings, 0 replies; 4+ messages in thread
From: Wu, Jiaxin @ 2017-06-23 1:02 UTC (permalink / raw)
To: Fu, Siyuan, edk2-devel@lists.01.org; +Cc: Ye, Ting
Reviewed-by: Wu Jiaxin <jiaxin.wu@intel.com>
> -----Original Message-----
> From: Fu, Siyuan
> Sent: Friday, June 23, 2017 9:00 AM
> To: edk2-devel@lists.01.org
> Cc: Ye, Ting <ting.ye@intel.com>; Wu, Jiaxin <jiaxin.wu@intel.com>
> Subject: [Patch] NetworkPkg: Fix GCC build issue.
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Fu Siyuan <siyuan.fu@intel.com>
> Cc: Ye Ting <ting.ye@intel.com>
> Cc: Wu Jiaxin <jiaxin.wu@intel.com>
> ---
> NetworkPkg/HttpBootDxe/HttpBootImpl.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/NetworkPkg/HttpBootDxe/HttpBootImpl.c
> b/NetworkPkg/HttpBootDxe/HttpBootImpl.c
> index 56f5babeb4..63cf3960a9 100644
> --- a/NetworkPkg/HttpBootDxe/HttpBootImpl.c
> +++ b/NetworkPkg/HttpBootDxe/HttpBootImpl.c
> @@ -630,6 +630,7 @@ EFI_LOAD_FILE_PROTOCOL gHttpBootDxeLoadFile = {
> @retval EFI_ABORTED Tells the HTTP Boot driver to abort the current
> HTTP Boot process.
> **/
> EFI_STATUS
> +EFIAPI
> HttpBootCallback (
> IN EFI_HTTP_BOOT_CALLBACK_PROTOCOL *This,
> IN EFI_HTTP_BOOT_CALLBACK_DATA_TYPE DataType,
> --
> 2.13.0.windows.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Patch] NetworkPkg: Fix GCC build issue.
2017-06-23 0:59 [Patch] NetworkPkg: Fix GCC build issue Fu Siyuan
2017-06-23 1:02 ` Wu, Jiaxin
@ 2017-06-23 2:03 ` Ye, Ting
2017-06-23 15:55 ` Laszlo Ersek
2 siblings, 0 replies; 4+ messages in thread
From: Ye, Ting @ 2017-06-23 2:03 UTC (permalink / raw)
To: Fu, Siyuan, edk2-devel@lists.01.org; +Cc: Wu, Jiaxin
Reviewed-by: Ye Ting <ting.ye@intel.com>
-----Original Message-----
From: Fu, Siyuan
Sent: Friday, June 23, 2017 9:00 AM
To: edk2-devel@lists.01.org
Cc: Ye, Ting <ting.ye@intel.com>; Wu, Jiaxin <jiaxin.wu@intel.com>
Subject: [Patch] NetworkPkg: Fix GCC build issue.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Fu Siyuan <siyuan.fu@intel.com>
Cc: Ye Ting <ting.ye@intel.com>
Cc: Wu Jiaxin <jiaxin.wu@intel.com>
---
NetworkPkg/HttpBootDxe/HttpBootImpl.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/NetworkPkg/HttpBootDxe/HttpBootImpl.c b/NetworkPkg/HttpBootDxe/HttpBootImpl.c
index 56f5babeb4..63cf3960a9 100644
--- a/NetworkPkg/HttpBootDxe/HttpBootImpl.c
+++ b/NetworkPkg/HttpBootDxe/HttpBootImpl.c
@@ -630,6 +630,7 @@ EFI_LOAD_FILE_PROTOCOL gHttpBootDxeLoadFile = {
@retval EFI_ABORTED Tells the HTTP Boot driver to abort the current HTTP Boot process.
**/
EFI_STATUS
+EFIAPI
HttpBootCallback (
IN EFI_HTTP_BOOT_CALLBACK_PROTOCOL *This,
IN EFI_HTTP_BOOT_CALLBACK_DATA_TYPE DataType,
--
2.13.0.windows.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Patch] NetworkPkg: Fix GCC build issue.
2017-06-23 0:59 [Patch] NetworkPkg: Fix GCC build issue Fu Siyuan
2017-06-23 1:02 ` Wu, Jiaxin
2017-06-23 2:03 ` Ye, Ting
@ 2017-06-23 15:55 ` Laszlo Ersek
2 siblings, 0 replies; 4+ messages in thread
From: Laszlo Ersek @ 2017-06-23 15:55 UTC (permalink / raw)
To: Fu Siyuan, edk2-devel; +Cc: Ye Ting, Wu Jiaxin
On 06/23/17 02:59, Fu Siyuan wrote:
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Fu Siyuan <siyuan.fu@intel.com>
> Cc: Ye Ting <ting.ye@intel.com>
> Cc: Wu Jiaxin <jiaxin.wu@intel.com>
> ---
> NetworkPkg/HttpBootDxe/HttpBootImpl.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/NetworkPkg/HttpBootDxe/HttpBootImpl.c b/NetworkPkg/HttpBootDxe/HttpBootImpl.c
> index 56f5babeb4..63cf3960a9 100644
> --- a/NetworkPkg/HttpBootDxe/HttpBootImpl.c
> +++ b/NetworkPkg/HttpBootDxe/HttpBootImpl.c
> @@ -630,6 +630,7 @@ EFI_LOAD_FILE_PROTOCOL gHttpBootDxeLoadFile = {
> @retval EFI_ABORTED Tells the HTTP Boot driver to abort the current HTTP Boot process.
> **/
> EFI_STATUS
> +EFIAPI
> HttpBootCallback (
> IN EFI_HTTP_BOOT_CALLBACK_PROTOCOL *This,
> IN EFI_HTTP_BOOT_CALLBACK_DATA_TYPE DataType,
>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Thanks!
Laszlo
^ permalink raw reply [flat|nested] 4+ messages in thread