From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id EE945740034 for ; Tue, 13 Feb 2024 23:31:31 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=w6BX/I+1eIE0xcuigdX6ym4a5QhiMMWtV5VhobzXIwo=; c=relaxed/simple; d=groups.io; h=Subject:To:From:User-Agent:MIME-Version:Date:References:In-Reply-To:Message-ID:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20140610; t=1707867090; v=1; b=MW4UFu9Cgu9eRpRbjtyr1/WJJyQYYtHIYXP74h+ilIfNSBvzZqi9/2VWRZtCo0y+e23jl0KY Om9TORPm2diGuzVLUDaAV41Wod74eTxAe9Mm+TB/oAvWP5gFrh98BzYT4MWvB0GLidGH/3rSmZv MDbY4RnaMziqriWLvTljNS2g= X-Received: by 127.0.0.2 with SMTP id IMuhYY7687511xaF50QZ3Kpe; Tue, 13 Feb 2024 15:31:30 -0800 Subject: Re: [edk2-devel] [PATCH v2 1/4] NetworkPkg: Dhcp6Dxe: SECURITY PATCH CVE-2023-45229 Related Patch To: Saloni Kasbekar ,devel@edk2.groups.io From: "Doug Flick via groups.io" X-Originating-Location: Redmond, Washington, US (131.107.147.247) X-Originating-Platform: Windows Chrome 121 User-Agent: GROUPS.IO Web Poster MIME-Version: 1.0 Date: Tue, 13 Feb 2024 15:31:29 -0800 References: In-Reply-To: Message-ID: <17290.1707867089829490637@groups.io> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,dougflick@microsoft.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: RchbOMum9pXxFJBoGW4Upbtax7686176AA= Content-Type: multipart/alternative; boundary="8AqInuDaEy02c0VZADwx" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=MW4UFu9C; dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io --8AqInuDaEy02c0VZADwx Content-Type: text/plain; charset="utf-8"; markup=markdown Content-Transfer-Encoding: quoted-printable Saloni, Yeah there was never any tests that showed this bug exists mostly it was br= ought up through static analysis since it's related to a known CVE. I have = written some unit tests (that I'm not particularly satisfied with) that sho= w that I'm hitting the desired code paths that can trigger the issue. Howev= er this code path is not particularly nice to unit tests because the first = option I have for a status code that isn't EFI_DEVICE_ERROR occurs in Dhcp6= GenerateIaCb and I had to do some gross things to satisfy Dhcp6ParseAddrOpt= ion. Regardless through that testing I can confirm that I can hit the code = paths that I need to be testing for this change. The Dhcp6SeekInnerOptionSa= fe function is well unit tested, and the code pattern is used elsewhere and= is unit tested. So, I feel confident with the unit testing I have done tha= t this change is successful, and I would like to follow up with unit tests = / more code cleanup once we're out of code cleanup. Further, I've performed a PxeBoot to ensure the device still boots - but th= at test generally doesn't feel like it's good enough for any confidence sin= ce I have no control over the code path.=20 If you would like I can upload the Unit tests, but they're likely to underg= o more changes and I wouldn't recommend getting them in right now. - Doug -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115421): https://edk2.groups.io/g/devel/message/115421 Mute This Topic: https://groups.io/mt/104339706/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --8AqInuDaEy02c0VZADwx Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable

Saloni,

Yeah there was never any tests that showed this bug exists mostly it was= brought up through static analysis since it's related to a known CVE. I ha= ve written some unit tests (that I'm not particularly satisfied with) that = show that I'm hitting the desired code paths that can trigger the issue. Ho= wever this code path is not particularly nice to unit tests because the fir= st option I have for a status code that isn't EFI_DEVICE_ERROR occurs in Dh= cp6GenerateIaCb and I had to do some gross things to satisfy Dhcp6ParseAddr= Option. Regardless through that testing I can confirm that I can hit the co= de paths that I need to be testing for this change. The Dhcp6SeekInnerOptio= nSafe function is well unit tested, and the code pattern is used elsewhere = and is unit tested. So, I feel confident with the unit testing I have done = that this change is successful, and I would like to follow up with unit tes= ts / more code cleanup once we're out of code cleanup.

Further, I've performed a PxeBoot to ensure the device still boots - but= that test generally doesn't feel like it's good enough for any confidence = since I have no control over the code path.

If you would like I can upload the Unit tests, but they're likely to und= ergo more changes and I wouldn't recommend getting them in right now.

  • Doug
_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#115421) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--8AqInuDaEy02c0VZADwx--