From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 5EE41941A68 for ; Tue, 12 Mar 2024 15:40:08 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=Wb9QYfayj8W9mknrRzt2ig3blnZKMLXm+rxT9MMuYgo=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20240206; t=1710258007; v=1; b=NpzhoPqLveL+r8kPuCfKCFe4zvOk0Izn3Gb6lP+3DkqqfoY6QHaiV5KhXUda6lySZUAnisjs 1rFxDrsD1d4/JCtW4uIKx1wfCOLn1MTfN7U4JQ3+yl0JliKHwxCBqJ4Jjr0kKfgQH5FBwLLyF3y hDQpTwMK6yyGr+G9yiQbzaHQ2nvtMALXNK9O1SYnOZ1pgnh7Ysg+OmQzyV84d09GsAcvdtjm/I9 lILPvZ9nlyYq7d+nMdoGS3K6hwu0gs0Qt1iuhmmnOGUdOXtbwfn0CyXCu/A/+wmRXIhD05cL8/H wBIC7E4IAVTqFPkEtSp+39vq2uzneIwdecRepzLc3ytyw== X-Received: by 127.0.0.2 with SMTP id N3EcYY7687511xeO4PPC1FwY; Tue, 12 Mar 2024 08:40:07 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.18]) by mx.groups.io with SMTP id smtpd.web10.57768.1710146508064491423 for ; Mon, 11 Mar 2024 01:41:56 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,11009"; a="4640569" X-IronPort-AV: E=Sophos;i="6.07,116,1708416000"; d="scan'208";a="4640569" X-Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Mar 2024 01:41:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,116,1708416000"; d="scan'208";a="10984414" X-Received: from qingyush-mobl.ccr.corp.intel.com ([10.238.9.87]) by fmviesa007.fm.intel.com with ESMTP; 11 Mar 2024 01:41:53 -0700 From: "Qingyu" To: devel@edk2.groups.io Cc: Leif Lindholm , Ard Biesheuvel , Abner Chang , Liming Gao Subject: [edk2-devel] [PATCH 3/4] EmbeddedPkg: Update the comments of ReadKeyStroke and ReadKeyStrokeEx Date: Mon, 11 Mar 2024 16:41:15 +0800 Message-Id: <172aa2628294d583f7c7cfe3be62cd352b97efc2.1710145917.git.qingyu.shang@intel.com> In-Reply-To: References: MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Tue, 12 Mar 2024 08:40:04 -0700 Reply-To: devel@edk2.groups.io,qingyu.shang@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: FmbGB1ZjcrZtUct90cxHsOVCx7686176AA= Content-Transfer-Encoding: 8bit X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=NpzhoPqL; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Refer to Uefi spec 2.10 section 13.3.3, Add a new retval EFI_UNSUPPORTED to EFI_SIMPLE_TEXT_INPUT_EX_PROTOCOL.ReadKeyStrokeEx and EFI_SIMPLE_TEXT_INPUT_PROTOCOL.ReadKeyStroke(). Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Abner Chang Cc: Liming Gao Signed-off-by: Qingyu --- .../Drivers/VirtualKeyboardDxe/VirtualKeyboard.c | 10 ++++++---- .../Drivers/VirtualKeyboardDxe/VirtualKeyboard.h | 10 ++++++---- 2 files changed, 12 insertions(+), 8 deletions(-) diff --git a/EmbeddedPkg/Drivers/VirtualKeyboardDxe/VirtualKeyboard.c b/EmbeddedPkg/Drivers/VirtualKeyboardDxe/VirtualKeyboard.c index 4bbc3ead2c87..48a99566df63 100644 --- a/EmbeddedPkg/Drivers/VirtualKeyboardDxe/VirtualKeyboard.c +++ b/EmbeddedPkg/Drivers/VirtualKeyboardDxe/VirtualKeyboard.c @@ -694,11 +694,12 @@ KeyboardReadKeyStrokeWorker ( /** Read out the scan code of the key that has just been stroked. - @param This Pointer of simple text Protocol. - @param Key Pointer for store the key that read out. + @param This Pointer of simple text Protocol. + @param Key Pointer for store the key that read out. - @retval EFI_SUCCESS The key is read out successfully. - @retval other The key reading failed. + @retval EFI_SUCCESS The key is read out successfully. + @retval other The key reading failed. + @retval EFI_UNSUPPORTED The device does not support the ability to read keystroke data. **/ EFI_STATUS @@ -752,6 +753,7 @@ VirtualKeyboardReadKeyStroke ( @retval EFI_DEVICE_ERROR The keystroke information was not returned due to hardware errors. @retval EFI_INVALID_PARAMETER KeyData is NULL. + @retval EFI_UNSUPPORTED The device does not support the ability to read keystroke data. **/ EFI_STATUS diff --git a/EmbeddedPkg/Drivers/VirtualKeyboardDxe/VirtualKeyboard.h b/EmbeddedPkg/Drivers/VirtualKeyboardDxe/VirtualKeyboard.h index f72bd6f9c6cc..25063c262721 100644 --- a/EmbeddedPkg/Drivers/VirtualKeyboardDxe/VirtualKeyboard.h +++ b/EmbeddedPkg/Drivers/VirtualKeyboardDxe/VirtualKeyboard.h @@ -496,11 +496,12 @@ KeyNotifyProcessHandler ( /** Read out the scan code of the key that has just been stroked. - @param This Pointer of simple text Protocol. - @param Key Pointer for store the key that read out. + @param This Pointer of simple text Protocol. + @param Key Pointer for store the key that read out. - @retval EFI_SUCCESS The key is read out successfully. - @retval other The key reading failed. + @retval EFI_SUCCESS The key is read out successfully. + @retval other The key reading failed. + @retval EFI_UNSUPPORTED The device does not support the ability to read keystroke data. **/ EFI_STATUS @@ -523,6 +524,7 @@ VirtualKeyboardReadKeyStroke ( @retval EFI_DEVICE_ERROR The keystroke information was not returned due to hardware errors. @retval EFI_INVALID_PARAMETER KeyData is NULL. + @retval EFI_UNSUPPORTED The device does not support the ability to read keystroke data. **/ EFI_STATUS -- 2.39.1.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116683): https://edk2.groups.io/g/devel/message/116683 Mute This Topic: https://groups.io/mt/104886873/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-