From: "Timothy Lin" <timothy.gh.lin@gmail.com>
To: Chang, Abner <abner.chang@amd.com>,devel@edk2.groups.io
Subject: Re: [edk2-devel] [PATCH V2] MdeModulePkg/Decompress: Add missing source file to Brotli library
Date: Wed, 18 Jan 2023 15:44:44 -0800 [thread overview]
Message-ID: <17348.1674085484393166938@groups.io> (raw)
In-Reply-To: <MN2PR12MB3966E70F30630362CBEFEC73EAC79@MN2PR12MB3966.namprd12.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 1320 bytes --]
This patch tried to fix following build failure when linking the Brotli decompress lib.
Steps to replicate the issue:
1 - Attach a NULL lib to DxeIpl.inf in any project's .DSC, say OvmfPkgX64.dsc
MdeModulePkg/Core/DxeIplPeim/DxeIpl.inf {
<LibraryClasses>
NULL|MdeModulePkg/Library/BrotliCustomDecompressLib/BrotliCustomDecompressLib.inf
}
2 - Follow the EDKII'2 package build steps to build that project. Build.py would compliain with following errors.
...
/home/edk2/edk2-stable202211/MdeModulePkg/Library/BrotliCustomDecompressLib/brotli/c/dec/decode.c:879: undefined reference to `_kBrotliPrefixCodeRanges'
/usr/bin/ld: /home/edk2/edk2-stable202211/MdeModulePkg/Library/BrotliCustomDecompressLib/brotli/c/dec/decode.c:1193: undefined reference to `_kBrotliContextLookupTable'
/usr/bin/ld: /tmp/ccKzzHN0.ltrans0.ltrans.o: in function `DecodeCommandBlockSwitch':
...
/usr/bin/ld: /tmp/ccKzzHN0.ltrans0.ltrans.o: in function `BrotliUefiDecompress':
/home/edk2/edk2-stable202211/MdeModulePkg/Library/BrotliCustomDecompressLib/brotli/c/dec/decode.c:898: undefined reference to `_kBrotliPrefixCodeRanges'
/usr/bin/ld: /home/edk2/edk2-stable202211/MdeModulePkg/Library/BrotliCustomDecompressLib/brotli/c/dec/decode.c:1193: undefined reference to `_kBrotliContextLookupTable'
--
Timothy
[-- Attachment #2: Type: text/html, Size: 3963 bytes --]
prev parent reply other threads:[~2023-01-18 23:44 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-12 5:08 [PATCH V2] MdeModulePkg/Decompress: Add missing source file to Brotli library Chang, Abner
2023-01-12 15:23 ` [edk2-devel] " Michael D Kinney
2023-01-12 16:05 ` Chang, Abner
2023-01-12 16:08 ` He, Jiangang
2023-01-12 22:18 ` Lin, Kuei-Hung (Timothy)
2023-01-29 7:35 ` 回复: " gaoliming
2023-01-31 0:49 ` Lin, Kuei-Hung (Timothy)
2023-01-31 1:15 ` Michael D Kinney
2023-01-31 2:46 ` Lin, Kuei-Hung (Timothy)
2023-01-31 5:15 ` 回复: " gaoliming
2023-01-31 5:21 ` Lin, Kuei-Hung (Timothy)
2023-02-02 3:11 ` 回复: " gaoliming
2023-01-18 3:19 ` 回复: " gaoliming
2023-01-18 3:27 ` Chang, Abner
2023-01-18 23:44 ` Timothy Lin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17348.1674085484393166938@groups.io \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox