From mboxrd@z Thu Jan 1 00:00:00 1970 Subject: Re: [edk2-devel] [PATCH V2] MdeModulePkg/Decompress: Add missing source file to Brotli library To: Chang, Abner ,devel@edk2.groups.io From: "Timothy Lin" X-Originating-Location: North York, Ontario, CA (165.204.54.211) X-Originating-Platform: Windows Firefox 108 User-Agent: GROUPS.IO Web Poster MIME-Version: 1.0 Date: Wed, 18 Jan 2023 15:44:44 -0800 References: In-Reply-To: Message-ID: <17348.1674085484393166938@groups.io> Content-Type: multipart/alternative; boundary="4Zm3pchIzGysMiIB5YjZ" --4Zm3pchIzGysMiIB5YjZ Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable This patch tried to fix following build failure when linking the Brotli dec= ompress lib. Steps to replicate the issue: 1 - Attach a NULL lib to DxeIpl.inf in any project's .DSC, say OvmfPkgX64.d= sc MdeModulePkg/Core/DxeIplPeim/DxeIpl.inf { NULL|MdeModulePkg/Library/BrotliCustomDecompressLib/BrotliCustomDecompressL= ib.inf } 2 - Follow the EDKII'2 package build steps to build that project. Build.py = would compliain with following errors. ... /home/edk2/edk2-stable202211/MdeModulePkg/Library/BrotliCustomDecompressLib= /brotli/c/dec/decode.c:879: undefined reference to `_kBrotliPrefixCodeRange= s' /usr/bin/ld: /home/edk2/edk2-stable202211/MdeModulePkg/Library/BrotliCustom= DecompressLib/brotli/c/dec/decode.c:1193: undefined reference to `_kBrotliC= ontextLookupTable' /usr/bin/ld: /tmp/ccKzzHN0.ltrans0.ltrans.o: in function `DecodeCommandBloc= kSwitch': ... /usr/bin/ld: /tmp/ccKzzHN0.ltrans0.ltrans.o: in function `BrotliUefiDecompr= ess': /home/edk2/edk2-stable202211/MdeModulePkg/Library/BrotliCustomDecompressLib= /brotli/c/dec/decode.c:898: undefined reference to `_kBrotliPrefixCodeRange= s' /usr/bin/ld: /home/edk2/edk2-stable202211/MdeModulePkg/Library/BrotliCustom= DecompressLib/brotli/c/dec/decode.c:1193: undefined reference to `_kBrotliC= ontextLookupTable' -- Timothy --4Zm3pchIzGysMiIB5YjZ Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable
This= patch tried to fix following build failure when linking the Brotli decompr= ess lib.
&nbs= p;
Step= s to replicate the issue:
1 - = Attach a NULL lib to DxeIpl.inf in any project's .DSC, say OvmfPkgX64.dsc
  MdeModulePkg/Core/DxeIplPeim/DxeIpl.inf {
    <= LibraryClasses>
    &nbs= p; NULL|MdeModulePkg/Library/BrotliCustomDecompressLib/BrotliCustomDecompre= ssLib.inf
  }
2 - Follow the EDKII'2 package build steps to build that project. Buil= d.py would compliain with following errors.
...

/home/edk2/edk2-stab= le202211/MdeModulePkg/Library/BrotliCustomDecompressLib/brotli/c/dec/decode= .c:879: undefined reference to `_kBrotliPrefixCodeRanges'

/usr/bin/ld: /home/e= dk2/edk2-stable202211/MdeModulePkg/Library/BrotliCustomDecompressLib/brotli= /c/dec/decode.c:1193: undefined reference to `_kBrotliContextLookupTable'

/usr/bin/ld: /tmp/cc= KzzHN0.ltrans0.ltrans.o: in function `DecodeCommandBlockSwitch':

...

/usr/bin/ld: /tmp/cc= KzzHN0.ltrans0.ltrans.o: in function `BrotliUefiDecompress':

/home/edk2/edk2-stab= le202211/MdeModulePkg/Library/BrotliCustomDecompressLib/brotli/c/dec/decode= .c:898: undefined reference to `_kBrotliPrefixCodeRanges'

/usr/bin/ld: /home/e= dk2/edk2-stable202211/MdeModulePkg/Library/BrotliCustomDecompressLib/brotli= /c/dec/decode.c:1193: undefined reference to `_kBrotliContextLookupTable'
--
Timothy=

--4Zm3pchIzGysMiIB5YjZ--