* [PATCH] MdeModulePkg: Disambiguate the meaning of PcdDxeIplSwitchToLongMode @ 2023-01-09 3:34 Zhiguang Liu 2023-01-16 5:07 ` [edk2-devel] " Ni, Ray 0 siblings, 1 reply; 4+ messages in thread From: Zhiguang Liu @ 2023-01-09 3:34 UTC (permalink / raw) To: devel; +Cc: Zhiguang Liu, Jian J Wang, Liming Gao, Ray Ni Literally, the meaning of PcdDxeIplSwitchToLongMode is clear, indicating whether need switch to long mode when loading DxeCore. However, the comments in dec are confusing for the case where PEI core and DXE core are both in 64-bit. This patch makes it clear. PcdDxeIplSwitchToLongMode is true only when PEI core is 32-bit, and switch to long mode to load 64-bit DXE core. In other cases, this PCD is false. This also aligns with current usage in OvmfPkg. Cc: Jian J Wang <jian.j.wang@intel.com> Cc: Liming Gao <gaoliming@byosoft.com.cn> Cc: Ray Ni <ray.ni@intel.com> Signed-off-by: Zhiguang Liu <zhiguang.liu@intel.com> --- MdeModulePkg/MdeModulePkg.dec | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModulePkg/MdeModulePkg.dec index be5e829ca9..5e4535e353 100644 --- a/MdeModulePkg/MdeModulePkg.dec +++ b/MdeModulePkg/MdeModulePkg.dec @@ -922,10 +922,8 @@ [PcdsFeatureFlag.IA32, PcdsFeatureFlag.X64] ## Indicates if DxeIpl should switch to long mode to enter DXE phase. - # It is assumed that 64-bit DxeCore is built in firmware if it is true; otherwise 32-bit DxeCore - # is built in firmware.<BR><BR> # TRUE - DxeIpl will load a 64-bit DxeCore and switch to long mode to hand over to DxeCore.<BR> - # FALSE - DxeIpl will load a 32-bit DxeCore and perform stack switch to hand over to DxeCore.<BR> + # FALSE - DxeIpl will load a 32-bit or 64-bit DxeCore and perform stack switch to hand over to DxeCore.<BR> # @Prompt DxeIpl switch to long mode. gEfiMdeModulePkgTokenSpaceGuid.PcdDxeIplSwitchToLongMode|TRUE|BOOLEAN|0x0001003b -- 2.31.1.windows.1 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [edk2-devel] [PATCH] MdeModulePkg: Disambiguate the meaning of PcdDxeIplSwitchToLongMode 2023-01-09 3:34 [PATCH] MdeModulePkg: Disambiguate the meaning of PcdDxeIplSwitchToLongMode Zhiguang Liu @ 2023-01-16 5:07 ` Ni, Ray 0 siblings, 0 replies; 4+ messages in thread From: Ni, Ray @ 2023-01-16 5:07 UTC (permalink / raw) To: Zhiguang Liu, devel [-- Attachment #1: Type: text/plain, Size: 40 bytes --] Reviewed-by: Ray Ni <ray.ni@intel.com> [-- Attachment #2: Type: text/html, Size: 99 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
[parent not found: <1738869DA53A568A.3916@groups.io>]
* Re: [edk2-devel] [PATCH] MdeModulePkg: Disambiguate the meaning of PcdDxeIplSwitchToLongMode [not found] <1738869DA53A568A.3916@groups.io> @ 2023-02-01 5:28 ` Zhiguang Liu 2023-02-02 3:10 ` 回复: " gaoliming 0 siblings, 1 reply; 4+ messages in thread From: Zhiguang Liu @ 2023-02-01 5:28 UTC (permalink / raw) To: devel@edk2.groups.io, Liu, Zhiguang, Gao, Liming, Wang, Jian J; +Cc: Ni, Ray Hi Liming and Jian, What do you think about this patch? Thanks Zhiguang > -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of > Zhiguang Liu > Sent: Monday, January 9, 2023 11:34 AM > To: devel@edk2.groups.io > Cc: Liu, Zhiguang <zhiguang.liu@intel.com>; Wang, Jian J > <jian.j.wang@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Ni, Ray > <ray.ni@intel.com> > Subject: [edk2-devel] [PATCH] MdeModulePkg: Disambiguate the meaning > of PcdDxeIplSwitchToLongMode > > Literally, the meaning of PcdDxeIplSwitchToLongMode is clear, indicating > whether need switch to long mode when loading DxeCore. > However, the comments in dec are confusing for the case where PEI core > and DXE core are both in 64-bit. This patch makes it clear. > PcdDxeIplSwitchToLongMode is true only when PEI core is 32-bit, and switch > to long mode to load 64-bit DXE core. In other cases, this PCD is false. > This also aligns with current usage in OvmfPkg. > > Cc: Jian J Wang <jian.j.wang@intel.com> > Cc: Liming Gao <gaoliming@byosoft.com.cn> > Cc: Ray Ni <ray.ni@intel.com> > Signed-off-by: Zhiguang Liu <zhiguang.liu@intel.com> > --- > MdeModulePkg/MdeModulePkg.dec | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/MdeModulePkg/MdeModulePkg.dec > b/MdeModulePkg/MdeModulePkg.dec index be5e829ca9..5e4535e353 > 100644 > --- a/MdeModulePkg/MdeModulePkg.dec > +++ b/MdeModulePkg/MdeModulePkg.dec > @@ -922,10 +922,8 @@ > > [PcdsFeatureFlag.IA32, PcdsFeatureFlag.X64] > ## Indicates if DxeIpl should switch to long mode to enter DXE phase. > - # It is assumed that 64-bit DxeCore is built in firmware if it is true; > otherwise 32-bit DxeCore > - # is built in firmware.<BR><BR> > # TRUE - DxeIpl will load a 64-bit DxeCore and switch to long mode to hand > over to DxeCore.<BR> > - # FALSE - DxeIpl will load a 32-bit DxeCore and perform stack switch to > hand over to DxeCore.<BR> > + # FALSE - DxeIpl will load a 32-bit or 64-bit DxeCore and perform stack > switch to hand over to DxeCore.<BR> > # @Prompt DxeIpl switch to long mode. > > gEfiMdeModulePkgTokenSpaceGuid.PcdDxeIplSwitchToLongMode|TRUE|B > OOLEAN|0x0001003b > > -- > 2.31.1.windows.1 > > > > > ^ permalink raw reply [flat|nested] 4+ messages in thread
* 回复: [edk2-devel] [PATCH] MdeModulePkg: Disambiguate the meaning of PcdDxeIplSwitchToLongMode 2023-02-01 5:28 ` Zhiguang Liu @ 2023-02-02 3:10 ` gaoliming 2023-02-03 7:48 ` Zhiguang Liu 0 siblings, 1 reply; 4+ messages in thread From: gaoliming @ 2023-02-02 3:10 UTC (permalink / raw) To: 'Liu, Zhiguang', devel, 'Wang, Jian J'; +Cc: 'Ni, Ray' It is good to me. Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn> > -----邮件原件----- > 发件人: Liu, Zhiguang <zhiguang.liu@intel.com> > 发送时间: 2023年2月1日 13:28 > 收件人: devel@edk2.groups.io; Liu, Zhiguang <zhiguang.liu@intel.com>; Gao, > Liming <gaoliming@byosoft.com.cn>; Wang, Jian J <jian.j.wang@intel.com> > 抄送: Ni, Ray <ray.ni@intel.com> > 主题: RE: [edk2-devel] [PATCH] MdeModulePkg: Disambiguate the meaning > of PcdDxeIplSwitchToLongMode > > Hi Liming and Jian, > > What do you think about this patch? > > Thanks > Zhiguang > > > -----Original Message----- > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of > > Zhiguang Liu > > Sent: Monday, January 9, 2023 11:34 AM > > To: devel@edk2.groups.io > > Cc: Liu, Zhiguang <zhiguang.liu@intel.com>; Wang, Jian J > > <jian.j.wang@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Ni, Ray > > <ray.ni@intel.com> > > Subject: [edk2-devel] [PATCH] MdeModulePkg: Disambiguate the meaning > > of PcdDxeIplSwitchToLongMode > > > > Literally, the meaning of PcdDxeIplSwitchToLongMode is clear, indicating > > whether need switch to long mode when loading DxeCore. > > However, the comments in dec are confusing for the case where PEI core > > and DXE core are both in 64-bit. This patch makes it clear. > > PcdDxeIplSwitchToLongMode is true only when PEI core is 32-bit, and switch > > to long mode to load 64-bit DXE core. In other cases, this PCD is false. > > This also aligns with current usage in OvmfPkg. > > > > Cc: Jian J Wang <jian.j.wang@intel.com> > > Cc: Liming Gao <gaoliming@byosoft.com.cn> > > Cc: Ray Ni <ray.ni@intel.com> > > Signed-off-by: Zhiguang Liu <zhiguang.liu@intel.com> > > --- > > MdeModulePkg/MdeModulePkg.dec | 4 +--- > > 1 file changed, 1 insertion(+), 3 deletions(-) > > > > diff --git a/MdeModulePkg/MdeModulePkg.dec > > b/MdeModulePkg/MdeModulePkg.dec index be5e829ca9..5e4535e353 > > 100644 > > --- a/MdeModulePkg/MdeModulePkg.dec > > +++ b/MdeModulePkg/MdeModulePkg.dec > > @@ -922,10 +922,8 @@ > > > > [PcdsFeatureFlag.IA32, PcdsFeatureFlag.X64] > > ## Indicates if DxeIpl should switch to long mode to enter DXE phase. > > - # It is assumed that 64-bit DxeCore is built in firmware if it is true; > > otherwise 32-bit DxeCore > > - # is built in firmware.<BR><BR> > > # TRUE - DxeIpl will load a 64-bit DxeCore and switch to long > mode to hand > > over to DxeCore.<BR> > > - # FALSE - DxeIpl will load a 32-bit DxeCore and perform stack switch > to > > hand over to DxeCore.<BR> > > + # FALSE - DxeIpl will load a 32-bit or 64-bit DxeCore and perform > stack > > switch to hand over to DxeCore.<BR> > > # @Prompt DxeIpl switch to long mode. > > > > gEfiMdeModulePkgTokenSpaceGuid.PcdDxeIplSwitchToLongMode|TRUE|B > > OOLEAN|0x0001003b > > > > -- > > 2.31.1.windows.1 > > > > > > > > > > ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [edk2-devel] [PATCH] MdeModulePkg: Disambiguate the meaning of PcdDxeIplSwitchToLongMode 2023-02-02 3:10 ` 回复: " gaoliming @ 2023-02-03 7:48 ` Zhiguang Liu 0 siblings, 0 replies; 4+ messages in thread From: Zhiguang Liu @ 2023-02-03 7:48 UTC (permalink / raw) To: devel@edk2.groups.io, Gao, Liming, Wang, Jian J; +Cc: Ni, Ray Thanks Liming for reviewing this patch. Could you help push this change? Thanks Zhiguang > -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of > gaoliming via groups.io > Sent: Thursday, February 2, 2023 11:10 AM > To: Liu, Zhiguang <zhiguang.liu@intel.com>; devel@edk2.groups.io; Wang, > Jian J <jian.j.wang@intel.com> > Cc: Ni, Ray <ray.ni@intel.com> > Subject: 回复: [edk2-devel] [PATCH] MdeModulePkg: Disambiguate the > meaning of PcdDxeIplSwitchToLongMode > > It is good to me. Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn> > > > -----邮件原件----- > > 发件人: Liu, Zhiguang <zhiguang.liu@intel.com> > > 发送时间: 2023年2月1日 13:28 > > 收件人: devel@edk2.groups.io; Liu, Zhiguang <zhiguang.liu@intel.com>; > > Gao, Liming <gaoliming@byosoft.com.cn>; Wang, Jian J > > <jian.j.wang@intel.com> > > 抄送: Ni, Ray <ray.ni@intel.com> > > 主题: RE: [edk2-devel] [PATCH] MdeModulePkg: Disambiguate the > meaning of > > PcdDxeIplSwitchToLongMode > > > > Hi Liming and Jian, > > > > What do you think about this patch? > > > > Thanks > > Zhiguang > > > > > -----Original Message----- > > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of > > > Zhiguang Liu > > > Sent: Monday, January 9, 2023 11:34 AM > > > To: devel@edk2.groups.io > > > Cc: Liu, Zhiguang <zhiguang.liu@intel.com>; Wang, Jian J > > > <jian.j.wang@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Ni, > > > Ray <ray.ni@intel.com> > > > Subject: [edk2-devel] [PATCH] MdeModulePkg: Disambiguate the > meaning > > > of PcdDxeIplSwitchToLongMode > > > > > > Literally, the meaning of PcdDxeIplSwitchToLongMode is clear, > > > indicating whether need switch to long mode when loading DxeCore. > > > However, the comments in dec are confusing for the case where PEI > > > core and DXE core are both in 64-bit. This patch makes it clear. > > > PcdDxeIplSwitchToLongMode is true only when PEI core is 32-bit, and > switch > > > to long mode to load 64-bit DXE core. In other cases, this PCD is false. > > > This also aligns with current usage in OvmfPkg. > > > > > > Cc: Jian J Wang <jian.j.wang@intel.com> > > > Cc: Liming Gao <gaoliming@byosoft.com.cn> > > > Cc: Ray Ni <ray.ni@intel.com> > > > Signed-off-by: Zhiguang Liu <zhiguang.liu@intel.com> > > > --- > > > MdeModulePkg/MdeModulePkg.dec | 4 +--- > > > 1 file changed, 1 insertion(+), 3 deletions(-) > > > > > > diff --git a/MdeModulePkg/MdeModulePkg.dec > > > b/MdeModulePkg/MdeModulePkg.dec index be5e829ca9..5e4535e353 > > > 100644 > > > --- a/MdeModulePkg/MdeModulePkg.dec > > > +++ b/MdeModulePkg/MdeModulePkg.dec > > > @@ -922,10 +922,8 @@ > > > > > > [PcdsFeatureFlag.IA32, PcdsFeatureFlag.X64] > > > ## Indicates if DxeIpl should switch to long mode to enter DXE phase. > > > - # It is assumed that 64-bit DxeCore is built in firmware if it > > > is > true; > > > otherwise 32-bit DxeCore > > > - # is built in firmware.<BR><BR> > > > # TRUE - DxeIpl will load a 64-bit DxeCore and switch to long > > mode to hand > > > over to DxeCore.<BR> > > > - # FALSE - DxeIpl will load a 32-bit DxeCore and perform stack > switch > > to > > > hand over to DxeCore.<BR> > > > + # FALSE - DxeIpl will load a 32-bit or 64-bit DxeCore and perform > > stack > > > switch to hand over to DxeCore.<BR> > > > # @Prompt DxeIpl switch to long mode. > > > > > > > gEfiMdeModulePkgTokenSpaceGuid.PcdDxeIplSwitchToLongMode|TRUE|B > > > OOLEAN|0x0001003b > > > > > > -- > > > 2.31.1.windows.1 > > > > > > > > > > > > > > > > > > > > > > ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-02-03 7:49 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2023-01-09 3:34 [PATCH] MdeModulePkg: Disambiguate the meaning of PcdDxeIplSwitchToLongMode Zhiguang Liu 2023-01-16 5:07 ` [edk2-devel] " Ni, Ray [not found] <1738869DA53A568A.3916@groups.io> 2023-02-01 5:28 ` Zhiguang Liu 2023-02-02 3:10 ` 回复: " gaoliming 2023-02-03 7:48 ` Zhiguang Liu
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox