From mboxrd@z Thu Jan 1 00:00:00 1970 Subject: Re: [edk2-devel] [PATCH v1 03/12] ArmPkg: Add missing library headers to ArmPkg.dec To: PierreGondois ,devel@edk2.groups.io From: brbarkel@microsoft.com X-Originating-Location: Seattle, Washington, US (174.21.70.23) X-Originating-Platform: Windows Chrome 91 User-Agent: GROUPS.IO Web Poster MIME-Version: 1.0 Date: Wed, 21 Apr 2021 12:13:36 -0700 References: <20210421122048.11729-4-Pierre.Gondois@arm.com> In-Reply-To: <20210421122048.11729-4-Pierre.Gondois@arm.com> Message-ID: <17614.1619032416748367718@groups.io> Content-Type: multipart/alternative; boundary="p6BOkHiVgFD3pjsAMS46" --p6BOkHiVgFD3pjsAMS46 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable 1) To expedite the required reviews, you may want to add CC to the package = maintainers for ArmPkg to this commit message and email. I know a lot of pe= ople filter based on direct mention vs mailing list. 2) Generally, other packages have a brief description of the lib in the DE= C, as well. Example: https://github.com/tianocore/edk2/blob/d3b0d007a135284981fa750612a47234b83= 976f9/MdeModulePkg/MdeModulePkg.dec#L55 However, I see that this has not historically been maintained in this pack= age, so I'm not going to make a big deal of it. Reviewed-by: Bret Barkelew --p6BOkHiVgFD3pjsAMS46 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable

1) To expedite the required reviews, you may want to add CC to the packa= ge maintainers for ArmPkg to this commit message and email. I know a lot of= people filter based on direct mention vs mailing list.

2) Generally, other packages have a brief description of the lib in the= DEC, as well. Example:
https://github.com/tianocore/edk2/b= lob/d3b0d007a135284981fa750612a47234b83976f9/MdeModulePkg/MdeModulePkg.dec#= L55
However, I see that this has not historically been maintained = in this package, so I'm not going to make a big deal of it.

Revi= ewed-by: Bret Barkelew <bret.barkelew@microsoft.com>

--p6BOkHiVgFD3pjsAMS46--