From: "Wang, Yin" <yin.wang@intel.com>
To: devel@edk2.groups.io
Cc: kraxel@redhat.com, ard.biesheuvel@arm.com,
jordan.l.justen@intel.com, sunilvl@ventanamicro.com,
Yin Wang <yin.wang@intel.com>
Subject: [edk2-devel] [PATCH] OvmfPkg:Fix Hii form name mismatch with EFI variable
Date: Wed, 19 Jul 2023 15:45:20 +0800 [thread overview]
Message-ID: <1764780e0f2ebce561f7c9fafb2a225706a50348.1689752592.git.yin.wang@intel.com> (raw)
Onemore need change beside 16acacf24c ("OvmfPkg: fix PlatformConfig")
Find by sct cases:ExtractConfigConformance
ExtractConfigFunction
ExtractConfig_Func fail on RiscVVirtQemu.
Signed-off-by: Yin Wang <yin.wang@intel.com>
---
OvmfPkg/PlatformDxe/Platform.c | 2 +-
OvmfPkg/PlatformDxe/PlatformConfig.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/OvmfPkg/PlatformDxe/Platform.c b/OvmfPkg/PlatformDxe/Platform.c
index cd3bfd554c..c32439683d 100644
--- a/OvmfPkg/PlatformDxe/Platform.c
+++ b/OvmfPkg/PlatformDxe/Platform.c
@@ -279,7 +279,7 @@ ExtractConfig (
//
ConfigRequestHdr = HiiConstructConfigHdr (
&gOvmfPlatformConfigGuid,
- mVariableName,
+ mHiiFormName,
mImageHandle
);
if (ConfigRequestHdr == NULL) {
diff --git a/OvmfPkg/PlatformDxe/PlatformConfig.c b/OvmfPkg/PlatformDxe/PlatformConfig.c
index 4058a324eb..918c4a0de3 100644
--- a/OvmfPkg/PlatformDxe/PlatformConfig.c
+++ b/OvmfPkg/PlatformDxe/PlatformConfig.c
@@ -46,7 +46,7 @@ PlatformConfigSave (
// them more easily. For now, just save a binary dump.
//
Status = gRT->SetVariable (
- mVariableName,
+ mHiiFormName,
&gOvmfPlatformConfigGuid,
EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_BOOTSERVICE_ACCESS |
EFI_VARIABLE_RUNTIME_ACCESS,
@@ -93,7 +93,7 @@ PlatformConfigLoad (
// (Incompatible changes require a GUID change.)
//
Status = GetVariable2 (
- mVariableName,
+ mHiiFormName,
&gOvmfPlatformConfigGuid,
&Data,
&DataSize
--
2.34.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107043): https://edk2.groups.io/g/devel/message/107043
Mute This Topic: https://groups.io/mt/100231365/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next reply other threads:[~2023-07-19 7:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-19 7:45 Wang, Yin [this message]
2023-07-19 13:48 ` [edk2-devel] [PATCH] OvmfPkg:Fix Hii form name mismatch with EFI variable Gerd Hoffmann
2023-07-19 14:06 ` Wang, Yin
2023-07-20 1:02 ` Wang, Yin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1764780e0f2ebce561f7c9fafb2a225706a50348.1689752592.git.yin.wang@intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox