From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=66.187.233.73; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1C6ED210F41D9 for ; Fri, 17 Aug 2018 04:00:05 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7A42C814FDCE; Fri, 17 Aug 2018 11:00:04 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-113.rdu2.redhat.com [10.10.120.113]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9281F2026D6C; Fri, 17 Aug 2018 11:00:03 +0000 (UTC) To: "Li, Songpeng" , "edk2-devel@lists.01.org" Cc: "Fu, Siyuan" , "Wu, Jiaxin" References: <20180816013757.9680-1-songpeng.li@intel.com> <20180816013757.9680-5-songpeng.li@intel.com> From: Laszlo Ersek Message-ID: <177acbaf-02f7-ad6c-867b-b9e9b04ba8f3@redhat.com> Date: Fri, 17 Aug 2018 13:00:01 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.8]); Fri, 17 Aug 2018 11:00:04 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.8]); Fri, 17 Aug 2018 11:00:04 +0000 (UTC) for IP:'10.11.54.4' DOMAIN:'int-mx04.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'lersek@redhat.com' RCPT:'' Subject: Re: [PATCH 4/5] NetworkPkg: TlsDxe: Remove the redundant definition. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Aug 2018 11:00:06 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 08/17/18 03:36, Li, Songpeng wrote: > The file "NetworkPkg/TlsDxe/TlsProtocol.c" which contains "NetworkPkg/TlsDxe/TlsImpl.h" > is using the definition HTONS which defined in > TlsProtocol.c: > Line 264 *((UINT16 *) Data) = HTONS (TlsGetVersion (Instance->TlsConn)); > NetLib.h: > Line 230 #define HTONS(x) NTOHS(x) > > It cannot be removed. Please drop this patch. Right, I imagined that the code could be using just some macros from the lib class header, but no extern variables or functions. In such cases, I prefer to keep the lib class dependency in the INF file as well -- for example, the macro definition in the lib class header could change at some point and expand to a call to a new function that is also declared (as a new API) in the lib class header. In this case, even if all lib classes were extended with the new API, the client code would no longer link. So, as a general rule, including a lib class header implies that the INF file should specify the lib class dependency too. I agree that we should drop this patch. Thanks Laszlo > > > Thanks & Best Regards, > Songpeng > > >> -----Original Message----- >> From: Laszlo Ersek [mailto:lersek@redhat.com] >> Sent: Friday, August 17, 2018 3:27 AM >> To: Li, Songpeng ; edk2-devel@lists.01.org >> Cc: Fu, Siyuan ; Wu, Jiaxin >> Subject: Re: [edk2] [PATCH 4/5] NetworkPkg: TlsDxe: Remove the redundant >> definition. >> >> On 08/16/18 03:37, Songpeng Li wrote: >>> The definition NetLib has been removed. >> >> (1) I suggest calling this "lib class dependency", not "definition". >> >> (I could have made the same for a GUID removed in a previous patch, but >> there "definition" seemed acceptable. "GUID dependency" would be an >> improvement there as well.) >> >> The subject line could also say, "remove superfluous dependencies". >> >>> >>> Cc: Jiaxin Wu >>> Cc: Siyuan Fu >>> Cc: Laszlo Ersek >>> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1064 >>> Contributed-under: TianoCore Contribution Agreement 1.1 >>> Signed-off-by: Songpeng Li >>> --- >>> NetworkPkg/TlsDxe/TlsDxe.inf | 3 +-- >>> 1 file changed, 1 insertion(+), 2 deletions(-) >>> >>> diff --git a/NetworkPkg/TlsDxe/TlsDxe.inf b/NetworkPkg/TlsDxe/TlsDxe.inf >>> index 907feb735b..aaea0fc2ff 100644 >>> --- a/NetworkPkg/TlsDxe/TlsDxe.inf >>> +++ b/NetworkPkg/TlsDxe/TlsDxe.inf >>> @@ -5,7 +5,7 @@ >>> # This module produces EFI TLS (Transport Layer Security) Protocol and EFI >> TLS >>> # Service Binding Protocol, to provide TLS services. >>> # >>> -# Copyright (c) 2016, Intel Corporation. All rights reserved.
>>> +# Copyright (c) 2016 - 2018, Intel Corporation. All rights reserved.
>>> # >>> # This program and the accompanying materials >>> # are licensed and made available under the terms and conditions of the >> BSD License >>> @@ -52,7 +52,6 @@ >>> BaseLib >>> UefiLib >>> DebugLib >>> - NetLib >>> BaseCryptLib >>> TlsLib >>> >>> >> >> (2) This patch is incomplete; the file "NetworkPkg/TlsDxe/TlsImpl.h" >> contains: >> >> #include >> >> That header file is huge, so I won't try to audit, on a source code >> level, whether TlsDxe makes any NetLib API calls. >> >> (Note that even if it does, then the current patch need not necessarily >> cause a linking failure. Because, a NetLib dependency could be inherited >> through one of the library instances with which a given platform >> resolves the *other* lib class dependencies for TlsDxe.) >> >> So, please remove the #include too, and if TlsDxe still compiles, please >> resubmit the patch. (Otherwise, drop the patch, of course.) >> >> Thanks! >> Laszlo