Re: [PATCH v9 1/5] MdePkg: Add mipisyst submodule

["Michael Kubacki" <mikuback@linux.microsoft.com>]

Reviewed-by: Michael Kubacki <michael.kubacki@microsoft.com>

On 5/10/2023 7:39 PM, gua.guo@intel.com wrote:
> From: Gua Guo <gua.guo@intel.com>
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4144
> 
> This Library provides functions consuming MIPI SYS-T submodule.
> 
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> Cc: Guo Gua <gua.guo@intel.com>
> Cc: Chan Laura <laura.chan@intel.com>
> Cc: Prakashan Krishnadas Veliyathuparambil <krishnadas.veliyathuparambil.prakashan@intel.com>
> Cc: K N Karthik <karthik.k.n@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Michael Kubacki <mikuback@linux.microsoft.com>
> Signed-off-by: Guo Gua <gua.guo@intel.com>
> Reviewed-by: Leif Lindholm <quic_llindhol@quicinc.com>
> Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
> ---
>   .gitmodules                         | 3 +++
>   .pytool/CISettings.py               | 2 ++
>   MdePkg/Library/MipiSysTLib/mipisyst | 1 +
>   ReadMe.rst                          | 1 +
>   4 files changed, 7 insertions(+)
>   create mode 160000 MdePkg/Library/MipiSysTLib/mipisyst
> 
> diff --git a/.gitmodules b/.gitmodules
> index 6211c59724..387794f05e 100644
> --- a/.gitmodules
> +++ b/.gitmodules
> @@ -29,3 +29,6 @@
>   [submodule "MdePkg/Library/BaseFdtLib/libfdt"]
> 
>   	path = MdePkg/Library/BaseFdtLib/libfdt
> 
>   	url = https://github.com/devicetree-org/pylibfdt.git
> 
> +[submodule "MdePkg/Library/MipiSysTLib/mipisyst"]
> +	path = MdePkg/Library/MipiSysTLib/mipisyst
> +	url = https://github.com/MIPI-Alliance/public-mipi-sys-t.git
> diff --git a/.pytool/CISettings.py b/.pytool/CISettings.py
> index 2fb99f2a17..6fb7342f81 100644
> --- a/.pytool/CISettings.py
> +++ b/.pytool/CISettings.py
> @@ -197,6 +197,8 @@ class Settings(CiBuildSettingsManager, UpdateSettingsManager, SetupSettingsManag
>               "UnitTestFrameworkPkg/Library/SubhookLib/subhook", False))
> 
>           rs.append(RequiredSubmodule(
> 
>               "MdePkg/Library/BaseFdtLib/libfdt", False))
> 
> +        rs.append(RequiredSubmodule(
> 
> +            "MdePkg/Library/MipiSysTLib/mipisyst", False))
> 
>           return rs
> 
>   
> 
>       def GetName(self):
> 
> diff --git a/MdePkg/Library/MipiSysTLib/mipisyst b/MdePkg/Library/MipiSysTLib/mipisyst
> new file mode 160000
> index 0000000000..370b5944c0
> --- /dev/null
> +++ b/MdePkg/Library/MipiSysTLib/mipisyst
> @@ -0,0 +1 @@
> +Subproject commit 370b5944c046bab043dd8b133727b2135af7747a
> diff --git a/ReadMe.rst b/ReadMe.rst
> index d46c534229..ed1d482245 100644
> --- a/ReadMe.rst
> +++ b/ReadMe.rst
> @@ -97,6 +97,7 @@ that are covered by additional licenses.
>   -  `UnitTestFrameworkPkg/Library/SubhookLib/subhook <https://github.com/Zeex/subhook/blob/83d4e1ebef3588fae48b69a7352cc21801cb70bc/LICENSE.txt>`__
> 
>   -  `RedfishPkg/Library/JsonLib/jansson <https://github.com/akheron/jansson/blob/2882ead5bb90cf12a01b07b2c2361e24960fae02/LICENSE>`__
> 
>   -  `MdePkg/Library/BaseFdtLib/libfdt <https://github.com/devicetree-org/pylibfdt/blob/f39368a217496d32c4091a2dba4045b60649e3a5/BSD-2-Clause>`__
> 
> +-  `MdePkg/Library/MipiSysTLib/mipisyst <https://github.com/MIPI-Alliance/public-mipi-sys-t/blob/aae857d0d05ac65152ed24992a4acd834a0a107c/LICENSE>`__
> 
>   
> 
>   The EDK II Project is composed of packages. The maintainers for each package
> 
>   are listed in `Maintainers.txt <Maintainers.txt>`__.
>