From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mx.groups.io with SMTP id smtpd.web10.33861.1683764049348440515
 for <devel@edk2.groups.io>;
 Wed, 10 May 2023 17:14:09 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@linux.microsoft.com header.s=default header.b=lxslHk0O;
 spf=pass (domain: linux.microsoft.com, ip: 13.77.154.182, mailfrom: mikuback@linux.microsoft.com)
Received: from [192.168.4.22] (unknown [47.201.8.94])
	by linux.microsoft.com (Postfix) with ESMTPSA id 9A17320B26D7;
	Wed, 10 May 2023 17:14:07 -0700 (PDT)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 9A17320B26D7
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
	s=default; t=1683764048;
	bh=AbXZ+RCkx+bobtlzZ4iBiSUWPtg4uYuVXD5uM5qO7n0=;
	h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
	b=lxslHk0OKZS/TAKl509cJU4YAQTQjLuGEdEJcrz8vLrmjgnm+xBiVGMv0sS7r6sJJ
	 irTlGW9Xs8BlN0fbIvC6ERUCQYGio3EBHob9nwjaF5tEQnAys9BMOn/6TVrWC/Mwel
	 rc8TurzMRhS9eSHiuOIP/72VEsrbKZzo5II+hzh0=
Message-ID: <177cda30-c96c-d48f-ae24-5824019ed1e4@linux.microsoft.com>
Date: Wed, 10 May 2023 20:14:06 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.1
Subject: Re: [PATCH v9 1/5] MdePkg: Add mipisyst submodule
To: gua.guo@intel.com, devel@edk2.groups.io
Cc: Michael D Kinney <michael.d.kinney@intel.com>,
 Andrew Fish <afish@apple.com>, Leif Lindholm <quic_llindhol@quicinc.com>,
 Chan Laura <laura.chan@intel.com>,
 Prakashan Krishnadas Veliyathuparambil
 <krishnadas.veliyathuparambil.prakashan@intel.com>,
 K N Karthik <karthik.k.n@intel.com>, Liming Gao <gaoliming@byosoft.com.cn>,
 Zhiguang Liu <zhiguang.liu@intel.com>,
 Sean Brogan <sean.brogan@microsoft.com>
References: <20230510233930.1419-1-gua.guo@intel.com>
 <20230510233930.1419-2-gua.guo@intel.com>
From: "Michael Kubacki" <mikuback@linux.microsoft.com>
In-Reply-To: <20230510233930.1419-2-gua.guo@intel.com>
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Reviewed-by: Michael Kubacki <michael.kubacki@microsoft.com>

On 5/10/2023 7:39 PM, gua.guo@intel.com wrote:
> From: Gua Guo <gua.guo@intel.com>
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4144
> 
> This Library provides functions consuming MIPI SYS-T submodule.
> 
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> Cc: Guo Gua <gua.guo@intel.com>
> Cc: Chan Laura <laura.chan@intel.com>
> Cc: Prakashan Krishnadas Veliyathuparambil <krishnadas.veliyathuparambil.prakashan@intel.com>
> Cc: K N Karthik <karthik.k.n@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Michael Kubacki <mikuback@linux.microsoft.com>
> Signed-off-by: Guo Gua <gua.guo@intel.com>
> Reviewed-by: Leif Lindholm <quic_llindhol@quicinc.com>
> Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
> ---
>   .gitmodules                         | 3 +++
>   .pytool/CISettings.py               | 2 ++
>   MdePkg/Library/MipiSysTLib/mipisyst | 1 +
>   ReadMe.rst                          | 1 +
>   4 files changed, 7 insertions(+)
>   create mode 160000 MdePkg/Library/MipiSysTLib/mipisyst
> 
> diff --git a/.gitmodules b/.gitmodules
> index 6211c59724..387794f05e 100644
> --- a/.gitmodules
> +++ b/.gitmodules
> @@ -29,3 +29,6 @@
>   [submodule "MdePkg/Library/BaseFdtLib/libfdt"]
> 
>   	path = MdePkg/Library/BaseFdtLib/libfdt
> 
>   	url = https://github.com/devicetree-org/pylibfdt.git
> 
> +[submodule "MdePkg/Library/MipiSysTLib/mipisyst"]
> +	path = MdePkg/Library/MipiSysTLib/mipisyst
> +	url = https://github.com/MIPI-Alliance/public-mipi-sys-t.git
> diff --git a/.pytool/CISettings.py b/.pytool/CISettings.py
> index 2fb99f2a17..6fb7342f81 100644
> --- a/.pytool/CISettings.py
> +++ b/.pytool/CISettings.py
> @@ -197,6 +197,8 @@ class Settings(CiBuildSettingsManager, UpdateSettingsManager, SetupSettingsManag
>               "UnitTestFrameworkPkg/Library/SubhookLib/subhook", False))
> 
>           rs.append(RequiredSubmodule(
> 
>               "MdePkg/Library/BaseFdtLib/libfdt", False))
> 
> +        rs.append(RequiredSubmodule(
> 
> +            "MdePkg/Library/MipiSysTLib/mipisyst", False))
> 
>           return rs
> 
>   
> 
>       def GetName(self):
> 
> diff --git a/MdePkg/Library/MipiSysTLib/mipisyst b/MdePkg/Library/MipiSysTLib/mipisyst
> new file mode 160000
> index 0000000000..370b5944c0
> --- /dev/null
> +++ b/MdePkg/Library/MipiSysTLib/mipisyst
> @@ -0,0 +1 @@
> +Subproject commit 370b5944c046bab043dd8b133727b2135af7747a
> diff --git a/ReadMe.rst b/ReadMe.rst
> index d46c534229..ed1d482245 100644
> --- a/ReadMe.rst
> +++ b/ReadMe.rst
> @@ -97,6 +97,7 @@ that are covered by additional licenses.
>   -  `UnitTestFrameworkPkg/Library/SubhookLib/subhook <https://github.com/Zeex/subhook/blob/83d4e1ebef3588fae48b69a7352cc21801cb70bc/LICENSE.txt>`__
> 
>   -  `RedfishPkg/Library/JsonLib/jansson <https://github.com/akheron/jansson/blob/2882ead5bb90cf12a01b07b2c2361e24960fae02/LICENSE>`__
> 
>   -  `MdePkg/Library/BaseFdtLib/libfdt <https://github.com/devicetree-org/pylibfdt/blob/f39368a217496d32c4091a2dba4045b60649e3a5/BSD-2-Clause>`__
> 
> +-  `MdePkg/Library/MipiSysTLib/mipisyst <https://github.com/MIPI-Alliance/public-mipi-sys-t/blob/aae857d0d05ac65152ed24992a4acd834a0a107c/LICENSE>`__
> 
>   
> 
>   The EDK II Project is composed of packages. The maintainers for each package
> 
>   are listed in `Maintainers.txt <Maintainers.txt>`__.
>