From mboxrd@z Thu Jan 1 00:00:00 1970 Subject: Re: [edk2-devel] [PATCH v1 1/1] DynamicTables: Fix DT PCI interrupt flags parsing To: PierreGondois ,devel@edk2.groups.io From: "Sami Mujawar" X-Originating-Location: Cambridge, England, GB (217.140.106.51) X-Originating-Platform: Windows Firefox 102 User-Agent: GROUPS.IO Web Poster MIME-Version: 1.0 Date: Mon, 18 Jul 2022 05:27:28 -0700 References: <20220427144931.400413-1-Pierre.Gondois@arm.com> In-Reply-To: <20220427144931.400413-1-Pierre.Gondois@arm.com> Message-ID: <17823.1658147248508568038@groups.io> Content-Type: multipart/alternative; boundary="SGmBgmvvaTVcPfcW6VIE" --SGmBgmvvaTVcPfcW6VIE Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi Pierre, Please find my response inline marked [SAMI] Regards, Sami Mujawar On Wed, Apr 27, 2022 at 07:49 AM, PierreGondois wrote: >=20 > diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPci= =3D >=20 > eGenerator.c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtP= =3D >=20 > cieGenerator.c > index a34018151f2d..d5b1c153e98f 100644 > --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenera= =3D >=20 > tor.c > +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenera= =3D >=20 > tor.c > @@ -449,7 +449,7 @@ GeneratePrt ( > if ((Index > 0) && > (IrqMapInfo->IntcInterrupt.Interrupt >=3D3D 32) && > (IrqMapInfo->IntcInterrupt.Interrupt < 1020) && > - ((IrqMapInfo->IntcInterrupt.Flags & 0x3) !=3D3D BIT0)) > + ((IrqMapInfo->IntcInterrupt.Flags & 0x3) !=3D3D 0)) [SAMI] The BSA 1.0 says " Each legacy interrupt SPI must be programmed as l= evel-sensitive ". Considering this, I think the above check should be ((IrqMapInfo->IntcInter= rupt.Flags & 0xB) !=3D 0). If you agree, please let me know I will make that change locally before pus= hing. [/SAMI] >=20 > { > Status =3D3D EFI_INVALID_PARAMETER; > ASSERT_EFI_ERROR (Status); > diff --git a/DynamicTablesPkg/Library/FdtHwInfoParserLib/FdtUtility.h b/D= =3D >=20 > ynamicTablesPkg/Library/FdtHwInfoParserLib/FdtUtility.h --SGmBgmvvaTVcPfcW6VIE Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi Pierre,

Please find my response inline marked [SAMI]
Regards,

Sami Mujawar

On Wed, Apr 27, 2022 at 07:4= 9 AM, PierreGondois wrote:
diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibA= rm/SsdtPci=3D
eGenerator.c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsd= tPcieLibArm/SsdtP=3D
cieGenerator.c
index a34018151f2d..d5b1c153e= 98f 100644
--- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/= SsdtPcieGenera=3D
tor.c
+++ b/DynamicTablesPkg/Library/Acpi/Arm/A= cpiSsdtPcieLibArm/SsdtPcieGenera=3D
tor.c
@@ -449,7 +449,7 @@ Gen= eratePrt (
if ((Index > 0) &&
(IrqMapInfo->IntcInte= rrupt.Interrupt >=3D3D 32) &&
(IrqMapInfo->IntcInterrupt= .Interrupt < 1020) &&
- ((IrqMapInfo->IntcInterrupt.Flag= s & 0x3) !=3D3D BIT0))
+ ((IrqMapInfo->IntcInterrupt.Flags &= ; 0x3) !=3D3D 0))
[SAMI] The BSA 1.0 says "Each lega= cy interrupt SPI must be programmed as level-sensitive".
Consi= dering this, I think the above check should be ((IrqMapInfo->IntcInterru= pt.Flags & 0xB) !=3D 0).
If you agree, please let me know I will = make that change locally before pushing.
[/SAMI]
{
Status =3D3D EFI_INVALID_PARAMETER;
ASSERT_EFI_ERRO= R (Status);
diff --git a/DynamicTablesPkg/Library/FdtHwInfoParserLib/F= dtUtility.h b/D=3D
ynamicTablesPkg/Library/FdtHwInfoParserLib/FdtUtili= ty.h
--SGmBgmvvaTVcPfcW6VIE--