Re: [edk2-devel] [edk2] NOOPT and PcdOptimizeCompilerEnable

["Andrew Fish" <afish@apple.com>]

[-- Attachment #1: Type: text/plain, Size: 4359 bytes --]

Liming,

Thanks for looking into this. It is always good to try and do things the same way on different tool chains if possible. 

Thanks,

Andrew Fish

> On Nov 3, 2019, at 9:40 PM, Liming Gao <liming.gao@intel.com> wrote:
> 
> Andrew:
>   I did some investigation. Seemly, there is no way to disable VS command line warning.
>
> Thanks
> Liming
> From: devel@edk2.groups.io <mailto:devel@edk2.groups.io> [mailto:devel@edk2.groups.io <mailto:devel@edk2.groups.io>] On Behalf Of Andrew Fish via Groups.Io
> Sent: Thursday, October 31, 2019 10:07 AM
> To: devel@edk2.groups.io <mailto:devel@edk2.groups.io>; Gao, Liming <liming.gao@intel.com <mailto:liming.gao@intel.com>>
> Cc: tigerliu@zhaoxin.com <mailto:tigerliu@zhaoxin.com>
> Subject: Re: [edk2-devel] [edk2] NOOPT and PcdOptimizeCompilerEnable
>
> Liming,
>
> For gcc/clang if you repeat an argument the last argument wins. This is the default behavior and it does not warn, as it is designed to work with features like PcdOptimizeCompilerEnable. 
>
> If VC++ warns for this behavior should we disable D9025 for VC++ so all the toolchains have the same behavior?
>
> Thanks,
>
> Andrew Fish
> 
> 
> On Oct 30, 2019, at 6:46 PM, Liming Gao <liming.gao@intel.com <mailto:liming.gao@intel.com>> wrote:
>
> Yes. This is the expect behavior. Compiler optimization is disabled, then Od option will be used for VS tool chain.
>
> From: devel@edk2.groups.io <mailto:devel@edk2.groups.io> [mailto:devel@edk2.groups.io <mailto:devel@edk2.groups.io>] On Behalf Of Tiger Liu(BJ-RD)
> Sent: Thursday, October 31, 2019 9:40 AM
> To: devel@edk2.groups.io <mailto:devel@edk2.groups.io>; Gao, Liming <liming.gao@intel.com <mailto:liming.gao@intel.com>>
> Subject: Re: [edk2-devel] [edk2] NOOPT and PcdOptimizeCompilerEnable
>
> Hi, Liming:
> Thanks for your explanation.
>
> If setting PcdOptimizeCompilerEnable as disable, then will cause D9025 compiling warning.
> Such as:
> cl : Command line warning D9025 : overriding '/O1' with '/Od'
>
> So, is it ok?
>
> Thanks
> 发件人: devel@edk2.groups.io <mailto:devel@edk2.groups.io> <devel@edk2.groups.io <mailto:devel@edk2.groups.io>> 代表 Liming Gao
> 发送时间: 2019年10月30日 23:00
> 收件人: devel@edk2.groups.io <mailto:devel@edk2.groups.io>; Tiger Liu(BJ-RD) <TigerLiu@zhaoxin.com <mailto:TigerLiu@zhaoxin.com>>
> 主题: Re: [edk2-devel] [edk2] NOOPT and PcdOptimizeCompilerEnable
>
> NOOPT is build target. It includes the compiler option to disable optimization. If the platform supports NOOPT target, it can be built with -b NOOPT.
>
> PcdOptimizeCompilerEnable is one feature PCD defined in edk2-platforms. It can be used to control the compiler option in [BuildOptions] section. It can also be used for DEBUG or RELEASE target. 
>
> Thanks
> Liming
>  <>From: devel@edk2.groups.io <mailto:devel@edk2.groups.io> <devel@edk2.groups.io <mailto:devel@edk2.groups.io>> On Behalf Of Tiger Liu(BJ-RD)
> Sent: Tuesday, October 29, 2019 7:01 PM
> To: devel@edk2.groups.io <mailto:devel@edk2.groups.io>
> Subject: [edk2-devel] [edk2] NOOPT and PcdOptimizeCompilerEnable
>
> Hi, All:
> I have a question about NOOPT and PcdOptimizeCompilerEnable.
>
> If Target = NOOPT, then will disable all optimizations.
> And PcdOptimizeCompilerEnable has the same function.
>
> So, What’s the relationship between PcdOptimizeCompilerEnable and NOOPT?
>
> Thanks
>
> Best wishes,
>
> 
> 保密声明：
> 本邮件含有保密或专有信息，仅供指定收件人使用。严禁对本邮件或其内容做任何未经授权的查阅、使用、复制或转发。
> CONFIDENTIAL NOTE:
> This email contains confidential or legally privileged information and is for the sole use of its intended recipient. Any unauthorized review, use, copying or forwarding of this email or the content of this email is strictly prohibited.
>
> 
> 保密声明：
> 本邮件含有保密或专有信息，仅供指定收件人使用。严禁对本邮件或其内容做任何未经授权的查阅、使用、复制或转发。
> CONFIDENTIAL NOTE:
> This email contains confidential or legally privileged information and is for the sole use of its intended recipient. Any unauthorized review, use, copying or forwarding of this email or the content of this email is strictly prohibited.
>
> 


[-- Attachment #2: Type: text/html, Size: 29281 bytes --]