public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Arun K" <arunk@ami.com>
To: Chang, Abner <abner.chang@amd.com>,devel@edk2.groups.io
Subject: Re: [edk2-devel] [edk2-platforms][PATCH V3-1] IpmiFeaturePkg:Provided multiple IPMI interface support in DXE and SMM
Date: Tue, 20 Jun 2023 23:38:40 -0700	[thread overview]
Message-ID: <17916.1687329520328171515@groups.io> (raw)
In-Reply-To: <MN2PR12MB39665000D73045E73A2BBB75EA55A@MN2PR12MB3966.namprd12.prod.outlook.com>

[-- Attachment #1: Type: text/plain, Size: 430 bytes --]

Hi Isaac,

Seems Uncrustify has not done this for IpmiFeaturePkg. Do I need to provide the changes for the complete IpmiFeaturePkg or for my changes alone fine?

Sure, I will use the PCD directly instead of macros. the main concern of #if is to avoid compiler warnings when the library is not mapped for the disabled interfaces. so, can we proceed with #if logic?
Please let me know your comments on this.

Thanks,
Arun

[-- Attachment #2: Type: text/html, Size: 499 bytes --]

  parent reply	other threads:[~2023-06-21  6:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-12 12:52 [edk2-devel][edk2-platforms][PATCH V3-1] IpmiFeaturePkg:Provided multiple IPMI interface support in DXE and SMM Arun K
2023-06-13  0:27 ` Isaac Oram
2023-06-13  4:35   ` Chang, Abner
2023-06-13 17:12     ` Isaac Oram
2023-06-21  6:38     ` Arun K [this message]
2023-08-14 12:55       ` [edk2-devel] [edk2-platforms][PATCH " Huang, Yanbo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=17916.1687329520328171515@groups.io \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox